summaryrefslogtreecommitdiffstats
path: root/Source/cmGlobalGenerator.h
diff options
context:
space:
mode:
authorDaniel Pfeifer <daniel@pfeifer-mail.de>2016-05-26 19:58:51 (GMT)
committerDaniel Pfeifer <daniel@pfeifer-mail.de>2016-05-26 19:58:51 (GMT)
commit618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (patch)
treeabaabfaae8a9f5448d7ee062c757c61254792995 /Source/cmGlobalGenerator.h
parentacd8a73044e879286f0cfa24b54497a8307f204b (diff)
downloadCMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.zip
CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.gz
CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.bz2
Pass arguments that are not modified as const&.
Use clang-tidy's performance-unnecessary-value-param checker to find value parameter declarations of expensive to copy types that are not modified inside the function. Ignore findings in kwsys. After applying the fix-its, manually change `const T&` to `T const&`.
Diffstat (limited to 'Source/cmGlobalGenerator.h')
-rw-r--r--Source/cmGlobalGenerator.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/cmGlobalGenerator.h b/Source/cmGlobalGenerator.h
index fcf8127..2575911 100644
--- a/Source/cmGlobalGenerator.h
+++ b/Source/cmGlobalGenerator.h
@@ -348,8 +348,8 @@ public:
void CreateEvaluationSourceFiles(std::string const& config) const;
- void SetFilenameTargetDepends(cmSourceFile* sf,
- std::set<const cmGeneratorTarget*> tgts);
+ void SetFilenameTargetDepends(
+ cmSourceFile* sf, std::set<cmGeneratorTarget const*> const& tgts);
const std::set<const cmGeneratorTarget*>& GetFilenameTargetDepends(
cmSourceFile* sf) const;