summaryrefslogtreecommitdiffstats
path: root/Source/cmGlobalNinjaGenerator.cxx
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2018-10-30 13:37:07 (GMT)
committerBrad King <brad.king@kitware.com>2018-10-31 13:20:15 (GMT)
commit1acd1c2b50f461ee2cf90fb7166240f180147f19 (patch)
tree2d9a547be3dc57bc0538738d81276dc9256e1e52 /Source/cmGlobalNinjaGenerator.cxx
parent3e5548784da085ee3a5ce3f7213c0cf281b68f31 (diff)
downloadCMake-1acd1c2b50f461ee2cf90fb7166240f180147f19.zip
CMake-1acd1c2b50f461ee2cf90fb7166240f180147f19.tar.gz
CMake-1acd1c2b50f461ee2cf90fb7166240f180147f19.tar.bz2
CSharp: Fix regression in VS project type selection for custom target
A target created by `add_custom_target` should always be a `.vcxproj` file even if it has `.cs` sources involved in custom commands and such. The latter case was broken by refactoring in commit v3.12.0-rc1~160^2~7 (remove TargetIsCSharpOnly() and use methods from cmGeneratorTarget, 2018-03-19). The reason is that the `HasLanguage` method added by commit v3.12.0-rc1~239^2~6 (cmGeneratorTarget: add HasLanguage() as wrapper for GetLanguages(), 2018-03-19) does not check the target type and so is not a suitable check for deciding the project file extension. The `HasLanguage` method was an attempt at an abstraction that turns out not to work very well. Replace it with a dedicated `IsCSharpOnly` method that considers the target type, sources, and non-transitive `LINKER_LANGUAGE`. Fixes: #18515
Diffstat (limited to 'Source/cmGlobalNinjaGenerator.cxx')
0 files changed, 0 insertions, 0 deletions