Remove unnecessary local copies.

Use clang-tidy's performance-unnecessary-copy-initialization checker.
After applying the fix-its (which turns the copies into const&), revise
the changes and see whether the copies can be removed entirely by using
the original instead.

1 files changed, 3 insertions, 4 deletions

diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx
index a1c9d76..143ad92 100644
--- a/Source/cmGlobalNinjaGenerator.cxx
+++ b/Source/cmGlobalNinjaGenerator.cxx
@@ -46,15 +46,14 @@ void cmGlobalNinjaGenerator::WriteComment(std::ostream& os,
   if (comment.empty())
     return;
 
-  std::string replace = comment;
   std::string::size_type lpos = 0;
   std::string::size_type rpos;
   os << "\n#############################################\n";
-  while ((rpos = replace.find('\n', lpos)) != std::string::npos) {
-    os << "# " << replace.substr(lpos, rpos - lpos) << "\n";
+  while ((rpos = comment.find('\n', lpos)) != std::string::npos) {
+    os << "# " << comment.substr(lpos, rpos - lpos) << "\n";
     lpos = rpos + 1;
   }
-  os << "# " << replace.substr(lpos) << "\n\n";
+  os << "# " << comment.substr(lpos) << "\n\n";
 }
 
 std::string cmGlobalNinjaGenerator::EncodeRuleName(std::string const& name)