diff options
author | Brad King <brad.king@kitware.com> | 2020-12-14 15:14:19 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2020-12-14 15:14:19 (GMT) |
commit | 1144d25094b6a07409bec1a6bf9d16ec820ab7f0 (patch) | |
tree | 8644e468dc088dfaa64296a3412fc2443fe27a50 /Source/cmGlobalNinjaGenerator.cxx | |
parent | 6aff058ab4a2d54a316dbaa536572ad71efb8b51 (diff) | |
parent | 73a961eaba84c622480eff84671c7e3f6a7f61c4 (diff) | |
download | CMake-1144d25094b6a07409bec1a6bf9d16ec820ab7f0.zip CMake-1144d25094b6a07409bec1a6bf9d16ec820ab7f0.tar.gz CMake-1144d25094b6a07409bec1a6bf9d16ec820ab7f0.tar.bz2 |
Merge branch 'backport-ninja-no-cleandead' into ninja-no-cleandead
Diffstat (limited to 'Source/cmGlobalNinjaGenerator.cxx')
-rw-r--r-- | Source/cmGlobalNinjaGenerator.cxx | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/Source/cmGlobalNinjaGenerator.cxx b/Source/cmGlobalNinjaGenerator.cxx index d477c7d..02ffaf7 100644 --- a/Source/cmGlobalNinjaGenerator.cxx +++ b/Source/cmGlobalNinjaGenerator.cxx @@ -581,18 +581,9 @@ void cmGlobalNinjaGenerator::CleanMetaData() // Skip some ninja tools if they need 'build.ninja' but it is missing. bool const missingBuildManifest = expectBuildManifest && - (this->NinjaSupportsCleanDeadTool || - this->NinjaSupportsUnconditionalRecompactTool) && + this->NinjaSupportsUnconditionalRecompactTool && !cmSystemTools::FileExists("build.ninja"); - // The `cleandead` tool needs to know about all outputs in the build we just - // wrote out. Ninja-Multi doesn't have a single `build.ninja` we can use that - // is the union of all generated configurations, so we can't run it reliably - // in that case. - if (this->NinjaSupportsCleanDeadTool && !this->DisableCleandead && - expectBuildManifest && !missingBuildManifest) { - run_ninja_tool({ "cleandead" }); - } // The `recompact` tool loads the manifest. As above, we don't have a single // `build.ninja` to load for this in Ninja-Multi. This may be relaxed in the // future pending further investigation into how Ninja works upstream @@ -679,9 +670,6 @@ void cmGlobalNinjaGenerator::CheckNinjaFeatures() } } } - this->NinjaSupportsCleanDeadTool = !cmSystemTools::VersionCompare( - cmSystemTools::OP_LESS, this->NinjaVersion.c_str(), - RequiredNinjaVersionForCleanDeadTool().c_str()); this->NinjaSupportsUnconditionalRecompactTool = !cmSystemTools::VersionCompare( cmSystemTools::OP_LESS, this->NinjaVersion.c_str(), |