diff options
| author | Brad King <brad.king@kitware.com> | 2019-09-09 17:38:01 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2019-09-09 17:51:23 (GMT) |
| commit | 175d8c4bf6505eeb02bb588527f3ff7b5eb143b9 (patch) | |
| tree | 4c9730af3501122952e493c54e6ad4c73dc838cd /Source/cmGlobalXCodeGenerator.cxx | |
| parent | 7c5ec91301f31e7caff6524ab83b5bb5c614d5d7 (diff) | |
| download | CMake-175d8c4bf6505eeb02bb588527f3ff7b5eb143b9.zip CMake-175d8c4bf6505eeb02bb588527f3ff7b5eb143b9.tar.gz CMake-175d8c4bf6505eeb02bb588527f3ff7b5eb143b9.tar.bz2 | |
clang-tidy: Resolve performance-unnecessary-value-param diagnostics
Fix diagnostics that appear on macOS with clang-tidy-8. Suppress cases
where we intentionally take an argument by value to let the caller
choose whether to copy or move.
Diffstat (limited to 'Source/cmGlobalXCodeGenerator.cxx')
| -rw-r--r-- | Source/cmGlobalXCodeGenerator.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/cmGlobalXCodeGenerator.cxx b/Source/cmGlobalXCodeGenerator.cxx index 10f822f..502a642 100644 --- a/Source/cmGlobalXCodeGenerator.cxx +++ b/Source/cmGlobalXCodeGenerator.cxx @@ -1433,7 +1433,7 @@ cmXCodeObject* cmGlobalXCodeGenerator::CreateBuildPhase( void cmGlobalXCodeGenerator::CreateCustomCommands( cmXCodeObject* buildPhases, cmXCodeObject* sourceBuildPhase, cmXCodeObject* headerBuildPhase, cmXCodeObject* resourceBuildPhase, - std::vector<cmXCodeObject*> contentBuildPhases, + std::vector<cmXCodeObject*> const& contentBuildPhases, cmXCodeObject* frameworkBuildPhase, cmGeneratorTarget* gtgt) { std::vector<cmCustomCommand> const& prebuild = gtgt->GetPreBuildCommands(); |