diff options
author | Kitware Robot <kwrobot@kitware.com> | 2016-05-16 14:34:04 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2016-05-16 20:05:19 (GMT) |
commit | d9fd2f5402eeaa345691313658e02b51038f570b (patch) | |
tree | dca71b9a7e267f4c6300da3eb770415381726785 /Source/cmGraphVizWriter.cxx | |
parent | 82df6deaafb36cbbfd450202bb20b320f637751a (diff) | |
download | CMake-d9fd2f5402eeaa345691313658e02b51038f570b.zip CMake-d9fd2f5402eeaa345691313658e02b51038f570b.tar.gz CMake-d9fd2f5402eeaa345691313658e02b51038f570b.tar.bz2 |
Revise C++ coding style using clang-format
Run the `Utilities/Scripts/clang-format.bash` script to update
all our C++ code to a new style defined by `.clang-format`.
Use `clang-format` version 3.8.
* If you reached this commit for a line in `git blame`, re-run the blame
operation starting at the parent of this commit to see older history
for the content.
* See the parent commit for instructions to rebase a change across this
style transition commit.
Diffstat (limited to 'Source/cmGraphVizWriter.cxx')
-rw-r--r-- | Source/cmGraphVizWriter.cxx | 430 |
1 files changed, 171 insertions, 259 deletions
diff --git a/Source/cmGraphVizWriter.cxx b/Source/cmGraphVizWriter.cxx index 76b6430..20cd171 100644 --- a/Source/cmGraphVizWriter.cxx +++ b/Source/cmGraphVizWriter.cxx @@ -16,17 +16,13 @@ #include "cmLocalGenerator.h" #include "cmMakefile.h" - - static const char* getShapeForTarget(const cmGeneratorTarget* target) { - if (!target) - { + if (!target) { return "ellipse"; - } + } - switch ( target->GetType() ) - { + switch (target->GetType()) { case cmState::EXECUTABLE: return "house"; case cmState::STATIC_LIBRARY: @@ -37,31 +33,29 @@ static const char* getShapeForTarget(const cmGeneratorTarget* target) return "octagon"; default: break; - } + } return "box"; } - -cmGraphVizWriter::cmGraphVizWriter(const std::vector<cmLocalGenerator*>& - localGenerators) -:GraphType("digraph") -,GraphName("GG") -,GraphHeader("node [\n fontsize = \"12\"\n];") -,GraphNodePrefix("node") -,LocalGenerators(localGenerators) -,GenerateForExecutables(true) -,GenerateForStaticLibs(true) -,GenerateForSharedLibs(true) -,GenerateForModuleLibs(true) -,GenerateForExternals(true) -,GeneratePerTarget(true) -,GenerateDependers(true) -,HaveTargetsAndLibs(false) +cmGraphVizWriter::cmGraphVizWriter( + const std::vector<cmLocalGenerator*>& localGenerators) + : GraphType("digraph") + , GraphName("GG") + , GraphHeader("node [\n fontsize = \"12\"\n];") + , GraphNodePrefix("node") + , LocalGenerators(localGenerators) + , GenerateForExecutables(true) + , GenerateForStaticLibs(true) + , GenerateForSharedLibs(true) + , GenerateForModuleLibs(true) + , GenerateForExternals(true) + , GeneratePerTarget(true) + , GenerateDependers(true) + , HaveTargetsAndLibs(false) { } - void cmGraphVizWriter::ReadSettings(const char* settingsFileName, const char* fallbackSettingsFileName) { @@ -71,36 +65,32 @@ void cmGraphVizWriter::ReadSettings(const char* settingsFileName, cm.GetCurrentSnapshot().SetDefaultDefinitions(); cmGlobalGenerator ggi(&cm); cmsys::auto_ptr<cmMakefile> mf( - new cmMakefile(&ggi, cm.GetCurrentSnapshot())); + new cmMakefile(&ggi, cm.GetCurrentSnapshot())); cmsys::auto_ptr<cmLocalGenerator> lg(ggi.CreateLocalGenerator(mf.get())); const char* inFileName = settingsFileName; - if ( !cmSystemTools::FileExists(inFileName) ) - { + if (!cmSystemTools::FileExists(inFileName)) { inFileName = fallbackSettingsFileName; - if ( !cmSystemTools::FileExists(inFileName) ) - { + if (!cmSystemTools::FileExists(inFileName)) { return; - } } + } - if ( !mf->ReadListFile(inFileName) ) - { + if (!mf->ReadListFile(inFileName)) { cmSystemTools::Error("Problem opening GraphViz options file: ", inFileName); return; - } + } std::cout << "Reading GraphViz options file: " << inFileName << std::endl; -#define __set_if_set(var, cmakeDefinition) \ - { \ - const char* value = mf->GetDefinition(cmakeDefinition); \ - if ( value ) \ - { \ - var = value; \ - } \ +#define __set_if_set(var, cmakeDefinition) \ + { \ + const char* value = mf->GetDefinition(cmakeDefinition); \ + if (value) { \ + var = value; \ + } \ } __set_if_set(this->GraphType, "GRAPHVIZ_GRAPH_TYPE"); @@ -108,13 +98,12 @@ void cmGraphVizWriter::ReadSettings(const char* settingsFileName, __set_if_set(this->GraphHeader, "GRAPHVIZ_GRAPH_HEADER"); __set_if_set(this->GraphNodePrefix, "GRAPHVIZ_NODE_PREFIX"); -#define __set_bool_if_set(var, cmakeDefinition) \ - { \ - const char* value = mf->GetDefinition(cmakeDefinition); \ - if ( value ) \ - { \ - var = mf->IsOn(cmakeDefinition); \ - } \ +#define __set_bool_if_set(var, cmakeDefinition) \ + { \ + const char* value = mf->GetDefinition(cmakeDefinition); \ + if (value) { \ + var = mf->IsOn(cmakeDefinition); \ + } \ } __set_bool_if_set(this->GenerateForExecutables, "GRAPHVIZ_EXECUTABLES"); @@ -129,55 +118,44 @@ void cmGraphVizWriter::ReadSettings(const char* settingsFileName, __set_if_set(ignoreTargetsRegexes, "GRAPHVIZ_IGNORE_TARGETS"); this->TargetsToIgnoreRegex.clear(); - if (!ignoreTargetsRegexes.empty()) - { + if (!ignoreTargetsRegexes.empty()) { std::vector<std::string> ignoreTargetsRegExVector; cmSystemTools::ExpandListArgument(ignoreTargetsRegexes, ignoreTargetsRegExVector); - for(std::vector<std::string>::const_iterator itvIt - = ignoreTargetsRegExVector.begin(); - itvIt != ignoreTargetsRegExVector.end(); - ++ itvIt ) - { + for (std::vector<std::string>::const_iterator itvIt = + ignoreTargetsRegExVector.begin(); + itvIt != ignoreTargetsRegExVector.end(); ++itvIt) { std::string currentRegexString(*itvIt); cmsys::RegularExpression currentRegex; - if (!currentRegex.compile(currentRegexString.c_str())) - { + if (!currentRegex.compile(currentRegexString.c_str())) { std::cerr << "Could not compile bad regex \"" << currentRegexString << "\"" << std::endl; - } - this->TargetsToIgnoreRegex.push_back(currentRegex); } + this->TargetsToIgnoreRegex.push_back(currentRegex); } - + } } - // Iterate over all targets and write for each one a graph which shows // which other targets depend on it. void cmGraphVizWriter::WriteTargetDependersFiles(const char* fileName) { - if(this->GenerateDependers == false) - { + if (this->GenerateDependers == false) { return; - } + } this->CollectTargetsAndLibs(); - for(std::map<std::string, const cmGeneratorTarget*>::const_iterator ptrIt = - this->TargetPtrs.begin(); - ptrIt != this->TargetPtrs.end(); - ++ptrIt) - { - if (ptrIt->second == NULL) - { + for (std::map<std::string, const cmGeneratorTarget*>::const_iterator ptrIt = + this->TargetPtrs.begin(); + ptrIt != this->TargetPtrs.end(); ++ptrIt) { + if (ptrIt->second == NULL) { continue; - } + } - if (this->GenerateForTargetType(ptrIt->second->GetType()) == false) - { + if (this->GenerateForTargetType(ptrIt->second->GetType()) == false) { continue; - } + } std::string currentFilename = fileName; currentFilename += "."; @@ -185,10 +163,9 @@ void cmGraphVizWriter::WriteTargetDependersFiles(const char* fileName) currentFilename += ".dependers"; cmGeneratedFileStream str(currentFilename.c_str()); - if ( !str ) - { + if (!str) { return; - } + } std::set<std::string> insertedConnections; std::set<std::string> insertedNodes; @@ -196,39 +173,33 @@ void cmGraphVizWriter::WriteTargetDependersFiles(const char* fileName) std::cout << "Writing " << currentFilename << "..." << std::endl; this->WriteHeader(str); - this->WriteDependerConnections(ptrIt->first, - insertedNodes, insertedConnections, str); + this->WriteDependerConnections(ptrIt->first, insertedNodes, + insertedConnections, str); this->WriteFooter(str); - } + } } - // Iterate over all targets and write for each one a graph which shows // on which targets it depends. void cmGraphVizWriter::WritePerTargetFiles(const char* fileName) { - if(this->GeneratePerTarget == false) - { + if (this->GeneratePerTarget == false) { return; - } + } this->CollectTargetsAndLibs(); - for(std::map<std::string, const cmGeneratorTarget*>::const_iterator ptrIt = - this->TargetPtrs.begin(); - ptrIt != this->TargetPtrs.end(); - ++ptrIt) - { - if (ptrIt->second == NULL) - { + for (std::map<std::string, const cmGeneratorTarget*>::const_iterator ptrIt = + this->TargetPtrs.begin(); + ptrIt != this->TargetPtrs.end(); ++ptrIt) { + if (ptrIt->second == NULL) { continue; - } + } - if (this->GenerateForTargetType(ptrIt->second->GetType()) == false) - { + if (this->GenerateForTargetType(ptrIt->second->GetType()) == false) { continue; - } + } std::set<std::string> insertedConnections; std::set<std::string> insertedNodes; @@ -237,31 +208,27 @@ void cmGraphVizWriter::WritePerTargetFiles(const char* fileName) currentFilename += "."; currentFilename += ptrIt->first; cmGeneratedFileStream str(currentFilename.c_str()); - if ( !str ) - { + if (!str) { return; - } + } std::cout << "Writing " << currentFilename << "..." << std::endl; this->WriteHeader(str); - this->WriteConnections(ptrIt->first, - insertedNodes, insertedConnections, str); + this->WriteConnections(ptrIt->first, insertedNodes, insertedConnections, + str); this->WriteFooter(str); - } - + } } - void cmGraphVizWriter::WriteGlobalFile(const char* fileName) { this->CollectTargetsAndLibs(); cmGeneratedFileStream str(fileName); - if ( !str ) - { + if (!str) { return; - } + } this->WriteHeader(str); std::cout << "Writing " << fileName << "..." << std::endl; @@ -269,323 +236,268 @@ void cmGraphVizWriter::WriteGlobalFile(const char* fileName) std::set<std::string> insertedConnections; std::set<std::string> insertedNodes; - for(std::map<std::string, const cmGeneratorTarget*>::const_iterator ptrIt = - this->TargetPtrs.begin(); - ptrIt != this->TargetPtrs.end(); - ++ptrIt) - { - if (ptrIt->second == NULL) - { + for (std::map<std::string, const cmGeneratorTarget*>::const_iterator ptrIt = + this->TargetPtrs.begin(); + ptrIt != this->TargetPtrs.end(); ++ptrIt) { + if (ptrIt->second == NULL) { continue; - } + } - if (this->GenerateForTargetType(ptrIt->second->GetType()) == false) - { + if (this->GenerateForTargetType(ptrIt->second->GetType()) == false) { continue; - } - - this->WriteConnections(ptrIt->first, - insertedNodes, insertedConnections, str); } + + this->WriteConnections(ptrIt->first, insertedNodes, insertedConnections, + str); + } this->WriteFooter(str); } - void cmGraphVizWriter::WriteHeader(cmGeneratedFileStream& str) const { str << this->GraphType << " \"" << this->GraphName << "\" {" << std::endl; str << this->GraphHeader << std::endl; } - void cmGraphVizWriter::WriteFooter(cmGeneratedFileStream& str) const { str << "}" << std::endl; } - -void cmGraphVizWriter::WriteConnections(const std::string& targetName, - std::set<std::string>& insertedNodes, - std::set<std::string>& insertedConnections, - cmGeneratedFileStream& str) const +void cmGraphVizWriter::WriteConnections( + const std::string& targetName, std::set<std::string>& insertedNodes, + std::set<std::string>& insertedConnections, cmGeneratedFileStream& str) const { - std::map<std::string, const cmGeneratorTarget* >::const_iterator targetPtrIt - = this->TargetPtrs.find(targetName); + std::map<std::string, const cmGeneratorTarget*>::const_iterator targetPtrIt = + this->TargetPtrs.find(targetName); - if (targetPtrIt == this->TargetPtrs.end()) // not found at all - { + if (targetPtrIt == this->TargetPtrs.end()) // not found at all + { return; - } + } this->WriteNode(targetName, targetPtrIt->second, insertedNodes, str); if (targetPtrIt->second == NULL) // it's an external library - { + { return; - } - + } std::string myNodeName = this->TargetNamesNodes.find(targetName)->second; const cmTarget::LinkLibraryVectorType* ll = - &(targetPtrIt->second->Target->GetOriginalLinkLibraries()); + &(targetPtrIt->second->Target->GetOriginalLinkLibraries()); for (cmTarget::LinkLibraryVectorType::const_iterator llit = ll->begin(); - llit != ll->end(); - ++ llit ) - { + llit != ll->end(); ++llit) { const char* libName = llit->first.c_str(); std::map<std::string, std::string>::const_iterator libNameIt = - this->TargetNamesNodes.find(libName); + this->TargetNamesNodes.find(libName); // can happen e.g. if GRAPHVIZ_TARGET_IGNORE_REGEX is used - if(libNameIt == this->TargetNamesNodes.end()) - { + if (libNameIt == this->TargetNamesNodes.end()) { continue; - } + } std::string connectionName = myNodeName; connectionName += "-"; connectionName += libNameIt->second; - if (insertedConnections.find(connectionName) == insertedConnections.end()) - { + if (insertedConnections.find(connectionName) == + insertedConnections.end()) { insertedConnections.insert(connectionName); this->WriteNode(libName, this->TargetPtrs.find(libName)->second, insertedNodes, str); - str << " \"" << myNodeName << "\" -> \"" - << libNameIt->second << "\""; + str << " \"" << myNodeName << "\" -> \"" << libNameIt->second << "\""; str << " // " << targetName << " -> " << libName << std::endl; this->WriteConnections(libName, insertedNodes, insertedConnections, str); - } } - + } } - -void cmGraphVizWriter::WriteDependerConnections(const std::string& targetName, - std::set<std::string>& insertedNodes, - std::set<std::string>& insertedConnections, - cmGeneratedFileStream& str) const +void cmGraphVizWriter::WriteDependerConnections( + const std::string& targetName, std::set<std::string>& insertedNodes, + std::set<std::string>& insertedConnections, cmGeneratedFileStream& str) const { - std::map<std::string, const cmGeneratorTarget* >::const_iterator targetPtrIt - = this->TargetPtrs.find(targetName); + std::map<std::string, const cmGeneratorTarget*>::const_iterator targetPtrIt = + this->TargetPtrs.find(targetName); - if (targetPtrIt == this->TargetPtrs.end()) // not found at all - { + if (targetPtrIt == this->TargetPtrs.end()) // not found at all + { return; - } + } this->WriteNode(targetName, targetPtrIt->second, insertedNodes, str); if (targetPtrIt->second == NULL) // it's an external library - { + { return; - } - + } std::string myNodeName = this->TargetNamesNodes.find(targetName)->second; // now search who links against me - for(std::map<std::string, const cmGeneratorTarget*>::const_iterator - dependerIt = this->TargetPtrs.begin(); - dependerIt != this->TargetPtrs.end(); - ++dependerIt) - { - if (dependerIt->second == NULL) - { + for (std::map<std::string, const cmGeneratorTarget*>::const_iterator + dependerIt = this->TargetPtrs.begin(); + dependerIt != this->TargetPtrs.end(); ++dependerIt) { + if (dependerIt->second == NULL) { continue; - } + } - if (this->GenerateForTargetType(dependerIt->second->GetType()) == false) - { + if (this->GenerateForTargetType(dependerIt->second->GetType()) == false) { continue; - } + } // Now we have a target, check whether it links against targetName. // If so, draw a connection, and then continue with dependers on that one. const cmTarget::LinkLibraryVectorType* ll = - &(dependerIt->second->Target->GetOriginalLinkLibraries()); + &(dependerIt->second->Target->GetOriginalLinkLibraries()); for (cmTarget::LinkLibraryVectorType::const_iterator llit = ll->begin(); - llit != ll->end(); - ++ llit ) - { + llit != ll->end(); ++llit) { std::string libName = llit->first; - if (libName == targetName) - { + if (libName == targetName) { // So this target links against targetName. std::map<std::string, std::string>::const_iterator dependerNodeNameIt = - this->TargetNamesNodes.find(dependerIt->first); + this->TargetNamesNodes.find(dependerIt->first); - if(dependerNodeNameIt != this->TargetNamesNodes.end()) - { + if (dependerNodeNameIt != this->TargetNamesNodes.end()) { std::string connectionName = dependerNodeNameIt->second; connectionName += "-"; connectionName += myNodeName; if (insertedConnections.find(connectionName) == - insertedConnections.end()) - { + insertedConnections.end()) { insertedConnections.insert(connectionName); this->WriteNode(dependerIt->first, dependerIt->second, insertedNodes, str); str << " \"" << dependerNodeNameIt->second << "\" -> \"" << myNodeName << "\""; - str << " // " <<targetName<< " -> " <<dependerIt->first<<std::endl; - this->WriteDependerConnections(dependerIt->first, - insertedNodes, insertedConnections, str); - } - - + str << " // " << targetName << " -> " << dependerIt->first + << std::endl; + this->WriteDependerConnections(dependerIt->first, insertedNodes, + insertedConnections, str); } - break; } + break; } } - + } } - void cmGraphVizWriter::WriteNode(const std::string& targetName, const cmGeneratorTarget* target, std::set<std::string>& insertedNodes, cmGeneratedFileStream& str) const { - if (insertedNodes.find(targetName) == insertedNodes.end()) - { + if (insertedNodes.find(targetName) == insertedNodes.end()) { insertedNodes.insert(targetName); std::map<std::string, std::string>::const_iterator nameIt = - this->TargetNamesNodes.find(targetName); + this->TargetNamesNodes.find(targetName); - str << " \"" << nameIt->second << "\" [ label=\"" - << targetName << "\" shape=\"" << getShapeForTarget(target) - << "\"];" << std::endl; + str << " \"" << nameIt->second << "\" [ label=\"" << targetName + << "\" shape=\"" << getShapeForTarget(target) << "\"];" << std::endl; } } - void cmGraphVizWriter::CollectTargetsAndLibs() { - if (this->HaveTargetsAndLibs == false) - { + if (this->HaveTargetsAndLibs == false) { this->HaveTargetsAndLibs = true; int cnt = this->CollectAllTargets(); - if (this->GenerateForExternals) - { + if (this->GenerateForExternals) { this->CollectAllExternalLibs(cnt); - } } + } } - int cmGraphVizWriter::CollectAllTargets() { int cnt = 0; // First pass get the list of all cmake targets for (std::vector<cmLocalGenerator*>::const_iterator lit = - this->LocalGenerators.begin(); - lit != this->LocalGenerators.end(); - ++ lit ) - { + this->LocalGenerators.begin(); + lit != this->LocalGenerators.end(); ++lit) { std::vector<cmGeneratorTarget*> targets = (*lit)->GetGeneratorTargets(); - for ( std::vector<cmGeneratorTarget*>::const_iterator it = - targets.begin(); it != targets.end(); ++it ) - { + for (std::vector<cmGeneratorTarget*>::const_iterator it = targets.begin(); + it != targets.end(); ++it) { const char* realTargetName = (*it)->GetName().c_str(); - if(this->IgnoreThisTarget(realTargetName)) - { + if (this->IgnoreThisTarget(realTargetName)) { // Skip ignored targets continue; - } - //std::cout << "Found target: " << tit->first.c_str() << std::endl; + } + // std::cout << "Found target: " << tit->first.c_str() << std::endl; std::ostringstream ostr; ostr << this->GraphNodePrefix << cnt++; this->TargetNamesNodes[realTargetName] = ostr.str(); this->TargetPtrs[realTargetName] = *it; - } } + } return cnt; } - int cmGraphVizWriter::CollectAllExternalLibs(int cnt) { // Ok, now find all the stuff we link to that is not in cmake for (std::vector<cmLocalGenerator*>::const_iterator lit = - this->LocalGenerators.begin(); - lit != this->LocalGenerators.end(); - ++ lit ) - { + this->LocalGenerators.begin(); + lit != this->LocalGenerators.end(); ++lit) { std::vector<cmGeneratorTarget*> targets = (*lit)->GetGeneratorTargets(); - for ( std::vector<cmGeneratorTarget*>::const_iterator it = - targets.begin(); it != targets.end(); ++it ) - { + for (std::vector<cmGeneratorTarget*>::const_iterator it = targets.begin(); + it != targets.end(); ++it) { const char* realTargetName = (*it)->GetName().c_str(); - if (this->IgnoreThisTarget(realTargetName)) - { + if (this->IgnoreThisTarget(realTargetName)) { // Skip ignored targets continue; - } + } const cmTarget::LinkLibraryVectorType* ll = - &((*it)->Target->GetOriginalLinkLibraries()); + &((*it)->Target->GetOriginalLinkLibraries()); for (cmTarget::LinkLibraryVectorType::const_iterator llit = ll->begin(); - llit != ll->end(); - ++ llit ) - { + llit != ll->end(); ++llit) { const char* libName = llit->first.c_str(); - if (this->IgnoreThisTarget(libName)) - { + if (this->IgnoreThisTarget(libName)) { // Skip ignored targets continue; - } + } - std::map<std::string, const cmGeneratorTarget*>::const_iterator tarIt - = this->TargetPtrs.find(libName); - if ( tarIt == this->TargetPtrs.end() ) - { + std::map<std::string, const cmGeneratorTarget*>::const_iterator tarIt = + this->TargetPtrs.find(libName); + if (tarIt == this->TargetPtrs.end()) { std::ostringstream ostr; ostr << this->GraphNodePrefix << cnt++; this->TargetNamesNodes[libName] = ostr.str(); this->TargetPtrs[libName] = NULL; // str << " \"" << ostr.c_str() << "\" [ label=\"" << libName // << "\" shape=\"ellipse\"];" << std::endl; - } } } } - return cnt; + } + return cnt; } - bool cmGraphVizWriter::IgnoreThisTarget(const std::string& name) { - for(std::vector<cmsys::RegularExpression>::iterator itvIt - = this->TargetsToIgnoreRegex.begin(); - itvIt != this->TargetsToIgnoreRegex.end(); - ++ itvIt ) - { + for (std::vector<cmsys::RegularExpression>::iterator itvIt = + this->TargetsToIgnoreRegex.begin(); + itvIt != this->TargetsToIgnoreRegex.end(); ++itvIt) { cmsys::RegularExpression& regEx = *itvIt; - if (regEx.is_valid()) - { - if (regEx.find(name)) - { + if (regEx.is_valid()) { + if (regEx.find(name)) { return true; - } } } + } return false; } - -bool cmGraphVizWriter::GenerateForTargetType(cmState::TargetType targetType) - const +bool cmGraphVizWriter::GenerateForTargetType( + cmState::TargetType targetType) const { - switch (targetType) - { + switch (targetType) { case cmState::EXECUTABLE: return this->GenerateForExecutables; case cmState::STATIC_LIBRARY: |