diff options
| author | Sebastian Holtermann <sebholt@xwmw.org> | 2019-01-25 14:03:31 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2019-01-28 13:41:28 (GMT) |
| commit | f16dfdf71f8f81e1be9c3ea18652d8d87c1cb265 (patch) | |
| tree | 7a8a17ef3ef7fd6b7adee89ae687d5f7412b0604 /Source/cmJsonObjects.cxx | |
| parent | 8e495333c0914a0684d6d82e2cc15327c9f811f3 (diff) | |
| download | CMake-f16dfdf71f8f81e1be9c3ea18652d8d87c1cb265.zip CMake-f16dfdf71f8f81e1be9c3ea18652d8d87c1cb265.tar.gz CMake-f16dfdf71f8f81e1be9c3ea18652d8d87c1cb265.tar.bz2 | |
cmLocalGenerator: Simplify `GetIncludeDirectories`
This patch strips the `stripImplicitDirs` and `appendAllImplicitDirs`
parameters from the `cmLocalGenerator::GetIncludeDirectories` method and makes
it a wrapper into the new `cmLocalGenerator::GetIncludeDirectoriesImplicit`
method. `cmLocalGenerator::GetIncludeDirectoriesImplicit` is the renamed old
implementation of `cmLocalGenerator::GetIncludeDirectories` and still
accepts `stripImplicitDirs` and `appendAllImplicitDirs`.
The motivation is that there's only *one* case where
`cmLocalGenerator::GetIncludeDirectories` is called with the
`stripImplicitDirs` parameter being `false` (QtAutoGen), but many other places
where it is called using the `true` default value.
QtAutoGen is modified to use `cmLocalGenerator::GetIncludeDirectoriesImplicit`
directly. In two use cases of `cmLocalGenerator::GetIncludeDirectories`
the manually set `true` value for `stripImplicitDirs` is removed.
Diffstat (limited to 'Source/cmJsonObjects.cxx')
| -rw-r--r-- | Source/cmJsonObjects.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/cmJsonObjects.cxx b/Source/cmJsonObjects.cxx index 135fd25..4b6b4d5 100644 --- a/Source/cmJsonObjects.cxx +++ b/Source/cmJsonObjects.cxx @@ -578,7 +578,7 @@ static Json::Value DumpTarget(cmGeneratorTarget* target, lg->GetTargetDefines(target, config, lang, defines); ld.SetDefines(defines); std::vector<std::string> includePathList; - lg->GetIncludeDirectories(includePathList, target, lang, config, true); + lg->GetIncludeDirectories(includePathList, target, lang, config); for (std::string const& i : includePathList) { ld.IncludePathList.emplace_back( i, target->IsSystemIncludeDirectory(i, config, lang)); |