diff options
| author | Brad King <brad.king@kitware.com> | 2013-07-15 16:47:27 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2013-07-15 17:17:29 (GMT) |
| commit | 4bb6e24809df6b6443895a5a5c12cb264f5f1489 (patch) | |
| tree | 7703f7db6532c02606515e49888cb4c863d6b249 /Source/cmLocalGenerator.h | |
| parent | b5dd80105f79c5296f222368b85d3d211a509b1f (diff) | |
| download | CMake-4bb6e24809df6b6443895a5a5c12cb264f5f1489.zip CMake-4bb6e24809df6b6443895a5a5c12cb264f5f1489.tar.gz CMake-4bb6e24809df6b6443895a5a5c12cb264f5f1489.tar.bz2 | |
VS,Xcode: Drop incorrect legacy dependency trace (#14291)
Drop the "vsProjectFile" argument from cmTarget::TraceDependencies. It
appears to be the modern equivalent to a hunk added in commit ba68f771
(...added new custom command support, 2003-06-03):
+ name = libName;
+ name += ".dsp.cmake";
+ srcFilesToProcess.push(name);
but was broken by refactoring at some point. The current behavior tries
to trace dependencies on a source file named the same as a target, which
makes no sense. Furthermore, in code of the form
add_executable(foo foo.c)
add_custom_command(OUTPUT "${somewhere}/foo" ... DEPENDS foo)
the "vsProjectFile" value "foo" matches source "${somewhere}/foo.rule"
generated to hold the custom command and causes the command to be added
to the "foo" target incorrectly.
Simply drop the incorrect source file trace and supporting logic.
Diffstat (limited to 'Source/cmLocalGenerator.h')
| -rw-r--r-- | Source/cmLocalGenerator.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/Source/cmLocalGenerator.h b/Source/cmLocalGenerator.h index f35ef8e..0bd1853 100644 --- a/Source/cmLocalGenerator.h +++ b/Source/cmLocalGenerator.h @@ -435,8 +435,6 @@ protected: bool IgnoreLibPrefix; bool Configured; bool EmitUniversalBinaryFlags; - // A type flag is not nice. It's used only in TraceDependencies(). - bool IsMakefileGenerator; // Hack for ExpandRuleVariable until object-oriented version is // committed. std::string TargetImplib; |