diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 20:21:15 (GMT) |
|---|---|---|
| committer | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 20:21:15 (GMT) |
| commit | 27ead963052b4c3f4e40ea9e6141ba9902ad310a (patch) | |
| tree | 69996681031307b34c930d51e0b3406fedf74236 /Source/cmLocalUnixMakefileGenerator3.cxx | |
| parent | 618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (diff) | |
| download | CMake-27ead963052b4c3f4e40ea9e6141ba9902ad310a.zip CMake-27ead963052b4c3f4e40ea9e6141ba9902ad310a.tar.gz CMake-27ead963052b4c3f4e40ea9e6141ba9902ad310a.tar.bz2 | |
Remove unnecessary local copies.
Use clang-tidy's performance-unnecessary-copy-initialization checker.
After applying the fix-its (which turns the copies into const&), revise
the changes and see whether the copies can be removed entirely by using
the original instead.
Diffstat (limited to 'Source/cmLocalUnixMakefileGenerator3.cxx')
| -rw-r--r-- | Source/cmLocalUnixMakefileGenerator3.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Source/cmLocalUnixMakefileGenerator3.cxx b/Source/cmLocalUnixMakefileGenerator3.cxx index 653ea40..f60a595 100644 --- a/Source/cmLocalUnixMakefileGenerator3.cxx +++ b/Source/cmLocalUnixMakefileGenerator3.cxx @@ -1178,10 +1178,9 @@ void cmLocalUnixMakefileGenerator3::AppendEcho( } std::string cmLocalUnixMakefileGenerator3::CreateMakeVariable( - const std::string& sin, const std::string& s2in) + const std::string& sin, const std::string& s2) { std::string s = sin; - std::string s2 = s2in; std::string unmodified = s; unmodified += s2; // if there is no restriction on the length of make variables |