diff options
author | Kitware Robot <kwrobot@kitware.com> | 2016-05-16 14:34:04 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2016-05-16 20:05:19 (GMT) |
commit | d9fd2f5402eeaa345691313658e02b51038f570b (patch) | |
tree | dca71b9a7e267f4c6300da3eb770415381726785 /Source/cmMakefileTargetGenerator.cxx | |
parent | 82df6deaafb36cbbfd450202bb20b320f637751a (diff) | |
download | CMake-d9fd2f5402eeaa345691313658e02b51038f570b.zip CMake-d9fd2f5402eeaa345691313658e02b51038f570b.tar.gz CMake-d9fd2f5402eeaa345691313658e02b51038f570b.tar.bz2 |
Revise C++ coding style using clang-format
Run the `Utilities/Scripts/clang-format.bash` script to update
all our C++ code to a new style defined by `.clang-format`.
Use `clang-format` version 3.8.
* If you reached this commit for a line in `git blame`, re-run the blame
operation starting at the parent of this commit to see older history
for the content.
* See the parent commit for instructions to rebase a change across this
style transition commit.
Diffstat (limited to 'Source/cmMakefileTargetGenerator.cxx')
-rw-r--r-- | Source/cmMakefileTargetGenerator.cxx | 1304 |
1 files changed, 544 insertions, 760 deletions
diff --git a/Source/cmMakefileTargetGenerator.cxx b/Source/cmMakefileTargetGenerator.cxx index bd06298..e480140 100644 --- a/Source/cmMakefileTargetGenerator.cxx +++ b/Source/cmMakefileTargetGenerator.cxx @@ -42,16 +42,14 @@ cmMakefileTargetGenerator::cmMakefileTargetGenerator(cmGeneratorTarget* target) this->CustomCommandDriver = OnBuild; this->LocalGenerator = static_cast<cmLocalUnixMakefileGenerator3*>(target->GetLocalGenerator()); - this->GlobalGenerator = - static_cast<cmGlobalUnixMakefileGenerator3*>( - this->LocalGenerator->GetGlobalGenerator()); + this->GlobalGenerator = static_cast<cmGlobalUnixMakefileGenerator3*>( + this->LocalGenerator->GetGlobalGenerator()); cmake* cm = this->GlobalGenerator->GetCMakeInstance(); this->NoRuleMessages = false; - if(const char* ruleStatus = cm->GetState() - ->GetGlobalProperty("RULE_MESSAGES")) - { + if (const char* ruleStatus = + cm->GetState()->GetGlobalProperty("RULE_MESSAGES")) { this->NoRuleMessages = cmSystemTools::IsOff(ruleStatus); - } + } MacOSXContentGenerator = new MacOSXContentGeneratorType(this); } @@ -60,13 +58,12 @@ cmMakefileTargetGenerator::~cmMakefileTargetGenerator() delete MacOSXContentGenerator; } -cmMakefileTargetGenerator * -cmMakefileTargetGenerator::New(cmGeneratorTarget *tgt) +cmMakefileTargetGenerator* cmMakefileTargetGenerator::New( + cmGeneratorTarget* tgt) { - cmMakefileTargetGenerator *result = 0; + cmMakefileTargetGenerator* result = 0; - switch (tgt->GetType()) - { + switch (tgt->GetType()) { case cmState::EXECUTABLE: result = new cmMakefileExecutableTargetGenerator(tgt); break; @@ -82,7 +79,7 @@ cmMakefileTargetGenerator::New(cmGeneratorTarget *tgt) default: return result; // break; /* unreachable */ - } + } return result; } @@ -113,19 +110,17 @@ void cmMakefileTargetGenerator::CreateRuleFile() this->BuildFileStream = new cmGeneratedFileStream(this->BuildFileNameFull.c_str()); this->BuildFileStream->SetCopyIfDifferent(true); - if(!this->BuildFileStream) - { + if (!this->BuildFileStream) { return; - } + } this->LocalGenerator->WriteDisclaimer(*this->BuildFileStream); - if (this->GlobalGenerator->AllowDeleteOnError()) - { + if (this->GlobalGenerator->AllowDeleteOnError()) { std::vector<std::string> no_depends; std::vector<std::string> no_commands; this->LocalGenerator->WriteMakeRule( *this->BuildFileStream, "Delete rule output on recipe failure.", ".DELETE_ON_ERROR", no_depends, no_commands, false); - } + } this->LocalGenerator->WriteSpecialTargetsTop(*this->BuildFileStream); } @@ -136,84 +131,71 @@ void cmMakefileTargetGenerator::WriteTargetBuildRules() // write the custom commands for this target // Look for files registered for cleaning in this directory. - if(const char* additional_clean_files = - this->Makefile->GetProperty - ("ADDITIONAL_MAKE_CLEAN_FILES")) - { + if (const char* additional_clean_files = + this->Makefile->GetProperty("ADDITIONAL_MAKE_CLEAN_FILES")) { cmGeneratorExpression ge; cmsys::auto_ptr<cmCompiledGeneratorExpression> cge = - ge.Parse(additional_clean_files); - - cmSystemTools::ExpandListArgument(cge->Evaluate(this->LocalGenerator, - config, - false, - this->GeneratorTarget, - 0, 0), - this->CleanFiles); - } + ge.Parse(additional_clean_files); + + cmSystemTools::ExpandListArgument( + cge->Evaluate(this->LocalGenerator, config, false, this->GeneratorTarget, + 0, 0), + this->CleanFiles); + } // add custom commands to the clean rules? - const char* clean_no_custom = - this->Makefile->GetProperty("CLEAN_NO_CUSTOM"); + const char* clean_no_custom = this->Makefile->GetProperty("CLEAN_NO_CUSTOM"); bool clean = cmSystemTools::IsOff(clean_no_custom); // First generate the object rule files. Save a list of all object // files for this target. std::vector<cmSourceFile const*> customCommands; this->GeneratorTarget->GetCustomCommands(customCommands, config); - for(std::vector<cmSourceFile const*>::const_iterator - si = customCommands.begin(); - si != customCommands.end(); ++si) - { - cmCustomCommandGenerator ccg(*(*si)->GetCustomCommand(), - this->ConfigName, + for (std::vector<cmSourceFile const*>::const_iterator si = + customCommands.begin(); + si != customCommands.end(); ++si) { + cmCustomCommandGenerator ccg(*(*si)->GetCustomCommand(), this->ConfigName, this->LocalGenerator); this->GenerateCustomRuleFile(ccg); - if (clean) - { + if (clean) { const std::vector<std::string>& outputs = ccg.GetOutputs(); - for(std::vector<std::string>::const_iterator o = outputs.begin(); - o != outputs.end(); ++o) - { - this->CleanFiles.push_back - (this->Convert(*o, - cmLocalGenerator::START_OUTPUT, - cmLocalGenerator::UNCHANGED)); - } + for (std::vector<std::string>::const_iterator o = outputs.begin(); + o != outputs.end(); ++o) { + this->CleanFiles.push_back(this->Convert( + *o, cmLocalGenerator::START_OUTPUT, cmLocalGenerator::UNCHANGED)); } } + } std::vector<cmSourceFile const*> headerSources; this->GeneratorTarget->GetHeaderSources(headerSources, config); this->OSXBundleGenerator->GenerateMacOSXContentStatements( - headerSources, - this->MacOSXContentGenerator); + headerSources, this->MacOSXContentGenerator); std::vector<cmSourceFile const*> extraSources; this->GeneratorTarget->GetExtraSources(extraSources, config); this->OSXBundleGenerator->GenerateMacOSXContentStatements( - extraSources, - this->MacOSXContentGenerator); + extraSources, this->MacOSXContentGenerator); std::vector<cmSourceFile const*> externalObjects; this->GeneratorTarget->GetExternalObjects(externalObjects, config); - for(std::vector<cmSourceFile const*>::const_iterator - si = externalObjects.begin(); - si != externalObjects.end(); ++si) - { + for (std::vector<cmSourceFile const*>::const_iterator si = + externalObjects.begin(); + si != externalObjects.end(); ++si) { this->ExternalObjects.push_back((*si)->GetFullPath()); - } + } std::vector<cmSourceFile const*> objectSources; this->GeneratorTarget->GetObjectSources(objectSources, config); - for(std::vector<cmSourceFile const*>::const_iterator - si = objectSources.begin(); si != objectSources.end(); ++si) - { + for (std::vector<cmSourceFile const*>::const_iterator si = + objectSources.begin(); + si != objectSources.end(); ++si) { // Generate this object file's rule file. this->WriteObjectRuleFiles(**si); - } + } } void cmMakefileTargetGenerator::WriteCommonCodeRules() { - const char* root = (this->Makefile->IsOn("CMAKE_MAKE_INCLUDE_FROM_ROOT")? - "$(CMAKE_BINARY_DIR)/" : ""); + const char* root = (this->Makefile->IsOn("CMAKE_MAKE_INCLUDE_FROM_ROOT") + ? "$(CMAKE_BINARY_DIR)/" + : ""); // Include the dependencies for the target. std::string dependFileNameFull = this->TargetBuildDirectoryFull; @@ -221,13 +203,11 @@ void cmMakefileTargetGenerator::WriteCommonCodeRules() *this->BuildFileStream << "# Include any dependencies generated for this target.\n" << this->GlobalGenerator->IncludeDirective << " " << root - << this->Convert(dependFileNameFull, - cmLocalGenerator::HOME_OUTPUT, + << this->Convert(dependFileNameFull, cmLocalGenerator::HOME_OUTPUT, cmLocalGenerator::MAKERULE) << "\n\n"; - if(!this->NoRuleMessages) - { + if (!this->NoRuleMessages) { // Include the progress variables for the target. *this->BuildFileStream << "# Include the progress variables for this target.\n" @@ -236,18 +216,17 @@ void cmMakefileTargetGenerator::WriteCommonCodeRules() cmLocalGenerator::HOME_OUTPUT, cmLocalGenerator::MAKERULE) << "\n\n"; - } + } // make sure the depend file exists - if (!cmSystemTools::FileExists(dependFileNameFull.c_str())) - { + if (!cmSystemTools::FileExists(dependFileNameFull.c_str())) { // Write an empty dependency file. cmGeneratedFileStream depFileStream(dependFileNameFull.c_str()); - depFileStream - << "# Empty dependencies file for " - << this->GeneratorTarget->GetName() << ".\n" - << "# This may be replaced when dependencies are built." << std::endl; - } + depFileStream << "# Empty dependencies file for " + << this->GeneratorTarget->GetName() << ".\n" + << "# This may be replaced when dependencies are built." + << std::endl; + } // Open the flags file. This should be copy-if-different because the // rules may depend on this file itself. @@ -256,19 +235,17 @@ void cmMakefileTargetGenerator::WriteCommonCodeRules() this->FlagFileStream = new cmGeneratedFileStream(this->FlagFileNameFull.c_str()); this->FlagFileStream->SetCopyIfDifferent(true); - if(!this->FlagFileStream) - { + if (!this->FlagFileStream) { return; - } + } this->LocalGenerator->WriteDisclaimer(*this->FlagFileStream); // Include the flags for the target. *this->BuildFileStream << "# Include the compile flags for this target's objects.\n" << this->GlobalGenerator->IncludeDirective << " " << root - << this->Convert(this->FlagFileNameFull, - cmLocalGenerator::HOME_OUTPUT, - cmLocalGenerator::MAKERULE) + << this->Convert(this->FlagFileNameFull, cmLocalGenerator::HOME_OUTPUT, + cmLocalGenerator::MAKERULE) << "\n\n"; } @@ -276,23 +253,22 @@ void cmMakefileTargetGenerator::WriteTargetLanguageFlags() { // write language flags for target std::set<std::string> languages; - this->GeneratorTarget->GetLanguages(languages, - this->Makefile->GetSafeDefinition("CMAKE_BUILD_TYPE")); + this->GeneratorTarget->GetLanguages( + languages, this->Makefile->GetSafeDefinition("CMAKE_BUILD_TYPE")); // put the compiler in the rules.make file so that if it changes // things rebuild - for(std::set<std::string>::const_iterator l = languages.begin(); - l != languages.end(); ++l) - { + for (std::set<std::string>::const_iterator l = languages.begin(); + l != languages.end(); ++l) { std::string compiler = "CMAKE_"; compiler += *l; compiler += "_COMPILER"; - *this->FlagFileStream << "# compile " << *l << " with " << - this->Makefile->GetSafeDefinition(compiler) << "\n"; - } + *this->FlagFileStream << "# compile " << *l << " with " + << this->Makefile->GetSafeDefinition(compiler) + << "\n"; + } - for(std::set<std::string>::const_iterator l = languages.begin(); - l != languages.end(); ++l) - { + for (std::set<std::string>::const_iterator l = languages.begin(); + l != languages.end(); ++l) { std::string flags = this->GetFlags(*l); std::string defines = this->GetDefines(*l); std::string includes = this->GetIncludes(*l); @@ -303,19 +279,16 @@ void cmMakefileTargetGenerator::WriteTargetLanguageFlags() *this->FlagFileStream << *l << "_FLAGS = " << flags << "\n\n"; *this->FlagFileStream << *l << "_DEFINES = " << defines << "\n\n"; *this->FlagFileStream << *l << "_INCLUDES = " << includes << "\n\n"; - } + } } - -void -cmMakefileTargetGenerator::MacOSXContentGeneratorType::operator() - (cmSourceFile const& source, const char* pkgloc) +void cmMakefileTargetGenerator::MacOSXContentGeneratorType::operator()( + cmSourceFile const& source, const char* pkgloc) { // Skip OS X content when not building a Framework or Bundle. - if(!this->Generator->GetGeneratorTarget()->IsBundleOnApple()) - { + if (!this->Generator->GetGeneratorTarget()->IsBundleOnApple()) { return; - } + } std::string macdir = this->Generator->OSXBundleGenerator->InitMacOSXContentDirectory(pkgloc); @@ -328,10 +301,8 @@ cmMakefileTargetGenerator::MacOSXContentGeneratorType::operator() output += "/"; output += cmSystemTools::GetFilenameName(input); this->Generator->CleanFiles.push_back( - this->Generator->Convert(output, - cmLocalGenerator::START_OUTPUT)); - output = this->Generator->Convert(output, - cmLocalGenerator::HOME_OUTPUT); + this->Generator->Convert(output, cmLocalGenerator::START_OUTPUT)); + output = this->Generator->Convert(output, cmLocalGenerator::HOME_OUTPUT); // Create a rule to copy the content into the bundle. std::vector<std::string> depends; @@ -340,75 +311,64 @@ cmMakefileTargetGenerator::MacOSXContentGeneratorType::operator() std::string copyEcho = "Copying OS X content "; copyEcho += output; this->Generator->LocalGenerator->AppendEcho( - commands, copyEcho.c_str(), - cmLocalUnixMakefileGenerator3::EchoBuild); + commands, copyEcho.c_str(), cmLocalUnixMakefileGenerator3::EchoBuild); std::string copyCommand = "$(CMAKE_COMMAND) -E copy "; - copyCommand += this->Generator->Convert(input, - cmLocalGenerator::NONE, + copyCommand += this->Generator->Convert(input, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); copyCommand += " "; - copyCommand += this->Generator->Convert(output, - cmLocalGenerator::NONE, + copyCommand += this->Generator->Convert(output, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); commands.push_back(copyCommand); this->Generator->LocalGenerator->WriteMakeRule( - *this->Generator->BuildFileStream, 0, - output, - depends, commands, false); + *this->Generator->BuildFileStream, 0, output, depends, commands, false); this->Generator->ExtraFiles.insert(output); } -void cmMakefileTargetGenerator -::WriteObjectRuleFiles(cmSourceFile const& source) +void cmMakefileTargetGenerator::WriteObjectRuleFiles( + cmSourceFile const& source) { // Identify the language of the source file. const std::string& lang = this->LocalGenerator->GetSourceFileLanguage(source); - if(lang.empty()) - { + if (lang.empty()) { // don't know anything about this file so skip it return; - } + } // Get the full path name of the object file. - std::string const& objectName = this->GeneratorTarget - ->GetObjectName(&source); + std::string const& objectName = + this->GeneratorTarget->GetObjectName(&source); std::string obj = - this->LocalGenerator->GetTargetDirectory(this->GeneratorTarget); + this->LocalGenerator->GetTargetDirectory(this->GeneratorTarget); obj += "/"; obj += objectName; // Avoid generating duplicate rules. - if(this->ObjectFiles.find(obj) == this->ObjectFiles.end()) - { + if (this->ObjectFiles.find(obj) == this->ObjectFiles.end()) { this->ObjectFiles.insert(obj); - } - else - { + } else { std::ostringstream err; - err << "Warning: Source file \"" - << source.GetFullPath() + err << "Warning: Source file \"" << source.GetFullPath() << "\" is listed multiple times for target \"" - << this->GeneratorTarget->GetName() - << "\"."; + << this->GeneratorTarget->GetName() << "\"."; cmSystemTools::Message(err.str().c_str(), "Warning"); return; - } + } // Create the directory containing the object file. This may be a // subdirectory under the target's directory. std::string dir = cmSystemTools::GetFilenamePath(obj); - cmSystemTools::MakeDirectory - (this->LocalGenerator->ConvertToFullPath(dir).c_str()); + cmSystemTools::MakeDirectory( + this->LocalGenerator->ConvertToFullPath(dir).c_str()); // Save this in the target's list of object files. this->Objects.push_back(obj); this->CleanFiles.push_back(obj); // TODO: Remove - //std::string relativeObj + // std::string relativeObj //= this->LocalGenerator->GetHomeRelativeOutputPath(); - //relativeObj += obj; + // relativeObj += obj; // we compute some depends when writing the depend.make that we will also // use in the build.make, same with depMakeFile @@ -421,22 +381,16 @@ void cmMakefileTargetGenerator std::string objFullPath = this->LocalGenerator->GetCurrentBinaryDirectory(); objFullPath += "/"; objFullPath += obj; - objFullPath = - this->Convert(objFullPath, cmLocalGenerator::FULL); + objFullPath = this->Convert(objFullPath, cmLocalGenerator::FULL); std::string srcFullPath = this->Convert(source.GetFullPath(), cmLocalGenerator::FULL); - this->LocalGenerator-> - AddImplicitDepends(this->GeneratorTarget, lang, - objFullPath.c_str(), - srcFullPath.c_str()); + this->LocalGenerator->AddImplicitDepends( + this->GeneratorTarget, lang, objFullPath.c_str(), srcFullPath.c_str()); } -void -cmMakefileTargetGenerator -::WriteObjectBuildFile(std::string &obj, - const std::string& lang, - cmSourceFile const& source, - std::vector<std::string>& depends) +void cmMakefileTargetGenerator::WriteObjectBuildFile( + std::string& obj, const std::string& lang, cmSourceFile const& source, + std::vector<std::string>& depends) { this->LocalGenerator->AppendRuleDepend(depends, this->FlagFileNameFull.c_str()); @@ -463,52 +417,43 @@ cmMakefileTargetGenerator cmSystemTools::UpperCase(this->LocalGenerator->GetConfigName()); // Add Fortran format flags. - if(lang == "Fortran") - { + if (lang == "Fortran") { this->AppendFortranFormatFlags(flags, source); - } + } // Add flags from source file properties. - if (source.GetProperty("COMPILE_FLAGS")) - { - this->LocalGenerator->AppendFlags - (flags, source.GetProperty("COMPILE_FLAGS")); - *this->FlagFileStream << "# Custom flags: " - << relativeObj << "_FLAGS = " - << source.GetProperty("COMPILE_FLAGS") + if (source.GetProperty("COMPILE_FLAGS")) { + this->LocalGenerator->AppendFlags(flags, + source.GetProperty("COMPILE_FLAGS")); + *this->FlagFileStream << "# Custom flags: " << relativeObj + << "_FLAGS = " << source.GetProperty("COMPILE_FLAGS") << "\n" << "\n"; - } + } // Add language-specific defines. std::set<std::string> defines; // Add source-sepcific preprocessor definitions. - if(const char* compile_defs = source.GetProperty("COMPILE_DEFINITIONS")) - { + if (const char* compile_defs = source.GetProperty("COMPILE_DEFINITIONS")) { this->LocalGenerator->AppendDefines(defines, compile_defs); - *this->FlagFileStream << "# Custom defines: " - << relativeObj << "_DEFINES = " - << compile_defs << "\n" + *this->FlagFileStream << "# Custom defines: " << relativeObj + << "_DEFINES = " << compile_defs << "\n" << "\n"; - } + } std::string defPropName = "COMPILE_DEFINITIONS_"; defPropName += configUpper; - if(const char* config_compile_defs = - source.GetProperty(defPropName)) - { + if (const char* config_compile_defs = source.GetProperty(defPropName)) { this->LocalGenerator->AppendDefines(defines, config_compile_defs); - *this->FlagFileStream - << "# Custom defines: " - << relativeObj << "_DEFINES_" << configUpper - << " = " << config_compile_defs << "\n" - << "\n"; - } + *this->FlagFileStream << "# Custom defines: " << relativeObj << "_DEFINES_" + << configUpper << " = " << config_compile_defs + << "\n" + << "\n"; + } // Get the output paths for source and object files. - std::string sourceFile = this->Convert(source.GetFullPath(), - cmLocalGenerator::NONE, - cmLocalGenerator::SHELL); + std::string sourceFile = this->Convert( + source.GetFullPath(), cmLocalGenerator::NONE, cmLocalGenerator::SHELL); // Construct the build message. std::vector<std::string> no_commands; @@ -517,67 +462,60 @@ cmMakefileTargetGenerator // add in a progress call if needed this->NumberOfProgressActions++; - if(!this->NoRuleMessages) - { + if (!this->NoRuleMessages) { cmLocalUnixMakefileGenerator3::EchoProgress progress; this->MakeEchoProgress(progress); std::string buildEcho = "Building "; buildEcho += lang; buildEcho += " object "; buildEcho += relativeObj; - this->LocalGenerator->AppendEcho - (commands, buildEcho.c_str(), cmLocalUnixMakefileGenerator3::EchoBuild, - &progress); - } + this->LocalGenerator->AppendEcho(commands, buildEcho.c_str(), + cmLocalUnixMakefileGenerator3::EchoBuild, + &progress); + } std::string targetOutPathReal; std::string targetOutPathPDB; std::string targetOutPathCompilePDB; { - std::string targetFullPathReal; - std::string targetFullPathPDB; - std::string targetFullPathCompilePDB; - if(this->GeneratorTarget->GetType() == cmState::EXECUTABLE || - this->GeneratorTarget->GetType() == cmState::STATIC_LIBRARY || - this->GeneratorTarget->GetType() == cmState::SHARED_LIBRARY || - this->GeneratorTarget->GetType() == cmState::MODULE_LIBRARY) - { - targetFullPathReal = - this->GeneratorTarget->GetFullPath(this->ConfigName, false, true); - targetFullPathPDB = + std::string targetFullPathReal; + std::string targetFullPathPDB; + std::string targetFullPathCompilePDB; + if (this->GeneratorTarget->GetType() == cmState::EXECUTABLE || + this->GeneratorTarget->GetType() == cmState::STATIC_LIBRARY || + this->GeneratorTarget->GetType() == cmState::SHARED_LIBRARY || + this->GeneratorTarget->GetType() == cmState::MODULE_LIBRARY) { + targetFullPathReal = + this->GeneratorTarget->GetFullPath(this->ConfigName, false, true); + targetFullPathPDB = this->GeneratorTarget->GetPDBDirectory(this->ConfigName); - targetFullPathPDB += "/"; - targetFullPathPDB += this->GeneratorTarget->GetPDBName(this->ConfigName); + targetFullPathPDB += "/"; + targetFullPathPDB += this->GeneratorTarget->GetPDBName(this->ConfigName); } - if(this->GeneratorTarget->GetType() <= cmState::OBJECT_LIBRARY) - { - targetFullPathCompilePDB = - this->GeneratorTarget->GetCompilePDBPath(this->ConfigName); - if(targetFullPathCompilePDB.empty()) - { + if (this->GeneratorTarget->GetType() <= cmState::OBJECT_LIBRARY) { targetFullPathCompilePDB = + this->GeneratorTarget->GetCompilePDBPath(this->ConfigName); + if (targetFullPathCompilePDB.empty()) { + targetFullPathCompilePDB = this->GeneratorTarget->GetSupportDirectory() + "/"; } } - targetOutPathReal = this->Convert(targetFullPathReal, - cmLocalGenerator::START_OUTPUT, - cmLocalGenerator::SHELL); - targetOutPathPDB = - this->Convert(targetFullPathPDB,cmLocalGenerator::NONE, - cmLocalGenerator::SHELL); - targetOutPathCompilePDB = - this->Convert(targetFullPathCompilePDB, - cmLocalGenerator::START_OUTPUT, - cmLocalGenerator::SHELL); - - if (this->LocalGenerator->IsMinGWMake() && - cmHasLiteralSuffix(targetOutPathCompilePDB, "\\")) - { - // mingw32-make incorrectly interprets 'a\ b c' as 'a b' and 'c' - // (but 'a\ b "c"' as 'a\', 'b', and 'c'!). Workaround this by - // avoiding a trailing backslash in the argument. - targetOutPathCompilePDB[targetOutPathCompilePDB.size()-1] = '/'; + targetOutPathReal = + this->Convert(targetFullPathReal, cmLocalGenerator::START_OUTPUT, + cmLocalGenerator::SHELL); + targetOutPathPDB = this->Convert(targetFullPathPDB, cmLocalGenerator::NONE, + cmLocalGenerator::SHELL); + targetOutPathCompilePDB = + this->Convert(targetFullPathCompilePDB, cmLocalGenerator::START_OUTPUT, + cmLocalGenerator::SHELL); + + if (this->LocalGenerator->IsMinGWMake() && + cmHasLiteralSuffix(targetOutPathCompilePDB, "\\")) { + // mingw32-make incorrectly interprets 'a\ b c' as 'a b' and 'c' + // (but 'a\ b "c"' as 'a\', 'b', and 'c'!). Workaround this by + // avoiding a trailing backslash in the argument. + targetOutPathCompilePDB[targetOutPathCompilePDB.size() - 1] = '/'; } } cmLocalGenerator::RuleVariables vars; @@ -589,18 +527,14 @@ cmMakefileTargetGenerator vars.TargetCompilePDB = targetOutPathCompilePDB.c_str(); vars.Source = sourceFile.c_str(); std::string shellObj = - this->Convert(obj, - cmLocalGenerator::NONE, - cmLocalGenerator::SHELL); + this->Convert(obj, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); vars.Object = shellObj.c_str(); std::string objectDir = this->GeneratorTarget->GetSupportDirectory(); - objectDir = this->Convert(objectDir, - cmLocalGenerator::START_OUTPUT, + objectDir = this->Convert(objectDir, cmLocalGenerator::START_OUTPUT, cmLocalGenerator::SHELL); vars.ObjectDir = objectDir.c_str(); std::string objectFileDir = cmSystemTools::GetFilenamePath(obj); - objectFileDir = this->Convert(objectFileDir, - cmLocalGenerator::START_OUTPUT, + objectFileDir = this->Convert(objectFileDir, cmLocalGenerator::START_OUTPUT, cmLocalGenerator::SHELL); vars.ObjectFileDir = objectFileDir.c_str(); vars.Flags = flags.c_str(); @@ -619,126 +553,112 @@ cmMakefileTargetGenerator // At the moment, it is assumed that C, C++, and Fortran have both // assembly and preprocessor capabilities. The same is true for the // ability to export compile commands - bool lang_has_preprocessor = ((lang == "C") || - (lang == "CXX") || - (lang == "Fortran")); + bool lang_has_preprocessor = + ((lang == "C") || (lang == "CXX") || (lang == "Fortran")); bool const lang_has_assembly = lang_has_preprocessor; bool const lang_can_export_cmds = lang_has_preprocessor; // Construct the compile rules. { - std::string compileRuleVar = "CMAKE_"; - compileRuleVar += lang; - compileRuleVar += "_COMPILE_OBJECT"; - std::string compileRule = - this->Makefile->GetRequiredDefinition(compileRuleVar); - std::vector<std::string> compileCommands; - cmSystemTools::ExpandListArgument(compileRule, compileCommands); - - if (this->Makefile->IsOn("CMAKE_EXPORT_COMPILE_COMMANDS") && - lang_can_export_cmds && compileCommands.size() == 1) - { - std::string compileCommand = compileCommands[0]; - this->LocalGenerator->ExpandRuleVariables(compileCommand, vars); - std::string workingDirectory = - this->LocalGenerator->Convert( + std::string compileRuleVar = "CMAKE_"; + compileRuleVar += lang; + compileRuleVar += "_COMPILE_OBJECT"; + std::string compileRule = + this->Makefile->GetRequiredDefinition(compileRuleVar); + std::vector<std::string> compileCommands; + cmSystemTools::ExpandListArgument(compileRule, compileCommands); + + if (this->Makefile->IsOn("CMAKE_EXPORT_COMPILE_COMMANDS") && + lang_can_export_cmds && compileCommands.size() == 1) { + std::string compileCommand = compileCommands[0]; + this->LocalGenerator->ExpandRuleVariables(compileCommand, vars); + std::string workingDirectory = this->LocalGenerator->Convert( this->LocalGenerator->GetCurrentBinaryDirectory(), - cmLocalGenerator::FULL); - compileCommand.replace(compileCommand.find(langFlags), - langFlags.size(), this->GetFlags(lang)); - std::string langDefines = std::string("$(") + lang + "_DEFINES)"; - compileCommand.replace(compileCommand.find(langDefines), - langDefines.size(), this->GetDefines(lang)); - std::string langIncludes = std::string("$(") + lang + "_INCLUDES)"; - compileCommand.replace(compileCommand.find(langIncludes), - langIncludes.size(), this->GetIncludes(lang)); - this->GlobalGenerator->AddCXXCompileCommand( - source.GetFullPath(), workingDirectory, compileCommand); - } - - // Maybe insert an include-what-you-use runner. - if (!compileCommands.empty() && (lang == "C" || lang == "CXX")) - { - std::string const iwyu_prop = lang + "_INCLUDE_WHAT_YOU_USE"; - const char *iwyu = this->GeneratorTarget->GetProperty(iwyu_prop); - std::string const tidy_prop = lang + "_CLANG_TIDY"; - const char *tidy = this->GeneratorTarget->GetProperty(tidy_prop); - if ((iwyu && *iwyu) || (tidy && *tidy)) - { - std::string run_iwyu = "$(CMAKE_COMMAND) -E __run_iwyu"; - if (iwyu && *iwyu) - { - run_iwyu += " --iwyu="; - run_iwyu += this->LocalGenerator->EscapeForShell(iwyu); + cmLocalGenerator::FULL); + compileCommand.replace(compileCommand.find(langFlags), langFlags.size(), + this->GetFlags(lang)); + std::string langDefines = std::string("$(") + lang + "_DEFINES)"; + compileCommand.replace(compileCommand.find(langDefines), + langDefines.size(), this->GetDefines(lang)); + std::string langIncludes = std::string("$(") + lang + "_INCLUDES)"; + compileCommand.replace(compileCommand.find(langIncludes), + langIncludes.size(), this->GetIncludes(lang)); + this->GlobalGenerator->AddCXXCompileCommand( + source.GetFullPath(), workingDirectory, compileCommand); + } + + // Maybe insert an include-what-you-use runner. + if (!compileCommands.empty() && (lang == "C" || lang == "CXX")) { + std::string const iwyu_prop = lang + "_INCLUDE_WHAT_YOU_USE"; + const char* iwyu = this->GeneratorTarget->GetProperty(iwyu_prop); + std::string const tidy_prop = lang + "_CLANG_TIDY"; + const char* tidy = this->GeneratorTarget->GetProperty(tidy_prop); + if ((iwyu && *iwyu) || (tidy && *tidy)) { + std::string run_iwyu = "$(CMAKE_COMMAND) -E __run_iwyu"; + if (iwyu && *iwyu) { + run_iwyu += " --iwyu="; + run_iwyu += this->LocalGenerator->EscapeForShell(iwyu); } - if (tidy && *tidy) - { - run_iwyu += " --tidy="; - run_iwyu += this->LocalGenerator->EscapeForShell(tidy); - run_iwyu += " --source="; - run_iwyu += sourceFile; + if (tidy && *tidy) { + run_iwyu += " --tidy="; + run_iwyu += this->LocalGenerator->EscapeForShell(tidy); + run_iwyu += " --source="; + run_iwyu += sourceFile; } - run_iwyu += " -- "; - compileCommands.front().insert(0, run_iwyu); + run_iwyu += " -- "; + compileCommands.front().insert(0, run_iwyu); } } - // Maybe insert a compiler launcher like ccache or distcc - if (!compileCommands.empty() && (lang == "C" || lang == "CXX")) - { - std::string const clauncher_prop = lang + "_COMPILER_LAUNCHER"; - const char *clauncher = this->GeneratorTarget->GetProperty(clauncher_prop); - if (clauncher && *clauncher) - { - std::vector<std::string> launcher_cmd; - cmSystemTools::ExpandListArgument(clauncher, launcher_cmd, true); - for (std::vector<std::string>::iterator i = launcher_cmd.begin(), - e = launcher_cmd.end(); i != e; ++i) - { - *i = this->LocalGenerator->EscapeForShell(*i); + // Maybe insert a compiler launcher like ccache or distcc + if (!compileCommands.empty() && (lang == "C" || lang == "CXX")) { + std::string const clauncher_prop = lang + "_COMPILER_LAUNCHER"; + const char* clauncher = + this->GeneratorTarget->GetProperty(clauncher_prop); + if (clauncher && *clauncher) { + std::vector<std::string> launcher_cmd; + cmSystemTools::ExpandListArgument(clauncher, launcher_cmd, true); + for (std::vector<std::string>::iterator i = launcher_cmd.begin(), + e = launcher_cmd.end(); + i != e; ++i) { + *i = this->LocalGenerator->EscapeForShell(*i); } - std::string const& run_launcher = cmJoin(launcher_cmd, " ") + " "; - compileCommands.front().insert(0, run_launcher); + std::string const& run_launcher = cmJoin(launcher_cmd, " ") + " "; + compileCommands.front().insert(0, run_launcher); } } - // Expand placeholders in the commands. - for(std::vector<std::string>::iterator i = compileCommands.begin(); - i != compileCommands.end(); ++i) - { - this->LocalGenerator->ExpandRuleVariables(*i, vars); + // Expand placeholders in the commands. + for (std::vector<std::string>::iterator i = compileCommands.begin(); + i != compileCommands.end(); ++i) { + this->LocalGenerator->ExpandRuleVariables(*i, vars); } - // Change the command working directory to the local build tree. - this->LocalGenerator->CreateCDCommand - (compileCommands, - this->LocalGenerator->GetCurrentBinaryDirectory(), - cmLocalGenerator::HOME_OUTPUT); - commands.insert(commands.end(), - compileCommands.begin(), compileCommands.end()); + // Change the command working directory to the local build tree. + this->LocalGenerator->CreateCDCommand( + compileCommands, this->LocalGenerator->GetCurrentBinaryDirectory(), + cmLocalGenerator::HOME_OUTPUT); + commands.insert(commands.end(), compileCommands.begin(), + compileCommands.end()); } // Check for extra outputs created by the compilation. std::vector<std::string> outputs(1, relativeObj); - if(const char* extra_outputs_str = - source.GetProperty("OBJECT_OUTPUTS")) - { + if (const char* extra_outputs_str = source.GetProperty("OBJECT_OUTPUTS")) { // Register these as extra files to clean. cmSystemTools::ExpandListArgument(extra_outputs_str, outputs); - this->CleanFiles.insert(this->CleanFiles.end(), - outputs.begin() + 1, outputs.end()); - } + this->CleanFiles.insert(this->CleanFiles.end(), outputs.begin() + 1, + outputs.end()); + } // Write the rule. - this->WriteMakeRule(*this->BuildFileStream, 0, outputs, - depends, commands); + this->WriteMakeRule(*this->BuildFileStream, 0, outputs, depends, commands); bool do_preprocess_rules = lang_has_preprocessor && this->LocalGenerator->GetCreatePreprocessedSourceRules(); - bool do_assembly_rules = lang_has_assembly && - this->LocalGenerator->GetCreateAssemblySourceRules(); - if(do_preprocess_rules || do_assembly_rules) - { + bool do_assembly_rules = + lang_has_assembly && this->LocalGenerator->GetCreateAssemblySourceRules(); + if (do_preprocess_rules || do_assembly_rules) { std::vector<std::string> force_depends; force_depends.push_back("cmake_force"); std::string::size_type dot_pos = relativeObj.rfind("."); @@ -746,8 +666,7 @@ cmMakefileTargetGenerator dot_pos = obj.rfind("."); std::string objBase = obj.substr(0, dot_pos); - if(do_preprocess_rules) - { + if (do_preprocess_rules) { commands.clear(); std::string relativeObjI = relativeObjBase + ".i"; std::string objI = objBase + ".i"; @@ -758,53 +677,44 @@ cmMakefileTargetGenerator preprocessEcho += objI; this->LocalGenerator->AppendEcho( commands, preprocessEcho.c_str(), - cmLocalUnixMakefileGenerator3::EchoBuild - ); + cmLocalUnixMakefileGenerator3::EchoBuild); std::string preprocessRuleVar = "CMAKE_"; preprocessRuleVar += lang; preprocessRuleVar += "_CREATE_PREPROCESSED_SOURCE"; - if(const char* preprocessRule = - this->Makefile->GetDefinition(preprocessRuleVar)) - { + if (const char* preprocessRule = + this->Makefile->GetDefinition(preprocessRuleVar)) { std::vector<std::string> preprocessCommands; cmSystemTools::ExpandListArgument(preprocessRule, preprocessCommands); std::string shellObjI = - this->Convert(objI, - cmLocalGenerator::NONE, - cmLocalGenerator::SHELL); + this->Convert(objI, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); vars.PreprocessedSource = shellObjI.c_str(); // Expand placeholders in the commands. - for(std::vector<std::string>::iterator i = preprocessCommands.begin(); - i != preprocessCommands.end(); ++i) - { + for (std::vector<std::string>::iterator i = preprocessCommands.begin(); + i != preprocessCommands.end(); ++i) { this->LocalGenerator->ExpandRuleVariables(*i, vars); - } - - this->LocalGenerator->CreateCDCommand - (preprocessCommands, - this->LocalGenerator->GetCurrentBinaryDirectory(), - cmLocalGenerator::HOME_OUTPUT); - commands.insert(commands.end(), - preprocessCommands.begin(), - preprocessCommands.end()); } - else - { + + this->LocalGenerator->CreateCDCommand( + preprocessCommands, + this->LocalGenerator->GetCurrentBinaryDirectory(), + cmLocalGenerator::HOME_OUTPUT); + commands.insert(commands.end(), preprocessCommands.begin(), + preprocessCommands.end()); + } else { std::string cmd = "$(CMAKE_COMMAND) -E cmake_unimplemented_variable "; cmd += preprocessRuleVar; commands.push_back(cmd); - } + } this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - relativeObjI, - force_depends, commands, false); - } + relativeObjI, force_depends, + commands, false); + } - if(do_assembly_rules) - { + if (do_assembly_rules) { commands.clear(); std::string relativeObjS = relativeObjBase + ".s"; std::string objS = objBase + ".s"; @@ -815,51 +725,42 @@ cmMakefileTargetGenerator assemblyEcho += objS; this->LocalGenerator->AppendEcho( commands, assemblyEcho.c_str(), - cmLocalUnixMakefileGenerator3::EchoBuild - ); + cmLocalUnixMakefileGenerator3::EchoBuild); std::string assemblyRuleVar = "CMAKE_"; assemblyRuleVar += lang; assemblyRuleVar += "_CREATE_ASSEMBLY_SOURCE"; - if(const char* assemblyRule = - this->Makefile->GetDefinition(assemblyRuleVar)) - { + if (const char* assemblyRule = + this->Makefile->GetDefinition(assemblyRuleVar)) { std::vector<std::string> assemblyCommands; cmSystemTools::ExpandListArgument(assemblyRule, assemblyCommands); std::string shellObjS = - this->Convert(objS, - cmLocalGenerator::NONE, - cmLocalGenerator::SHELL); + this->Convert(objS, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); vars.AssemblySource = shellObjS.c_str(); // Expand placeholders in the commands. - for(std::vector<std::string>::iterator i = assemblyCommands.begin(); - i != assemblyCommands.end(); ++i) - { + for (std::vector<std::string>::iterator i = assemblyCommands.begin(); + i != assemblyCommands.end(); ++i) { this->LocalGenerator->ExpandRuleVariables(*i, vars); - } - - this->LocalGenerator->CreateCDCommand - (assemblyCommands, - this->LocalGenerator->GetCurrentBinaryDirectory(), - cmLocalGenerator::HOME_OUTPUT); - commands.insert(commands.end(), - assemblyCommands.begin(), - assemblyCommands.end()); } - else - { + + this->LocalGenerator->CreateCDCommand( + assemblyCommands, this->LocalGenerator->GetCurrentBinaryDirectory(), + cmLocalGenerator::HOME_OUTPUT); + commands.insert(commands.end(), assemblyCommands.begin(), + assemblyCommands.end()); + } else { std::string cmd = "$(CMAKE_COMMAND) -E cmake_unimplemented_variable "; cmd += assemblyRuleVar; commands.push_back(cmd); - } + } this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - relativeObjS, - force_depends, commands, false); - } + relativeObjS, force_depends, + commands, false); } + } // If the language needs provides-requires mode, create the // corresponding targets. @@ -867,9 +768,8 @@ cmMakefileTargetGenerator objectRequires += ".requires"; std::vector<std::string> p_depends; // always provide an empty requires target - this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - objectRequires, p_depends, - no_commands, true); + this->LocalGenerator->WriteMakeRule( + *this->BuildFileStream, 0, objectRequires, p_depends, no_commands, true); // write a build rule to recursively build what this obj provides std::string objectProvides = relativeObj; @@ -880,22 +780,19 @@ cmMakefileTargetGenerator std::string tgtMakefileName = this->LocalGenerator->GetRelativeTargetDirectory(this->GeneratorTarget); tgtMakefileName += "/build.make"; - r_commands.push_back - (this->LocalGenerator->GetRecursiveMakeCall(tgtMakefileName.c_str(), - temp)); + r_commands.push_back( + this->LocalGenerator->GetRecursiveMakeCall(tgtMakefileName.c_str(), temp)); p_depends.clear(); p_depends.push_back(objectRequires); - this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - objectProvides, p_depends, - r_commands, true); + this->LocalGenerator->WriteMakeRule( + *this->BuildFileStream, 0, objectProvides, p_depends, r_commands, true); // write the provides.build rule dependency on the obj file p_depends.clear(); p_depends.push_back(relativeObj); - this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - temp, p_depends, no_commands, - false); + this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, temp, + p_depends, no_commands, false); } void cmMakefileTargetGenerator::WriteTargetRequiresRules() @@ -911,18 +808,16 @@ void cmMakefileTargetGenerator::WriteTargetRequiresRules() // This target drives dependency generation for all object files. std::string relPath = this->LocalGenerator->GetHomeRelativeOutputPath(); std::string objTarget; - for(std::vector<std::string>::const_iterator obj = this->Objects.begin(); - obj != this->Objects.end(); ++obj) - { + for (std::vector<std::string>::const_iterator obj = this->Objects.begin(); + obj != this->Objects.end(); ++obj) { objTarget = relPath; objTarget += *obj; objTarget += ".requires"; depends.push_back(objTarget); - } + } // Write the rule. - this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - depTarget, + this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, depTarget, depends, no_commands, true); } @@ -939,58 +834,49 @@ void cmMakefileTargetGenerator::WriteTargetCleanRules() // Construct the clean command. this->LocalGenerator->AppendCleanCommand(commands, this->CleanFiles, this->GeneratorTarget); - this->LocalGenerator->CreateCDCommand - (commands, - this->LocalGenerator->GetCurrentBinaryDirectory(), - cmLocalGenerator::HOME_OUTPUT); + this->LocalGenerator->CreateCDCommand( + commands, this->LocalGenerator->GetCurrentBinaryDirectory(), + cmLocalGenerator::HOME_OUTPUT); // Write the rule. - this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - cleanTarget, + this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, cleanTarget, depends, commands, true); } bool cmMakefileTargetGenerator::WriteMakeRule( - std::ostream& os, - const char* comment, + std::ostream& os, const char* comment, const std::vector<std::string>& outputs, const std::vector<std::string>& depends, - const std::vector<std::string>& commands, - bool in_help) + const std::vector<std::string>& commands, bool in_help) { bool symbolic = false; - if (outputs.size() == 0) - { + if (outputs.size() == 0) { return symbolic; - } + } // Check whether we need to bother checking for a symbolic output. bool need_symbolic = this->GlobalGenerator->GetNeedSymbolicMark(); // Check whether the first output is marked as symbolic. - if(need_symbolic) - { - if(cmSourceFile* sf = this->Makefile->GetSource(outputs[0])) - { + if (need_symbolic) { + if (cmSourceFile* sf = this->Makefile->GetSource(outputs[0])) { symbolic = sf->GetPropertyAsBool("SYMBOLIC"); - } } + } // We always attach the actual commands to the first output. this->LocalGenerator->WriteMakeRule(os, comment, outputs[0], depends, commands, symbolic, in_help); // For single outputs, we are done. - if (outputs.size() == 1) - { + if (outputs.size() == 1) { return symbolic; - } + } // For multiple outputs, make the extra ones depend on the first one. std::vector<std::string> const output_depends(1, outputs[0]); - for (std::vector<std::string>::const_iterator o = outputs.begin()+1; - o != outputs.end(); ++o) - { + for (std::vector<std::string>::const_iterator o = outputs.begin() + 1; + o != outputs.end(); ++o) { // Touch the extra output so "make" knows that it was updated, // but only if the output was acually created. std::string const out = this->Convert(*o, cmLocalGenerator::HOME_OUTPUT, @@ -998,30 +884,26 @@ bool cmMakefileTargetGenerator::WriteMakeRule( std::vector<std::string> output_commands; bool o_symbolic = false; - if(need_symbolic) - { - if(cmSourceFile* sf = this->Makefile->GetSource(*o)) - { + if (need_symbolic) { + if (cmSourceFile* sf = this->Makefile->GetSource(*o)) { o_symbolic = sf->GetPropertyAsBool("SYMBOLIC"); - } } + } symbolic = symbolic && o_symbolic; - if (!o_symbolic) - { + if (!o_symbolic) { output_commands.push_back("@$(CMAKE_COMMAND) -E touch_nocreate " + out); - } + } this->LocalGenerator->WriteMakeRule(os, 0, *o, output_depends, output_commands, o_symbolic, in_help); - if (!o_symbolic) - { + if (!o_symbolic) { // At build time, remove the first output if this one does not exist // so that "make" will rerun the real commands that create this one. MultipleOutputPairsType::value_type p(*o, outputs[0]); this->MultipleOutputPairs.insert(p); - } } + } return symbolic; } @@ -1029,7 +911,7 @@ void cmMakefileTargetGenerator::WriteTargetDependRules() { // must write the targets depend info file std::string dir = - this->LocalGenerator->GetTargetDirectory(this->GeneratorTarget); + this->LocalGenerator->GetTargetDirectory(this->GeneratorTarget); this->InfoFileNameFull = dir; this->InfoFileNameFull += "/DependInfo.cmake"; this->InfoFileNameFull = @@ -1037,50 +919,44 @@ void cmMakefileTargetGenerator::WriteTargetDependRules() this->InfoFileStream = new cmGeneratedFileStream(this->InfoFileNameFull.c_str()); this->InfoFileStream->SetCopyIfDifferent(true); - if(!*this->InfoFileStream) - { + if (!*this->InfoFileStream) { return; - } - this->LocalGenerator-> - WriteDependLanguageInfo(*this->InfoFileStream, this->GeneratorTarget); + } + this->LocalGenerator->WriteDependLanguageInfo(*this->InfoFileStream, + this->GeneratorTarget); // Store multiple output pairs in the depend info file. - if(!this->MultipleOutputPairs.empty()) - { + if (!this->MultipleOutputPairs.empty()) { /* clang-format off */ *this->InfoFileStream << "\n" << "# Pairs of files generated by the same build rule.\n" << "set(CMAKE_MULTIPLE_OUTPUT_PAIRS\n"; /* clang-format on */ - for(MultipleOutputPairsType::const_iterator pi = - this->MultipleOutputPairs.begin(); - pi != this->MultipleOutputPairs.end(); ++pi) - { + for (MultipleOutputPairsType::const_iterator pi = + this->MultipleOutputPairs.begin(); + pi != this->MultipleOutputPairs.end(); ++pi) { *this->InfoFileStream - << " " << cmOutputConverter::EscapeForCMake(pi->first) - << " " << cmOutputConverter::EscapeForCMake(pi->second) - << "\n"; - } - *this->InfoFileStream << " )\n\n"; + << " " << cmOutputConverter::EscapeForCMake(pi->first) << " " + << cmOutputConverter::EscapeForCMake(pi->second) << "\n"; } + *this->InfoFileStream << " )\n\n"; + } // Store list of targets linked directly or transitively. { - /* clang-format off */ + /* clang-format off */ *this->InfoFileStream << "\n" << "# Targets to which this target links.\n" << "set(CMAKE_TARGET_LINKED_INFO_FILES\n"; - /* clang-format on */ - std::vector<std::string> dirs = this->GetLinkedTargetDirectories(); - for (std::vector<std::string>::iterator i = dirs.begin(); - i != dirs.end(); ++i) - { - *this->InfoFileStream << " \"" << *i << "/DependInfo.cmake\"\n"; + /* clang-format on */ + std::vector<std::string> dirs = this->GetLinkedTargetDirectories(); + for (std::vector<std::string>::iterator i = dirs.begin(); i != dirs.end(); + ++i) { + *this->InfoFileStream << " \"" << *i << "/DependInfo.cmake\"\n"; } - *this->InfoFileStream - << " )\n"; + *this->InfoFileStream << " )\n"; } /* clang-format off */ @@ -1103,17 +979,16 @@ void cmMakefileTargetGenerator::WriteTargetDependRules() // Add a command to call CMake to scan dependencies. CMake will // touch the corresponding depends file after scanning dependencies. std::ostringstream depCmd; - // TODO: Account for source file properties and directory-level - // definitions when scanning for dependencies. +// TODO: Account for source file properties and directory-level +// definitions when scanning for dependencies. #if !defined(_WIN32) || defined(__CYGWIN__) // This platform supports symlinks, so cmSystemTools will translate // paths. Make sure PWD is set to the original name of the home // output directory to help cmSystemTools to create the same // translation table for the dependency scanning process. - depCmd << "cd " - << (this->LocalGenerator->Convert( - this->LocalGenerator->GetBinaryDirectory(), - cmLocalGenerator::FULL, cmLocalGenerator::SHELL)) + depCmd << "cd " << (this->LocalGenerator->Convert( + this->LocalGenerator->GetBinaryDirectory(), + cmLocalGenerator::FULL, cmLocalGenerator::SHELL)) << " && "; #endif // Generate a call this signature: @@ -1139,87 +1014,75 @@ void cmMakefileTargetGenerator::WriteTargetDependRules() << this->Convert(this->LocalGenerator->GetCurrentBinaryDirectory(), cmLocalGenerator::FULL, cmLocalGenerator::SHELL) << " " - << this->Convert(this->InfoFileNameFull, - cmLocalGenerator::FULL, cmLocalGenerator::SHELL); - if(this->LocalGenerator->GetColorMakefile()) - { + << this->Convert(this->InfoFileNameFull, cmLocalGenerator::FULL, + cmLocalGenerator::SHELL); + if (this->LocalGenerator->GetColorMakefile()) { depCmd << " --color=$(COLOR)"; - } + } commands.push_back(depCmd.str()); // Make sure all custom command outputs in this target are built. - if(this->CustomCommandDriver == OnDepends) - { + if (this->CustomCommandDriver == OnDepends) { this->DriveCustomCommands(depends); - } + } // Write the rule. - this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, - depTarget, + this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, 0, depTarget, depends, commands, true); } -void -cmMakefileTargetGenerator -::DriveCustomCommands(std::vector<std::string>& depends) +void cmMakefileTargetGenerator::DriveCustomCommands( + std::vector<std::string>& depends) { // Depend on all custom command outputs. std::vector<cmSourceFile*> sources; - this->GeneratorTarget->GetSourceFiles(sources, - this->Makefile->GetSafeDefinition("CMAKE_BUILD_TYPE")); - for(std::vector<cmSourceFile*>::const_iterator source = sources.begin(); - source != sources.end(); ++source) - { - if(cmCustomCommand* cc = (*source)->GetCustomCommand()) - { + this->GeneratorTarget->GetSourceFiles( + sources, this->Makefile->GetSafeDefinition("CMAKE_BUILD_TYPE")); + for (std::vector<cmSourceFile*>::const_iterator source = sources.begin(); + source != sources.end(); ++source) { + if (cmCustomCommand* cc = (*source)->GetCustomCommand()) { cmCustomCommandGenerator ccg(*cc, this->ConfigName, this->LocalGenerator); const std::vector<std::string>& outputs = ccg.GetOutputs(); depends.insert(depends.end(), outputs.begin(), outputs.end()); - } } + } } -void cmMakefileTargetGenerator -::WriteObjectDependRules(cmSourceFile const& source, - std::vector<std::string>& depends) +void cmMakefileTargetGenerator::WriteObjectDependRules( + cmSourceFile const& source, std::vector<std::string>& depends) { // Create the list of dependencies known at cmake time. These are // shared between the object file and dependency scanning rule. depends.push_back(source.GetFullPath()); - if(const char* objectDeps = source.GetProperty("OBJECT_DEPENDS")) - { + if (const char* objectDeps = source.GetProperty("OBJECT_DEPENDS")) { cmSystemTools::ExpandListArgument(objectDeps, depends); - } + } } -void cmMakefileTargetGenerator -::GenerateCustomRuleFile(cmCustomCommandGenerator const& ccg) +void cmMakefileTargetGenerator::GenerateCustomRuleFile( + cmCustomCommandGenerator const& ccg) { // Collect the commands. std::vector<std::string> commands; std::string comment = this->LocalGenerator->ConstructComment(ccg); - if(!comment.empty()) - { + if (!comment.empty()) { // add in a progress call if needed this->NumberOfProgressActions++; - if(!this->NoRuleMessages) - { + if (!this->NoRuleMessages) { cmLocalUnixMakefileGenerator3::EchoProgress progress; this->MakeEchoProgress(progress); - this->LocalGenerator - ->AppendEcho(commands, comment.c_str(), - cmLocalUnixMakefileGenerator3::EchoGenerate, - &progress); - } + this->LocalGenerator->AppendEcho( + commands, comment.c_str(), cmLocalUnixMakefileGenerator3::EchoGenerate, + &progress); } + } // Now append the actual user-specified commands. std::ostringstream content; - this->LocalGenerator->AppendCustomCommand(commands, ccg, - this->GeneratorTarget, false, - cmLocalGenerator::HOME_OUTPUT, - &content); + this->LocalGenerator->AppendCustomCommand( + commands, ccg, this->GeneratorTarget, false, cmLocalGenerator::HOME_OUTPUT, + &content); // Collect the dependencies. std::vector<std::string> depends; @@ -1227,34 +1090,30 @@ void cmMakefileTargetGenerator // Write the rule. const std::vector<std::string>& outputs = ccg.GetOutputs(); - bool symbolic = this->WriteMakeRule(*this->BuildFileStream, 0, - outputs, depends, commands); + bool symbolic = + this->WriteMakeRule(*this->BuildFileStream, 0, outputs, depends, commands); // If the rule has changed make sure the output is rebuilt. - if(!symbolic) - { + if (!symbolic) { this->GlobalGenerator->AddRuleHash(ccg.GetOutputs(), content.str()); - } + } // Setup implicit dependency scanning. - for(cmCustomCommand::ImplicitDependsList::const_iterator - idi = ccg.GetCC().GetImplicitDepends().begin(); - idi != ccg.GetCC().GetImplicitDepends().end(); ++idi) - { + for (cmCustomCommand::ImplicitDependsList::const_iterator idi = + ccg.GetCC().GetImplicitDepends().begin(); + idi != ccg.GetCC().GetImplicitDepends().end(); ++idi) { std::string objFullPath = this->Convert(outputs[0], cmLocalGenerator::FULL); std::string srcFullPath = this->Convert(idi->second, cmLocalGenerator::FULL); - this->LocalGenerator-> - AddImplicitDepends(this->GeneratorTarget, idi->first, - objFullPath.c_str(), - srcFullPath.c_str()); - } + this->LocalGenerator->AddImplicitDepends(this->GeneratorTarget, idi->first, + objFullPath.c_str(), + srcFullPath.c_str()); + } } -void -cmMakefileTargetGenerator -::MakeEchoProgress(cmLocalUnixMakefileGenerator3::EchoProgress& progress) const +void cmMakefileTargetGenerator::MakeEchoProgress( + cmLocalUnixMakefileGenerator3::EchoProgress& progress) const { progress.Dir = this->LocalGenerator->GetBinaryDirectory(); progress.Dir += cmake::GetCMakeFilesDirectory(); @@ -1263,42 +1122,35 @@ cmMakefileTargetGenerator progress.Arg = progressArg.str(); } -void -cmMakefileTargetGenerator -::WriteObjectsVariable(std::string& variableName, - std::string& variableNameExternal, - bool useWatcomQuote) +void cmMakefileTargetGenerator::WriteObjectsVariable( + std::string& variableName, std::string& variableNameExternal, + bool useWatcomQuote) { // Write a make variable assignment that lists all objects for the // target. - variableName = - this->LocalGenerator->CreateMakeVariable(this->GeneratorTarget->GetName(), - "_OBJECTS"); - *this->BuildFileStream - << "# Object files for target " << this->GeneratorTarget->GetName() << "\n" - << variableName << " ="; + variableName = this->LocalGenerator->CreateMakeVariable( + this->GeneratorTarget->GetName(), "_OBJECTS"); + *this->BuildFileStream << "# Object files for target " + << this->GeneratorTarget->GetName() << "\n" + << variableName << " ="; std::string object; const char* lineContinue = this->Makefile->GetDefinition("CMAKE_MAKE_LINE_CONTINUE"); - if(!lineContinue) - { + if (!lineContinue) { lineContinue = "\\"; - } - for(std::vector<std::string>::const_iterator i = this->Objects.begin(); - i != this->Objects.end(); ++i) - { + } + for (std::vector<std::string>::const_iterator i = this->Objects.begin(); + i != this->Objects.end(); ++i) { *this->BuildFileStream << " " << lineContinue << "\n"; - *this->BuildFileStream << - this->LocalGenerator->ConvertToQuotedOutputPath(i->c_str(), - useWatcomQuote); - } + *this->BuildFileStream << this->LocalGenerator->ConvertToQuotedOutputPath( + i->c_str(), useWatcomQuote); + } *this->BuildFileStream << "\n"; // Write a make variable assignment that lists all external objects // for the target. - variableNameExternal = - this->LocalGenerator->CreateMakeVariable(this->GeneratorTarget->GetName(), - "_EXTERNAL_OBJECTS"); + variableNameExternal = this->LocalGenerator->CreateMakeVariable( + this->GeneratorTarget->GetName(), "_EXTERNAL_OBJECTS"); /* clang-format off */ *this->BuildFileStream << "\n" @@ -1306,24 +1158,21 @@ cmMakefileTargetGenerator << this->GeneratorTarget->GetName() << "\n" << variableNameExternal << " ="; /* clang-format on */ - for(std::vector<std::string>::const_iterator i = - this->ExternalObjects.begin(); - i != this->ExternalObjects.end(); ++i) - { - object = this->Convert(*i,cmLocalGenerator::START_OUTPUT); - *this->BuildFileStream - << " " << lineContinue << "\n" - << this->Makefile->GetSafeDefinition("CMAKE_OBJECT_NAME"); - *this->BuildFileStream << - this->LocalGenerator->ConvertToQuotedOutputPath(i->c_str(), - useWatcomQuote); - } - *this->BuildFileStream << "\n" << "\n"; + for (std::vector<std::string>::const_iterator i = + this->ExternalObjects.begin(); + i != this->ExternalObjects.end(); ++i) { + object = this->Convert(*i, cmLocalGenerator::START_OUTPUT); + *this->BuildFileStream << " " << lineContinue << "\n" + << this->Makefile->GetSafeDefinition( + "CMAKE_OBJECT_NAME"); + *this->BuildFileStream << this->LocalGenerator->ConvertToQuotedOutputPath( + i->c_str(), useWatcomQuote); + } + *this->BuildFileStream << "\n" + << "\n"; } -void -cmMakefileTargetGenerator -::WriteObjectsString(std::string& buildObjs) +void cmMakefileTargetGenerator::WriteObjectsString(std::string& buildObjs) { std::vector<std::string> objStrings; this->WriteObjectsStrings(objStrings); @@ -1335,28 +1184,27 @@ class cmMakefileTargetGeneratorObjectStrings public: cmMakefileTargetGeneratorObjectStrings(std::vector<std::string>& strings, cmLocalUnixMakefileGenerator3* lg, - std::string::size_type limit): - Strings(strings), LocalGenerator(lg), LengthLimit(limit) - { + std::string::size_type limit) + : Strings(strings) + , LocalGenerator(lg) + , LengthLimit(limit) + { this->Space = ""; - } + } void Feed(std::string const& obj) - { + { // Construct the name of the next object. - this->NextObject = - this->LocalGenerator->Convert(obj, - cmLocalGenerator::START_OUTPUT, - cmLocalGenerator::RESPONSE); + this->NextObject = this->LocalGenerator->Convert( + obj, cmLocalGenerator::START_OUTPUT, cmLocalGenerator::RESPONSE); // Roll over to next string if the limit will be exceeded. - if(this->LengthLimit != std::string::npos && - (this->CurrentString.length() + 1 + this->NextObject.length() - > this->LengthLimit)) - { + if (this->LengthLimit != std::string::npos && + (this->CurrentString.length() + 1 + this->NextObject.length() > + this->LengthLimit)) { this->Strings.push_back(this->CurrentString); this->CurrentString = ""; this->Space = ""; - } + } // Separate from previous object. this->CurrentString += this->Space; @@ -1364,11 +1212,8 @@ public: // Append this object. this->CurrentString += this->NextObject; - } - void Done() - { - this->Strings.push_back(this->CurrentString); - } + } + void Done() { this->Strings.push_back(this->CurrentString); } private: std::vector<std::string>& Strings; cmLocalUnixMakefileGenerator3* LocalGenerator; @@ -1378,117 +1223,105 @@ private: const char* Space; }; -void -cmMakefileTargetGenerator -::WriteObjectsStrings(std::vector<std::string>& objStrings, - std::string::size_type limit) +void cmMakefileTargetGenerator::WriteObjectsStrings( + std::vector<std::string>& objStrings, std::string::size_type limit) { - cmMakefileTargetGeneratorObjectStrings - helper(objStrings, this->LocalGenerator, limit); - for(std::vector<std::string>::const_iterator i = this->Objects.begin(); - i != this->Objects.end(); ++i) - { + cmMakefileTargetGeneratorObjectStrings helper(objStrings, + this->LocalGenerator, limit); + for (std::vector<std::string>::const_iterator i = this->Objects.begin(); + i != this->Objects.end(); ++i) { helper.Feed(*i); - } - for(std::vector<std::string>::const_iterator i = - this->ExternalObjects.begin(); - i != this->ExternalObjects.end(); ++i) - { + } + for (std::vector<std::string>::const_iterator i = + this->ExternalObjects.begin(); + i != this->ExternalObjects.end(); ++i) { helper.Feed(*i); - } + } helper.Done(); } void cmMakefileTargetGenerator::WriteTargetDriverRule( - const std::string& main_output, - bool relink) + const std::string& main_output, bool relink) { // Compute the name of the driver target. std::string dir = this->LocalGenerator->GetRelativeTargetDirectory(this->GeneratorTarget); std::string buildTargetRuleName = dir; - buildTargetRuleName += relink?"/preinstall":"/build"; - buildTargetRuleName = this->Convert(buildTargetRuleName, - cmLocalGenerator::HOME_OUTPUT, - cmLocalGenerator::UNCHANGED); + buildTargetRuleName += relink ? "/preinstall" : "/build"; + buildTargetRuleName = + this->Convert(buildTargetRuleName, cmLocalGenerator::HOME_OUTPUT, + cmLocalGenerator::UNCHANGED); // Build the list of target outputs to drive. std::vector<std::string> depends; depends.push_back(main_output); const char* comment = 0; - if(relink) - { + if (relink) { // Setup the comment for the preinstall driver. comment = "Rule to relink during preinstall."; - } - else - { + } else { // Setup the comment for the main build driver. comment = "Rule to build all files generated by this target."; // Make sure all custom command outputs in this target are built. - if(this->CustomCommandDriver == OnBuild) - { + if (this->CustomCommandDriver == OnBuild) { this->DriveCustomCommands(depends); - } + } // Make sure the extra files are built. - depends.insert(depends.end(), - this->ExtraFiles.begin(), this->ExtraFiles.end()); - } + depends.insert(depends.end(), this->ExtraFiles.begin(), + this->ExtraFiles.end()); + } // Write the driver rule. std::vector<std::string> no_commands; this->LocalGenerator->WriteMakeRule(*this->BuildFileStream, comment, - buildTargetRuleName, - depends, no_commands, true); + buildTargetRuleName, depends, + no_commands, true); } -void cmMakefileTargetGenerator -::AppendTargetDepends(std::vector<std::string>& depends) +void cmMakefileTargetGenerator::AppendTargetDepends( + std::vector<std::string>& depends) { // Static libraries never depend on anything for linking. - if(this->GeneratorTarget->GetType() == cmState::STATIC_LIBRARY) - { + if (this->GeneratorTarget->GetType() == cmState::STATIC_LIBRARY) { return; - } + } // Loop over all library dependencies. const char* cfg = this->LocalGenerator->GetConfigName().c_str(); - if(cmComputeLinkInformation* cli = - this->GeneratorTarget->GetLinkInformation(cfg)) - { + if (cmComputeLinkInformation* cli = + this->GeneratorTarget->GetLinkInformation(cfg)) { std::vector<std::string> const& libDeps = cli->GetDepends(); depends.insert(depends.end(), libDeps.begin(), libDeps.end()); - } + } } -void cmMakefileTargetGenerator -::AppendObjectDepends(std::vector<std::string>& depends) +void cmMakefileTargetGenerator::AppendObjectDepends( + std::vector<std::string>& depends) { // Add dependencies on the compiled object files. std::string relPath = this->LocalGenerator->GetHomeRelativeOutputPath(); std::string objTarget; - for(std::vector<std::string>::const_iterator obj = this->Objects.begin(); - obj != this->Objects.end(); ++obj) - { + for (std::vector<std::string>::const_iterator obj = this->Objects.begin(); + obj != this->Objects.end(); ++obj) { objTarget = relPath; objTarget += *obj; depends.push_back(objTarget); - } + } // Add dependencies on the external object files. - depends.insert(depends.end(), - this->ExternalObjects.begin(), this->ExternalObjects.end()); + depends.insert(depends.end(), this->ExternalObjects.begin(), + this->ExternalObjects.end()); // Add a dependency on the rule file itself. this->LocalGenerator->AppendRuleDepend(depends, this->BuildFileNameFull.c_str()); } -void cmMakefileTargetGenerator -::AppendLinkDepends(std::vector<std::string>& depends) +void cmMakefileTargetGenerator::AppendLinkDepends( + std::vector<std::string>& depends) { this->AppendObjectDepends(depends); @@ -1496,56 +1329,49 @@ void cmMakefileTargetGenerator this->AppendTargetDepends(depends); // Add a dependency on the link definitions file, if any. - if(this->ModuleDefinitionFile) - { + if (this->ModuleDefinitionFile) { depends.push_back(this->ModuleDefinitionFile->GetFullPath()); - } + } // Add a dependency on user-specified manifest files, if any. std::vector<cmSourceFile const*> manifest_srcs; this->GeneratorTarget->GetManifests(manifest_srcs, this->ConfigName); for (std::vector<cmSourceFile const*>::iterator mi = manifest_srcs.begin(); - mi != manifest_srcs.end(); ++mi) - { + mi != manifest_srcs.end(); ++mi) { depends.push_back((*mi)->GetFullPath()); - } + } // Add user-specified dependencies. - if(const char* linkDepends = - this->GeneratorTarget->GetProperty("LINK_DEPENDS")) - { + if (const char* linkDepends = + this->GeneratorTarget->GetProperty("LINK_DEPENDS")) { cmSystemTools::ExpandListArgument(linkDepends, depends); - } + } } std::string cmMakefileTargetGenerator::GetLinkRule( - const std::string& linkRuleVar) + const std::string& linkRuleVar) { std::string linkRule = this->Makefile->GetRequiredDefinition(linkRuleVar); - if(this->GeneratorTarget->HasImplibGNUtoMS()) - { + if (this->GeneratorTarget->HasImplibGNUtoMS()) { std::string ruleVar = "CMAKE_"; ruleVar += this->GeneratorTarget->GetLinkerLanguage(this->ConfigName); ruleVar += "_GNUtoMS_RULE"; - if(const char* rule = this->Makefile->GetDefinition(ruleVar)) - { + if (const char* rule = this->Makefile->GetDefinition(ruleVar)) { linkRule += rule; - } } + } return linkRule; } -void cmMakefileTargetGenerator -::CloseFileStreams() +void cmMakefileTargetGenerator::CloseFileStreams() { delete this->BuildFileStream; delete this->InfoFileStream; delete this->FlagFileStream; } -void cmMakefileTargetGenerator::RemoveForbiddenFlags(const char* flagVar, - const std::string& linkLang, - std::string& linkFlags) +void cmMakefileTargetGenerator::RemoveForbiddenFlags( + const char* flagVar, const std::string& linkLang, std::string& linkFlags) { // check for language flags that are not allowed at link time, and // remove them, -w on darwin for gcc -w -dynamiclib sends -w to libtool @@ -1554,55 +1380,46 @@ void cmMakefileTargetGenerator::RemoveForbiddenFlags(const char* flagVar, std::string removeFlags = "CMAKE_"; removeFlags += linkLang; removeFlags += flagVar; - std::string removeflags = - this->Makefile->GetSafeDefinition(removeFlags); + std::string removeflags = this->Makefile->GetSafeDefinition(removeFlags); std::vector<std::string> removeList; cmSystemTools::ExpandListArgument(removeflags, removeList); - for(std::vector<std::string>::iterator i = removeList.begin(); - i != removeList.end(); ++i) - { + for (std::vector<std::string>::iterator i = removeList.begin(); + i != removeList.end(); ++i) { std::string tmp; std::string::size_type lastPosition = 0; - for(;;) - { + for (;;) { std::string::size_type position = linkFlags.find(*i, lastPosition); - if(position == std::string::npos) - { + if (position == std::string::npos) { tmp += linkFlags.substr(lastPosition); break; - } - else - { + } else { std::string::size_type prefixLength = position - lastPosition; tmp += linkFlags.substr(lastPosition, prefixLength); lastPosition = position + i->length(); - bool validFlagStart = position == 0 || - isspace(linkFlags[position - 1]); + bool validFlagStart = + position == 0 || isspace(linkFlags[position - 1]); - bool validFlagEnd = lastPosition == linkFlags.size() || - isspace(linkFlags[lastPosition]); + bool validFlagEnd = + lastPosition == linkFlags.size() || isspace(linkFlags[lastPosition]); - if(!validFlagStart || !validFlagEnd) - { + if (!validFlagStart || !validFlagEnd) { tmp += *i; - } } } + } linkFlags = tmp; - } + } } -void -cmMakefileTargetGenerator -::CreateLinkScript(const char* name, - std::vector<std::string> const& link_commands, - std::vector<std::string>& makefile_commands, - std::vector<std::string>& makefile_depends) +void cmMakefileTargetGenerator::CreateLinkScript( + const char* name, std::vector<std::string> const& link_commands, + std::vector<std::string>& makefile_commands, + std::vector<std::string>& makefile_depends) { // Create the link script file. std::string linkScriptName = this->TargetBuildDirectoryFull; @@ -1610,31 +1427,27 @@ cmMakefileTargetGenerator linkScriptName += name; cmGeneratedFileStream linkScriptStream(linkScriptName.c_str()); linkScriptStream.SetCopyIfDifferent(true); - for(std::vector<std::string>::const_iterator cmd = link_commands.begin(); - cmd != link_commands.end(); ++cmd) - { + for (std::vector<std::string>::const_iterator cmd = link_commands.begin(); + cmd != link_commands.end(); ++cmd) { // Do not write out empty commands or commands beginning in the // shell no-op ":". - if(!cmd->empty() && (*cmd)[0] != ':') - { + if (!cmd->empty() && (*cmd)[0] != ':') { linkScriptStream << *cmd << "\n"; - } } + } // Create the makefile command to invoke the link script. std::string link_command = "$(CMAKE_COMMAND) -E cmake_link_script "; - link_command += this->Convert(linkScriptName, - cmLocalGenerator::START_OUTPUT, + link_command += this->Convert(linkScriptName, cmLocalGenerator::START_OUTPUT, cmLocalGenerator::SHELL); link_command += " --verbose=$(VERBOSE)"; makefile_commands.push_back(link_command); makefile_depends.push_back(linkScriptName); } -std::string -cmMakefileTargetGenerator -::CreateResponseFile(const char* name, std::string const& options, - std::vector<std::string>& makefile_depends) +std::string cmMakefileTargetGenerator::CreateResponseFile( + const char* name, std::string const& options, + std::vector<std::string>& makefile_depends) { // Create the response file. std::string responseFileNameFull = this->TargetBuildDirectoryFull; @@ -1655,35 +1468,27 @@ cmMakefileTargetGenerator return responseFileName; } -void -cmMakefileTargetGenerator -::CreateLinkLibs(std::string& linkLibs, bool relink, - bool useResponseFile, - std::vector<std::string>& makefile_depends, - bool useWatcomQuote) +void cmMakefileTargetGenerator::CreateLinkLibs( + std::string& linkLibs, bool relink, bool useResponseFile, + std::vector<std::string>& makefile_depends, bool useWatcomQuote) { std::string frameworkPath; std::string linkPath; - this->LocalGenerator - ->OutputLinkLibraries(linkLibs, frameworkPath, linkPath, - *this->GeneratorTarget, relink, - useResponseFile, - useWatcomQuote); + this->LocalGenerator->OutputLinkLibraries(linkLibs, frameworkPath, linkPath, + *this->GeneratorTarget, relink, + useResponseFile, useWatcomQuote); linkLibs = frameworkPath + linkPath + linkLibs; - if(useResponseFile && linkLibs.find_first_not_of(" ") != linkLibs.npos) - { + if (useResponseFile && linkLibs.find_first_not_of(" ") != linkLibs.npos) { // Lookup the response file reference flag. std::string responseFlagVar = "CMAKE_"; - responseFlagVar += this->GeneratorTarget - ->GetLinkerLanguage(this->ConfigName); + responseFlagVar += + this->GeneratorTarget->GetLinkerLanguage(this->ConfigName); responseFlagVar += "_RESPONSE_FILE_LINK_FLAG"; - const char* responseFlag = - this->Makefile->GetDefinition(responseFlagVar); - if(!responseFlag) - { + const char* responseFlag = this->Makefile->GetDefinition(responseFlagVar); + if (!responseFlag) { responseFlag = "@"; - } + } // Create this response file. std::string link_rsp = @@ -1691,25 +1496,21 @@ cmMakefileTargetGenerator // Reference the response file. linkLibs = responseFlag; - linkLibs += this->Convert(link_rsp, - cmLocalGenerator::NONE, - cmLocalGenerator::SHELL); - } + linkLibs += + this->Convert(link_rsp, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); + } } -void -cmMakefileTargetGenerator -::CreateObjectLists(bool useLinkScript, bool useArchiveRules, - bool useResponseFile, std::string& buildObjs, - std::vector<std::string>& makefile_depends, - bool useWatcomQuote) +void cmMakefileTargetGenerator::CreateObjectLists( + bool useLinkScript, bool useArchiveRules, bool useResponseFile, + std::string& buildObjs, std::vector<std::string>& makefile_depends, + bool useWatcomQuote) { std::string variableName; std::string variableNameExternal; this->WriteObjectsVariable(variableName, variableNameExternal, useWatcomQuote); - if(useResponseFile) - { + if (useResponseFile) { // MSVC response files cannot exceed 128K. std::string::size_type const responseFileLimit = 131000; @@ -1719,23 +1520,20 @@ cmMakefileTargetGenerator // Lookup the response file reference flag. std::string responseFlagVar = "CMAKE_"; - responseFlagVar += this->GeneratorTarget - ->GetLinkerLanguage(this->ConfigName); + responseFlagVar += + this->GeneratorTarget->GetLinkerLanguage(this->ConfigName); responseFlagVar += "_RESPONSE_FILE_LINK_FLAG"; - const char* responseFlag = - this->Makefile->GetDefinition(responseFlagVar); - if(!responseFlag) - { + const char* responseFlag = this->Makefile->GetDefinition(responseFlagVar); + if (!responseFlag) { responseFlag = "@"; - } + } // Write a response file for each string. const char* sep = ""; - for(unsigned int i = 0; i < object_strings.size(); ++i) - { + for (unsigned int i = 0; i < object_strings.size(); ++i) { // Number the response files. char rsp[32]; - sprintf(rsp, "objects%u.rsp", i+1); + sprintf(rsp, "objects%u.rsp", i + 1); // Create this response file. std::string objects_rsp = @@ -1747,26 +1545,20 @@ cmMakefileTargetGenerator // Reference the response file. buildObjs += responseFlag; - buildObjs += this->Convert(objects_rsp, - cmLocalGenerator::NONE, + buildObjs += this->Convert(objects_rsp, cmLocalGenerator::NONE, cmLocalGenerator::SHELL); - } } - else if(useLinkScript) - { - if(!useArchiveRules) - { + } else if (useLinkScript) { + if (!useArchiveRules) { this->WriteObjectsString(buildObjs); - } } - else - { + } else { buildObjs = "$("; buildObjs += variableName; buildObjs += ") $("; buildObjs += variableNameExternal; buildObjs += ")"; - } + } } void cmMakefileTargetGenerator::AddIncludeFlags(std::string& flags, @@ -1777,25 +1569,19 @@ void cmMakefileTargetGenerator::AddIncludeFlags(std::string& flags, responseVar += "_USE_RESPONSE_FILE_FOR_INCLUDES"; bool useResponseFile = this->Makefile->IsOn(responseVar); - std::vector<std::string> includes; const std::string& config = this->Makefile->GetSafeDefinition("CMAKE_BUILD_TYPE"); - this->LocalGenerator->GetIncludeDirectories(includes, - this->GeneratorTarget, + this->LocalGenerator->GetIncludeDirectories(includes, this->GeneratorTarget, lang, config); - std::string includeFlags = - this->LocalGenerator->GetIncludeFlags(includes, this->GeneratorTarget, - lang, false, useResponseFile, - config); - if(includeFlags.empty()) - { + std::string includeFlags = this->LocalGenerator->GetIncludeFlags( + includes, this->GeneratorTarget, lang, false, useResponseFile, config); + if (includeFlags.empty()) { return; - } + } - if(useResponseFile) - { + if (useResponseFile) { std::string name = "includes_"; name += lang; name += ".rsp"; @@ -1803,9 +1589,7 @@ void cmMakefileTargetGenerator::AddIncludeFlags(std::string& flags, this->CreateResponseFile(name.c_str(), includeFlags, this->FlagFileDepends[lang]); this->LocalGenerator->AppendFlags(flags, arg); - } - else - { + } else { this->LocalGenerator->AppendFlags(flags, includeFlags); - } + } } |