BUG: Sweeping changes to cleanup computation of target names. This should

fix many bugs related to target names being computed inconsistently.

- Centralized computation of a target's file name to a method in
  cmTarget.  Now that global knowledge is always available the
  *_CMAKE_PATH cache variables are no longer needed.

- Centralized computation of link library command lines and link
  directory search order.

- Moved computation of link directories needed to link CMake targets
  to be after evaluation of linking dependencies.

This also removed alot of duplicate code in which each version had its
own bugs.

This commit is surrounded by the tags

  CMake-TargetNameCentralization1-pre

and

  CMake-TargetNameCentralization1-post

so make the large set of changes easy to identify.

1 files changed, 9 insertions, 2 deletions

diff --git a/Source/cmOrderLinkDirectories.h b/Source/cmOrderLinkDirectories.h
index 49830b5..88f6e16 100644
--- a/Source/cmOrderLinkDirectories.h
+++ b/Source/cmOrderLinkDirectories.h
@@ -49,8 +49,9 @@ class cmOrderLinkDirectories
 public:
   cmOrderLinkDirectories();
   ///! set link information from the target
-  void SetLinkInformation(cmTarget&, cmTarget::LinkLibraryType,
-                          const char* targetLibrary);
+  void SetLinkInformation(const char* targetName,
+                          const std::vector<std::string>& linkLibraries,
+                          const std::vector<std::string>& linkDirectories);
   ///! Compute the best order for -L paths from GetLinkLibraries
   bool DetermineLibraryPathOrder();
   ///! Get the results from DetermineLibraryPathOrder
@@ -65,12 +66,18 @@ public:
   // CMAKE_LINK_LIBRARY_SUFFIX
   void AddLinkExtension(const char* e)
     {
+    if(e && *e)
+      {
       m_LinkExtensions.push_back(e);
+      }
     }
   // should be set from CMAKE_STATIC_LIBRARY_PREFIX
   void SetLinkPrefix(const char* s)
     {
+    if(s)
+      {
       m_LinkPrefix = s;
+      }
     }
   // Return any warnings if the exist
   std::string GetWarnings();