diff options
author | Dimitar Yordanov <dimitar.yordanov@sap.com> | 2016-02-12 12:21:12 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2016-02-12 16:19:40 (GMT) |
commit | c8c45a2c4e10715e5cf05acaa0ac2c80f28b9a6a (patch) | |
tree | 7e9300e1c0698c5783d6b8931a69c208ffd927a4 /Source/cmParseArgumentsCommand.cxx | |
parent | a5a5a6857241c21d306661d723b749839f4c6e1a (diff) | |
download | CMake-c8c45a2c4e10715e5cf05acaa0ac2c80f28b9a6a.zip CMake-c8c45a2c4e10715e5cf05acaa0ac2c80f28b9a6a.tar.gz CMake-c8c45a2c4e10715e5cf05acaa0ac2c80f28b9a6a.tar.bz2 |
cmake_parse_arguments: Restore ;-list argument flattening
The re-implementation in commit v3.5.0-rc1~116^2~1 (CMakeParseArguments:
replace by native cmake_parse_arguments command, 2015-12-05) introduced
a regression when parsing the ARGN arguments with cmake_parse_arguments.
The original implementation used
foreach(currentArg ${ARGN})
to iterate over input arguments. This flattened ;-lists within the
arguments whether they were quoted or not. Fix our new implementation
to preserve this behavior and add a test case to cover it.
Signed-off-by: Dimitar Yordanov <dimitar.yordanov@sap.com>
Signed-off-by: Matthias Maennich <matthias.maennich@sap.com>
Diffstat (limited to 'Source/cmParseArgumentsCommand.cxx')
-rw-r--r-- | Source/cmParseArgumentsCommand.cxx | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/Source/cmParseArgumentsCommand.cxx b/Source/cmParseArgumentsCommand.cxx index a861965..ca76c88 100644 --- a/Source/cmParseArgumentsCommand.cxx +++ b/Source/cmParseArgumentsCommand.cxx @@ -97,10 +97,18 @@ bool cmParseArgumentsCommand } insideValues = NONE; std::string currentArgName; - // now iterate over the remaining arguments - // and fill in the values where applicable + // Flatten ;-lists in the arguments into a single list as was done + // by the original function(CMAKE_PARSE_ARGUMENTS). + list.clear(); for(; argIter != argEnd; ++argIter) { + cmSystemTools::ExpandListArgument(*argIter, list); + } + + // iterate over the arguments list and fill in the values where applicable + for (argIter = list.begin(), argEnd = list.end(); + argIter != argEnd; ++argIter) + { const options_map::iterator optIter = options.find(*argIter); if (optIter != options.end()) { |