Reduce raw string pointers usage.

* Change some functions to take `std::string` instead of
  `const char*` in the following classes: `cmMakeFile`, `cmake`,
  `cmCoreTryCompile`, `cmSystemTools`,  `cmState`, `cmLocalGenerator`
  and a few others.
* Greatly reduce using of `const char*` overloads for
  `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
* Remove many redundant `c_str()` conversions throughout the code.

1 files changed, 3 insertions, 3 deletions

diff --git a/Source/cmQtAutoGenInitializer.cxx b/Source/cmQtAutoGenInitializer.cxx
index d845e8b..0f3cb23 100644
--- a/Source/cmQtAutoGenInitializer.cxx
+++ b/Source/cmQtAutoGenInitializer.cxx
@@ -169,9 +169,9 @@ static std::string FileProjectRelativePath(cmMakefile* makefile,
   std::string res;
   {
     std::string pSource = cmSystemTools::RelativePath(
-      makefile->GetCurrentSourceDirectory(), fileName.c_str());
+      makefile->GetCurrentSourceDirectory(), fileName);
     std::string pBinary = cmSystemTools::RelativePath(
-      makefile->GetCurrentBinaryDirectory(), fileName.c_str());
+      makefile->GetCurrentBinaryDirectory(), fileName);
     if (pSource.size() < pBinary.size()) {
       res = std::move(pSource);
     } else if (pBinary.size() < fileName.size()) {
@@ -1387,7 +1387,7 @@ bool cmQtAutoGenInitializer::RccListInputs(std::string const& fileName,
                                            std::vector<std::string>& files,
                                            std::string& error)
 {
-  if (!cmSystemTools::FileExists(fileName.c_str())) {
+  if (!cmSystemTools::FileExists(fileName)) {
     error = "rcc resource file does not exist:\n  ";
     error += Quoted(fileName);
     error += "\n";