summaryrefslogtreecommitdiffstats
path: root/Source/cmServerProtocol.cxx
diff options
context:
space:
mode:
authorDaniel Pfeifer <daniel@pfeifer-mail.de>2017-08-15 20:43:08 (GMT)
committerDaniel Pfeifer <daniel@pfeifer-mail.de>2017-08-15 20:43:08 (GMT)
commitcbcf6458f45f1b714487b3d6e1713d6e40e448f0 (patch)
treeb9a1fdf67c68891fd7a0e6beb67395c5e819e613 /Source/cmServerProtocol.cxx
parent91417e4ca39c216c9ca12a3418554ec7c6ba0950 (diff)
downloadCMake-cbcf6458f45f1b714487b3d6e1713d6e40e448f0.zip
CMake-cbcf6458f45f1b714487b3d6e1713d6e40e448f0.tar.gz
CMake-cbcf6458f45f1b714487b3d6e1713d6e40e448f0.tar.bz2
cmServerProtocol: Do not move into json::Value::append()
CMake's copy of json-cpp is not aware of rvalues yet. It is confusing to pass the result of std::move to a function that takes a const& because no move will actually happen. This change may be reverted once CMake upgrades to a new version of json-cpp.
Diffstat (limited to 'Source/cmServerProtocol.cxx')
-rw-r--r--Source/cmServerProtocol.cxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/cmServerProtocol.cxx b/Source/cmServerProtocol.cxx
index 557bee0..baaf11a 100644
--- a/Source/cmServerProtocol.cxx
+++ b/Source/cmServerProtocol.cxx
@@ -747,7 +747,7 @@ static Json::Value DumpBacktrace(const cmListFileBacktrace& backtrace)
if (!backtraceCopy.Top().Name.empty()) {
entry[kNAME_KEY] = backtraceCopy.Top().Name;
}
- result.append(std::move(entry));
+ result.append(entry);
backtraceCopy = backtraceCopy.Pop();
}
return result;