summaryrefslogtreecommitdiffstats
path: root/Source/cmState.h
diff options
context:
space:
mode:
authorDaniel Pfeifer <daniel@pfeifer-mail.de>2016-05-26 19:58:51 (GMT)
committerDaniel Pfeifer <daniel@pfeifer-mail.de>2016-05-26 19:58:51 (GMT)
commit618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (patch)
treeabaabfaae8a9f5448d7ee062c757c61254792995 /Source/cmState.h
parentacd8a73044e879286f0cfa24b54497a8307f204b (diff)
downloadCMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.zip
CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.gz
CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.bz2
Pass arguments that are not modified as const&.
Use clang-tidy's performance-unnecessary-value-param checker to find value parameter declarations of expensive to copy types that are not modified inside the function. Ignore findings in kwsys. After applying the fix-its, manually change `const T&` to `T const&`.
Diffstat (limited to 'Source/cmState.h')
-rw-r--r--Source/cmState.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/cmState.h b/Source/cmState.h
index 7ecac56..18c45b8 100644
--- a/Source/cmState.h
+++ b/Source/cmState.h
@@ -164,9 +164,9 @@ public:
void ClearCompileOptions();
void SetProperty(const std::string& prop, const char* value,
- cmListFileBacktrace lfbt);
+ cmListFileBacktrace const& lfbt);
void AppendProperty(const std::string& prop, const char* value,
- bool asString, cmListFileBacktrace lfbt);
+ bool asString, cmListFileBacktrace const& lfbt);
const char* GetProperty(const std::string& prop) const;
const char* GetProperty(const std::string& prop, bool chain) const;
bool GetPropertyAsBool(const std::string& prop) const;