diff options
author | Florian Jacomme <florian@jacomme.fr> | 2018-05-01 14:17:31 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2018-05-22 14:56:24 (GMT) |
commit | b1a05d6c762ceb6dbf47126a7ddcedadb45e02f5 (patch) | |
tree | 61dd702ca38457507a1b0416e61a1aae350ca90d /Source/cmState.h | |
parent | 743f24bac68010c0157dc0349958e09ed1784f5f (diff) | |
download | CMake-b1a05d6c762ceb6dbf47126a7ddcedadb45e02f5.zip CMake-b1a05d6c762ceb6dbf47126a7ddcedadb45e02f5.tar.gz CMake-b1a05d6c762ceb6dbf47126a7ddcedadb45e02f5.tar.bz2 |
Revise implementation of case-insensitive command names
Store both the as-written and lower-case command names and use
the latter to avoid case-insensitive string comparisons.
With this I obtain 2-6% speed increase (on Windows) for the configure
step with no significant changes in memory usage. A case-insensitive
comparison is a lot slower than just calling `==` because the operator
will use things like memcmp, so prefer the latter.
The `cmSystemTools::LowerCase` function allocates a new string each time
it is called, so before this change we were allocating in:
* cmMakefile::Configure two times for each function
(to look for `cmake_minimum_required` and `project`)
* cmMakefile::ExecuteCommand twice by function by calling
cmState::GetCommand and copying the name
Now we are only allocating once by function instead of four.
Diffstat (limited to 'Source/cmState.h')
-rw-r--r-- | Source/cmState.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Source/cmState.h b/Source/cmState.h index 4c6fc69..38bdfec 100644 --- a/Source/cmState.h +++ b/Source/cmState.h @@ -125,7 +125,11 @@ public: bool GetIsGeneratorMultiConfig() const; void SetIsGeneratorMultiConfig(bool b); + // Returns a command from its name, case insensitive, or nullptr cmCommand* GetCommand(std::string const& name) const; + // Returns a command from its name, or nullptr + cmCommand* GetCommandByExactName(std::string const& name) const; + void AddBuiltinCommand(std::string const& name, cmCommand* command); void AddDisallowedCommand(std::string const& name, cmCommand* command, cmPolicies::PolicyID policy, const char* message); |