diff options
author | Brad King <brad.king@kitware.com> | 2009-10-05 13:06:44 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2009-10-05 13:06:44 (GMT) |
commit | daa2f3aa416b02e4abea0274312a44eca63c5860 (patch) | |
tree | 1d3b07b2338b3be662e55e2b880585933c65d320 /Source/cmTarget.cxx | |
parent | 78f08116287fb534bfb0bc2921fd3f5bac47ce93 (diff) | |
download | CMake-daa2f3aa416b02e4abea0274312a44eca63c5860.zip CMake-daa2f3aa416b02e4abea0274312a44eca63c5860.tar.gz CMake-daa2f3aa416b02e4abea0274312a44eca63c5860.tar.bz2 |
Combine duplicate code in target property methods
In cmTarget::SetProperty and cmTarget::AppendProperty we check whether
changing the property invalidates cached information. The check was
duplicated in the two methods, so this commit moves the check into a
helper method called from both.
Diffstat (limited to 'Source/cmTarget.cxx')
-rw-r--r-- | Source/cmTarget.cxx | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx index 440d5c7..d095879 100644 --- a/Source/cmTarget.cxx +++ b/Source/cmTarget.cxx @@ -2001,13 +2001,7 @@ void cmTarget::SetProperty(const char* prop, const char* value) } this->Properties.SetProperty(prop, value, cmProperty::TARGET); - - // If imported information is being set, wipe out cached - // information. - if(this->IsImported() && strncmp(prop, "IMPORTED", 8) == 0) - { - this->Internal->ImportInfoMap.clear(); - } + this->MaybeInvalidatePropertyCache(prop); } //---------------------------------------------------------------------------- @@ -2018,9 +2012,13 @@ void cmTarget::AppendProperty(const char* prop, const char* value) return; } this->Properties.AppendProperty(prop, value, cmProperty::TARGET); + this->MaybeInvalidatePropertyCache(prop); +} - // If imported information is being set, wipe out cached - // information. +//---------------------------------------------------------------------------- +void cmTarget::MaybeInvalidatePropertyCache(const char* prop) +{ + // Wipe wipe out maps caching information affected by this property. if(this->IsImported() && strncmp(prop, "IMPORTED", 8) == 0) { this->Internal->ImportInfoMap.clear(); |