summaryrefslogtreecommitdiffstats
path: root/Source/cmTarget.h
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2013-07-15 16:47:27 (GMT)
committerBrad King <brad.king@kitware.com>2013-07-15 17:17:29 (GMT)
commit4bb6e24809df6b6443895a5a5c12cb264f5f1489 (patch)
tree7703f7db6532c02606515e49888cb4c863d6b249 /Source/cmTarget.h
parentb5dd80105f79c5296f222368b85d3d211a509b1f (diff)
downloadCMake-4bb6e24809df6b6443895a5a5c12cb264f5f1489.zip
CMake-4bb6e24809df6b6443895a5a5c12cb264f5f1489.tar.gz
CMake-4bb6e24809df6b6443895a5a5c12cb264f5f1489.tar.bz2
VS,Xcode: Drop incorrect legacy dependency trace (#14291)
Drop the "vsProjectFile" argument from cmTarget::TraceDependencies. It appears to be the modern equivalent to a hunk added in commit ba68f771 (...added new custom command support, 2003-06-03): + name = libName; + name += ".dsp.cmake"; + srcFilesToProcess.push(name); but was broken by refactoring at some point. The current behavior tries to trace dependencies on a source file named the same as a target, which makes no sense. Furthermore, in code of the form add_executable(foo foo.c) add_custom_command(OUTPUT "${somewhere}/foo" ... DEPENDS foo) the "vsProjectFile" value "foo" matches source "${somewhere}/foo.rule" generated to hold the custom command and causes the command to be added to the "foo" target incorrectly. Simply drop the incorrect source file trace and supporting logic.
Diffstat (limited to 'Source/cmTarget.h')
-rw-r--r--Source/cmTarget.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/cmTarget.h b/Source/cmTarget.h
index 3bc0ab2..62d9fb1 100644
--- a/Source/cmTarget.h
+++ b/Source/cmTarget.h
@@ -341,7 +341,7 @@ public:
* Trace through the source files in this target and add al source files
* that they depend on, used by all generators
*/
- void TraceDependencies(const char* vsProjectFile);
+ void TraceDependencies();
/**
* Make sure the full path to all source files is known.