Reduce raw string pointers usage.

* Change some functions to take `std::string` instead of
  `const char*` in the following classes: `cmMakeFile`, `cmake`,
  `cmCoreTryCompile`, `cmSystemTools`,  `cmState`, `cmLocalGenerator`
  and a few others.
* Greatly reduce using of `const char*` overloads for
  `cmSystemTools::MakeDirectory` and `cmSystemTools::RelativePath`.
* Remove many redundant `c_str()` conversions throughout the code.

1 files changed, 1 insertions, 1 deletions

diff --git a/Source/cmTargetCompileDefinitionsCommand.cxx b/Source/cmTargetCompileDefinitionsCommand.cxx
index bd4121d..4e716dc 100644
--- a/Source/cmTargetCompileDefinitionsCommand.cxx
+++ b/Source/cmTargetCompileDefinitionsCommand.cxx
@@ -33,7 +33,7 @@ std::string cmTargetCompileDefinitionsCommand::Join(
   std::string defs;
   std::string sep;
   for (std::string const& it : content) {
-    if (cmHasLiteralPrefix(it.c_str(), "-D")) {
+    if (cmHasLiteralPrefix(it, "-D")) {
       defs += sep + it.substr(2);
     } else {
       defs += sep + it;