diff options
author | Stephen Kelly <steveire@gmail.com> | 2013-01-21 11:28:27 (GMT) |
---|---|---|
committer | Stephen Kelly <steveire@gmail.com> | 2013-01-21 11:32:46 (GMT) |
commit | b98d14d40016efee420bee26b9795880fdf6a5f8 (patch) | |
tree | 7226b6db415fb92680bbefcebf205a21b6175f3f /Source/cmTargetCompileDefinitionsCommand.cxx | |
parent | 48a4cf21825c9ed5f53ac25d5f4577baaf92d1f7 (diff) | |
download | CMake-b98d14d40016efee420bee26b9795880fdf6a5f8.zip CMake-b98d14d40016efee420bee26b9795880fdf6a5f8.tar.gz CMake-b98d14d40016efee420bee26b9795880fdf6a5f8.tar.bz2 |
Disallow porcelain to populate includes and defines of IMPORTED targets.
With similar reasoning to the parent commit, as downstreams, we can't
determine what $<CONFIG> generator expressions would be appropriate.
Upstream would have populated the INTERFACE_INCLUDE_DIRECTORIES with
config-specific generator expressions, possibly appropriate for
their DEBUG_CONFIGURATIONS. In theory, if we would add include
directories for a DEBUG intent, we would have to match the upstream
configurations for that.
Rather than attempting to discover the appropriate configurations
at this time, simplify the feature instead. The use of IMPORTED targets
with these commands could still be added in the future if targets
would export their DEBUG_CONFIGURATIONS somehow.
Diffstat (limited to 'Source/cmTargetCompileDefinitionsCommand.cxx')
-rw-r--r-- | Source/cmTargetCompileDefinitionsCommand.cxx | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/Source/cmTargetCompileDefinitionsCommand.cxx b/Source/cmTargetCompileDefinitionsCommand.cxx index 492a1b7..683eff6 100644 --- a/Source/cmTargetCompileDefinitionsCommand.cxx +++ b/Source/cmTargetCompileDefinitionsCommand.cxx @@ -20,13 +20,11 @@ bool cmTargetCompileDefinitionsCommand } void cmTargetCompileDefinitionsCommand -::HandleImportedTargetInvalidScope(const std::string &scope, - const std::string &tgt) +::HandleImportedTarget(const std::string &tgt) { cmOStringStream e; - e << "Cannot specify " << scope << " compile definitions for imported " - "target \"" << tgt << "\". Compile definitions can only be " - "specified for an imported target in the INTERFACE mode."; + e << "Cannot specify compile definitions for imported target \"" + << tgt << "\"."; this->Makefile->IssueMessage(cmake::FATAL_ERROR, e.str()); } |