summaryrefslogtreecommitdiffstats
path: root/Source/cmVariableWatch.cxx
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2016-03-24 12:49:46 (GMT)
committerCMake Topic Stage <kwrobot@kitware.com>2016-03-24 12:49:46 (GMT)
commit6d36fc8341aa7361a5786e78a19d9bab71ee42d2 (patch)
tree0145426406b5fbdb0254dfbd80880f6659f1dc7e /Source/cmVariableWatch.cxx
parent917d49ed93b7b43ac3508dbd81f0645433880724 (diff)
parentc61040282557ba268e144ffa5e2d1935b5991d8d (diff)
downloadCMake-6d36fc8341aa7361a5786e78a19d9bab71ee42d2.zip
CMake-6d36fc8341aa7361a5786e78a19d9bab71ee42d2.tar.gz
CMake-6d36fc8341aa7361a5786e78a19d9bab71ee42d2.tar.bz2
Merge topic 'fix-variable_watch-reallocation'
c6104028 Avoid occasional use-after-free when a variable watch is executed
Diffstat (limited to 'Source/cmVariableWatch.cxx')
-rw-r--r--Source/cmVariableWatch.cxx4
1 files changed, 3 insertions, 1 deletions
diff --git a/Source/cmVariableWatch.cxx b/Source/cmVariableWatch.cxx
index 57dde31..a200718 100644
--- a/Source/cmVariableWatch.cxx
+++ b/Source/cmVariableWatch.cxx
@@ -96,7 +96,7 @@ void cmVariableWatch::RemoveWatch(const std::string& variable,
}
}
-void cmVariableWatch::VariableAccessed(const std::string& variable,
+bool cmVariableWatch::VariableAccessed(const std::string& variable,
int access_type,
const char* newValue,
const cmMakefile* mf) const
@@ -112,5 +112,7 @@ void cmVariableWatch::VariableAccessed(const std::string& variable,
(*it)->Method(variable, access_type, (*it)->ClientData,
newValue, mf);
}
+ return true;
}
+ return false;
}