diff options
| author | Matthias Maennich <matthias@maennich.net> | 2017-09-19 13:54:08 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2017-09-28 11:23:40 (GMT) |
| commit | bb0ad1bea81f60cbbb2c66c2c0ab24ee12db0026 (patch) | |
| tree | 06db4eb05a227219eef3e265fef60f601640d051 /Source/cmXCodeScheme.cxx | |
| parent | 8cc33aeaec2798c9ff5a3af23e361ee22fa2ba95 (diff) | |
| download | CMake-bb0ad1bea81f60cbbb2c66c2c0ab24ee12db0026.zip CMake-bb0ad1bea81f60cbbb2c66c2c0ab24ee12db0026.tar.gz CMake-bb0ad1bea81f60cbbb2c66c2c0ab24ee12db0026.tar.bz2 | |
Fix some occurrences using string by value rather than by const&
Fix issues diagnosed by clang-tidy
- performance-unnecessary-value-param
- performance-unnecessary-copy-initialization
Signed-off-by: Matthias Maennich <matthias@maennich.net>
Diffstat (limited to 'Source/cmXCodeScheme.cxx')
| -rw-r--r-- | Source/cmXCodeScheme.cxx | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/Source/cmXCodeScheme.cxx b/Source/cmXCodeScheme.cxx index f460365..98e814b 100644 --- a/Source/cmXCodeScheme.cxx +++ b/Source/cmXCodeScheme.cxx @@ -91,7 +91,7 @@ void cmXCodeScheme::WriteBuildAction(cmXMLWriter& xout, } void cmXCodeScheme::WriteTestAction(cmXMLWriter& xout, - std::string configuration, + const std::string& configuration, const std::string& container) { xout.StartElement("TestAction"); @@ -127,7 +127,7 @@ void cmXCodeScheme::WriteTestAction(cmXMLWriter& xout, } void cmXCodeScheme::WriteLaunchAction(cmXMLWriter& xout, - std::string configuration, + const std::string& configuration, const std::string& container) { xout.StartElement("LaunchAction"); @@ -164,7 +164,7 @@ void cmXCodeScheme::WriteLaunchAction(cmXMLWriter& xout, } void cmXCodeScheme::WriteProfileAction(cmXMLWriter& xout, - std::string configuration) + const std::string& configuration) { xout.StartElement("ProfileAction"); xout.BreakAttributes(); @@ -177,7 +177,7 @@ void cmXCodeScheme::WriteProfileAction(cmXMLWriter& xout, } void cmXCodeScheme::WriteAnalyzeAction(cmXMLWriter& xout, - std::string configuration) + const std::string& configuration) { xout.StartElement("AnalyzeAction"); xout.BreakAttributes(); @@ -186,7 +186,7 @@ void cmXCodeScheme::WriteAnalyzeAction(cmXMLWriter& xout, } void cmXCodeScheme::WriteArchiveAction(cmXMLWriter& xout, - std::string configuration) + const std::string& configuration) { xout.StartElement("ArchiveAction"); xout.BreakAttributes(); |