errors: avoid constructing a stream before getting the last error

Constructing a stream may involve operations that change the global
error state. Avoid the streams by using `cmStrCat` instead.

1 files changed, 2 insertions, 4 deletions

diff --git a/Source/cmake.cxx b/Source/cmake.cxx
index 942c59b..f54196b 100644
--- a/Source/cmake.cxx
+++ b/Source/cmake.cxx
@@ -1707,10 +1707,8 @@ void cmake::SetTraceFile(const std::string& file)
   this->TraceFile.close();
   this->TraceFile.open(file.c_str());
   if (!this->TraceFile) {
-    std::stringstream ss;
-    ss << "Error opening trace file " << file << ": "
-       << cmSystemTools::GetLastSystemError();
-    cmSystemTools::Error(ss.str());
+    cmSystemTools::Error(cmStrCat("Error opening trace file ", file, ": ",
+                                  cmSystemTools::GetLastSystemError()));
     return;
   }
   std::cout << "Trace will be written to " << file << '\n';