BUG: CopyFileIfDifferent should return success if the files did not differ or if the copy succeeded. It should return failure only if the files were different and the copy failed.

1 files changed, 3 insertions, 4 deletions

diff --git a/Source/kwsys/SystemTools.cxx b/Source/kwsys/SystemTools.cxx
index d525be3..825e27e 100644
--- a/Source/kwsys/SystemTools.cxx
+++ b/Source/kwsys/SystemTools.cxx
@@ -816,14 +816,13 @@ kwsys_stl::string SystemTools::ConvertToWindowsOutputPath(const char* path)
 }
 
 bool SystemTools::CopyFileIfDifferent(const char* source,
-                                        const char* destination)
+                                      const char* destination)
 {
   if(SystemTools::FilesDiffer(source, destination))
     {
-    SystemTools::CopyFileAlways(source, destination);
-    return true;
+    return SystemTools::CopyFileAlways(source, destination);
     }
-  return false;
+  return true;
 }