diff options
| author | Brad King <brad.king@kitware.com> | 2020-06-10 13:05:56 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2020-06-12 09:04:56 (GMT) |
| commit | cc02ced530a40f98c7bf643cd91e4b811a0e3f7a (patch) | |
| tree | 09708fbba7fbb556f43f823c33a3859be29f06e9 /Source | |
| parent | 596cfd26809793c7165b5e5047be133e0419c6e5 (diff) | |
| download | CMake-cc02ced530a40f98c7bf643cd91e4b811a0e3f7a.zip CMake-cc02ced530a40f98c7bf643cd91e4b811a0e3f7a.tar.gz CMake-cc02ced530a40f98c7bf643cd91e4b811a0e3f7a.tar.bz2 | |
find_program: Revert "Find programs that are executable but not readable"
The fix in commit 86e6349ef7 (find_program: Find programs that are
executable but not readable, 2020-04-04, v3.18.0-rc1~372^2) can break
existing projects that were (likely accidentally) relying on the
old behavior to find files that are readable but not executable.
Revert the fix for now. We can re-introduce it with a policy later.
Instead of reverting the test case, update it to cover the old behavior.
That can serve as a reference for testing the policy when introduced.
Fixes: #20814
Issue: #10468
Diffstat (limited to 'Source')
| -rw-r--r-- | Source/cmFindProgramCommand.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Source/cmFindProgramCommand.cxx b/Source/cmFindProgramCommand.cxx index 599b1d2..4b88bea 100644 --- a/Source/cmFindProgramCommand.cxx +++ b/Source/cmFindProgramCommand.cxx @@ -85,7 +85,7 @@ struct cmFindProgramHelper this->TestNameExt = cmStrCat(name, ext); this->TestPath = cmSystemTools::CollapseFullPath(this->TestNameExt, path); - bool exists = cmSystemTools::FileIsExecutable(this->TestPath); + bool exists = cmSystemTools::FileExists(this->TestPath, true); exists ? this->DebugSearches.FoundAt(this->TestPath) : this->DebugSearches.FailedAt(this->TestPath); if (exists) { |