summaryrefslogtreecommitdiffstats
path: root/Source
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2020-05-15 12:20:34 (GMT)
committerBrad King <brad.king@kitware.com>2020-05-15 12:26:43 (GMT)
commita9f4f58f0c3837549c41479a177c864d3cfcf760 (patch)
tree55f83cb9b1a1cb6fbef5b9fd61206cedb85ca99b /Source
parent4c82f309c59d02899145bc25c0e9efc91a6f64ed (diff)
downloadCMake-a9f4f58f0c3837549c41479a177c864d3cfcf760.zip
CMake-a9f4f58f0c3837549c41479a177c864d3cfcf760.tar.gz
CMake-a9f4f58f0c3837549c41479a177c864d3cfcf760.tar.bz2
cmGeneratorTarget: Clear AllConfigSources in ClearSourcesCache
In commit 40aa6c059c (cmGeneratorTarget: Add method to collect all sources for all configs, 2017-04-10, v3.9.0-rc1~268^2~5) we forgot to update `ClearSourcesCache` to also clear `AllConfigSources`. This leads to subtle cases where code paths like PCH handling that add sources during generation break depending on ordering. Suggested-by: Christian Fersch Fixes: #20712, #20702
Diffstat (limited to 'Source')
-rw-r--r--Source/cmGeneratorTarget.cxx1
1 files changed, 1 insertions, 0 deletions
diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index 171c3ed..cde91c9 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -652,6 +652,7 @@ const char* cmGeneratorTarget::GetFileSuffixInternal(
void cmGeneratorTarget::ClearSourcesCache()
{
+ this->AllConfigSources.clear();
this->KindedSourcesMap.clear();
this->LinkImplementationLanguageIsContextDependent = true;
this->Objects.clear();