diff options
author | Brad King <brad.king@kitware.com> | 2008-08-18 15:26:51 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2008-08-18 15:26:51 (GMT) |
commit | 0bf093fd172951a8da7fc892da95c5c37a3354e2 (patch) | |
tree | 8ea5e9b78a0b9eb4a87959961b55baaef0dedf0f /Source | |
parent | 94c1fe83fd1ef121f592554df0dedda5416afeba (diff) | |
download | CMake-0bf093fd172951a8da7fc892da95c5c37a3354e2.zip CMake-0bf093fd172951a8da7fc892da95c5c37a3354e2.tar.gz CMake-0bf093fd172951a8da7fc892da95c5c37a3354e2.tar.bz2 |
STYLE: Convert unused target type cases to default
In switch statements that deal with only a few target types, use a
'default' case for the remaining target types instead of listing them
explicitly. This will make it easier to add more types in the future.
Diffstat (limited to 'Source')
-rw-r--r-- | Source/cmLocalGenerator.cxx | 12 | ||||
-rw-r--r-- | Source/cmTarget.cxx | 18 |
2 files changed, 5 insertions, 25 deletions
diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx index 35e14ff..064cfb5 100644 --- a/Source/cmLocalGenerator.cxx +++ b/Source/cmLocalGenerator.cxx @@ -723,11 +723,7 @@ void cmLocalGenerator } } break; - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } } @@ -1441,11 +1437,7 @@ void cmLocalGenerator::GetTargetFlags(std::string& linkLibs, } } break; - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } } diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx index 7d49a0a..caa534f 100644 --- a/Source/cmTarget.cxx +++ b/Source/cmTarget.cxx @@ -2043,11 +2043,7 @@ const char* cmTarget::GetCreateRuleVariable() return "_CREATE_SHARED_MODULE"; case cmTarget::EXECUTABLE: return "_LINK_EXECUTABLE"; - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } return ""; @@ -2073,11 +2069,7 @@ const char* cmTarget::GetSuffixVariableInternal(TargetType type, return (implib ? "CMAKE_IMPORT_LIBRARY_SUFFIX" : "CMAKE_EXECUTABLE_SUFFIX"); - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } return ""; @@ -2102,11 +2094,7 @@ const char* cmTarget::GetPrefixVariableInternal(TargetType type, : "CMAKE_SHARED_MODULE_PREFIX"); case cmTarget::EXECUTABLE: return (implib? "CMAKE_IMPORT_LIBRARY_PREFIX" : ""); - case cmTarget::UTILITY: - case cmTarget::GLOBAL_TARGET: - case cmTarget::INSTALL_FILES: - case cmTarget::INSTALL_PROGRAMS: - case cmTarget::INSTALL_DIRECTORY: + default: break; } return ""; |