diff options
author | Stephen Kelly <steveire@gmail.com> | 2015-04-04 17:21:56 (GMT) |
---|---|---|
committer | Stephen Kelly <steveire@gmail.com> | 2015-07-18 12:10:34 (GMT) |
commit | 4efda261fead9f677144ffc6bc2b612a1d1dbcb6 (patch) | |
tree | 789865bb79d93c02d1fe5af87b54a7df29551236 /Source | |
parent | 52f22616852e6a6e8f642f84fa821e0c8678a679 (diff) | |
download | CMake-4efda261fead9f677144ffc6bc2b612a1d1dbcb6.zip CMake-4efda261fead9f677144ffc6bc2b612a1d1dbcb6.tar.gz CMake-4efda261fead9f677144ffc6bc2b612a1d1dbcb6.tar.bz2 |
cmMakefile: Remove special handling of INCLUDE_REGULAR_EXPRESSION.
It costs an extra cmMakefile member and extra code to maintain in
directory property handling. Remove documentation note that it
is read-only and specify high-level command to populate it.
Diffstat (limited to 'Source')
-rw-r--r-- | Source/cmMakeDepend.cxx | 2 | ||||
-rw-r--r-- | Source/cmMakefile.cxx | 14 | ||||
-rw-r--r-- | Source/cmMakefile.h | 5 |
3 files changed, 4 insertions, 17 deletions
diff --git a/Source/cmMakeDepend.cxx b/Source/cmMakeDepend.cxx index a6d4e58..cbc7e02 100644 --- a/Source/cmMakeDepend.cxx +++ b/Source/cmMakeDepend.cxx @@ -49,7 +49,7 @@ void cmMakeDepend::SetMakefile(cmMakefile* makefile) // Now extract the include file regular expression from the makefile. this->IncludeFileRegularExpression.compile( - this->Makefile->IncludeFileRegularExpression.c_str()); + this->Makefile->GetIncludeRegularExpression()); this->ComplainFileRegularExpression.compile( this->Makefile->ComplainFileRegularExpression.c_str()); diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx index 07c2fd1..155c306 100644 --- a/Source/cmMakefile.cxx +++ b/Source/cmMakefile.cxx @@ -150,7 +150,7 @@ cmMakefile::cmMakefile(cmLocalGenerator* localGenerator) this->SuppressWatches = false; // Setup the default include file regular expression (match everything). - this->IncludeFileRegularExpression = "^.*$"; + this->SetProperty("INCLUDE_REGULAR_EXPRESSION", "^.*$"); // Setup the default include complaint regular expression (match nothing). this->ComplainFileRegularExpression = "^$"; // Source and header file extensions that we can handle @@ -1613,7 +1613,6 @@ void cmMakefile::InitializeFromParent(cmMakefile* parent) this->ProjectName = parent->ProjectName; // Copy include regular expressions. - this->IncludeFileRegularExpression = parent->IncludeFileRegularExpression; this->ComplainFileRegularExpression = parent->ComplainFileRegularExpression; // Imported targets. @@ -4193,12 +4192,6 @@ void cmMakefile::SetProperty(const std::string& prop, const char* value) return; } - if ( prop == "INCLUDE_REGULAR_EXPRESSION" ) - { - this->SetIncludeRegularExpression(value); - return; - } - this->Properties.SetProperty(prop, value); } @@ -4265,11 +4258,6 @@ const char *cmMakefile::GetProperty(const std::string& prop, } return ""; } - else if (prop == "INCLUDE_REGULAR_EXPRESSION" ) - { - output = this->GetIncludeRegularExpression(); - return output.c_str(); - } else if (prop == "LISTFILE_STACK") { output = cmJoin(this->ListFileStack, ";"); diff --git a/Source/cmMakefile.h b/Source/cmMakefile.h index 82a2279..585880e 100644 --- a/Source/cmMakefile.h +++ b/Source/cmMakefile.h @@ -387,11 +387,11 @@ public: */ void SetIncludeRegularExpression(const char* regex) { - this->IncludeFileRegularExpression = regex; + this->SetProperty("INCLUDE_REGULAR_EXPRESSION", regex); } const char* GetIncludeRegularExpression() const { - return this->IncludeFileRegularExpression.c_str(); + return this->GetProperty("INCLUDE_REGULAR_EXPRESSION"); } /** @@ -873,7 +873,6 @@ protected: std::vector<cmInstallGenerator*> InstallGenerators; std::vector<cmTestGenerator*> TestGenerators; - std::string IncludeFileRegularExpression; std::string ComplainFileRegularExpression; std::vector<std::string> SourceFileExtensions; std::vector<std::string> HeaderFileExtensions; |