diff options
author | Brad King <brad.king@kitware.com> | 2022-03-22 12:55:09 (GMT) |
---|---|---|
committer | Kitware Robot <kwrobot@kitware.com> | 2022-03-22 12:55:15 (GMT) |
commit | bbfc6215aa862b23535197cf65f34ac7ad7c2ac6 (patch) | |
tree | dfa4c78b66ecb1489de0823ecf5bbdc72f593749 /Source | |
parent | cc89ae3225001043b57ddfd30c982340b6d517e3 (diff) | |
parent | 87c3b5e421b3f39d52caa113da4b577c6b68fa03 (diff) | |
download | CMake-bbfc6215aa862b23535197cf65f34ac7ad7c2ac6.zip CMake-bbfc6215aa862b23535197cf65f34ac7ad7c2ac6.tar.gz CMake-bbfc6215aa862b23535197cf65f34ac7ad7c2ac6.tar.bz2 |
Merge topic 'cleanup-define_property'
87c3b5e421 define_property(): Only test prefix if INITIALIZE_FROM_VARIABLE is given
9b50f221f6 Help: Update the main purpose of define_property()
e993e2c52c Help: Clean up INITIALIZE_FROM_VARIABLE define_property() option
Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Acked-by: Kyle Edwards <kyle.edwards@kitware.com>
Merge-request: !7090
Diffstat (limited to 'Source')
-rw-r--r-- | Source/cmDefinePropertyCommand.cxx | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/Source/cmDefinePropertyCommand.cxx b/Source/cmDefinePropertyCommand.cxx index 7a2f34f..15b2652 100644 --- a/Source/cmDefinePropertyCommand.cxx +++ b/Source/cmDefinePropertyCommand.cxx @@ -97,20 +97,20 @@ bool cmDefinePropertyCommand(std::vector<std::string> const& args, PropertyName, "\"")); return false; } - } - // Make sure the variable is not reserved. - static constexpr const char* reservedPrefixes[] = { - "CMAKE_", - "_CMAKE_", - }; - if (std::any_of(std::begin(reservedPrefixes), std::end(reservedPrefixes), - [&initializeFromVariable](const char* prefix) { - return cmHasPrefix(initializeFromVariable, prefix); - })) { - status.SetError( - cmStrCat("variable name \"", initializeFromVariable, "\" is reserved")); - return false; + // Make sure the variable is not reserved. + static constexpr const char* reservedPrefixes[] = { + "CMAKE_", + "_CMAKE_", + }; + if (std::any_of(std::begin(reservedPrefixes), std::end(reservedPrefixes), + [&initializeFromVariable](const char* prefix) { + return cmHasPrefix(initializeFromVariable, prefix); + })) { + status.SetError(cmStrCat("variable name \"", initializeFromVariable, + "\" is reserved")); + return false; + } } // Actually define the property. |