summaryrefslogtreecommitdiffstats
path: root/Source
diff options
context:
space:
mode:
authorKyle Edwards <kyle.edwards@kitware.com>2022-04-06 20:40:34 (GMT)
committerBrad King <brad.king@kitware.com>2022-04-07 13:26:58 (GMT)
commitf779f8c0ad4c16cda5a166d440915a01e986d396 (patch)
treebd82cc9e14e10efdb88e7e277642089ee1e73d10 /Source
parent42bca07cc67d42cbc37109a9be208321e7ebc620 (diff)
downloadCMake-f779f8c0ad4c16cda5a166d440915a01e986d396.zip
CMake-f779f8c0ad4c16cda5a166d440915a01e986d396.tar.gz
CMake-f779f8c0ad4c16cda5a166d440915a01e986d396.tar.bz2
FILE_SET: Forbid adding header sets to Apple FRAMEWORK libraries
The feature needs a specialized implementation to place headers in the right place inside frameworks. To avoid silently doing the wrong thing, make this case an error for the 3.23 series. Issue: #23386
Diffstat (limited to 'Source')
-rw-r--r--Source/cmTargetSourcesCommand.cxx4
1 files changed, 4 insertions, 0 deletions
diff --git a/Source/cmTargetSourcesCommand.cxx b/Source/cmTargetSourcesCommand.cxx
index 43a9b3a..9173a34 100644
--- a/Source/cmTargetSourcesCommand.cxx
+++ b/Source/cmTargetSourcesCommand.cxx
@@ -230,6 +230,10 @@ bool TargetSourcesImpl::HandleOneFileSet(
this->SetError("FILE_SETs may not be added to custom targets");
return false;
}
+ if (this->Target->IsFrameworkOnApple()) {
+ this->SetError("FILE_SETs may not be added to FRAMEWORK targets");
+ return false;
+ }
bool const isDefault = args.Type == args.FileSet ||
(args.Type.empty() && args.FileSet[0] >= 'A' && args.FileSet[0] <= 'Z');