diff options
| author | Ben Boeckel <ben.boeckel@kitware.com> | 2022-11-22 19:16:11 (GMT) |
|---|---|---|
| committer | Ben Boeckel <ben.boeckel@kitware.com> | 2022-11-29 17:39:45 (GMT) |
| commit | 27f5ce07cc4093e5e46e931df633ba9fc74238d6 (patch) | |
| tree | 34d609dbe8d10ab7c04aaf29553638cfeda92b49 /Source | |
| parent | 9e81a9b45c0d084b7694065fa7f5c8e79f8161b6 (diff) | |
| download | CMake-27f5ce07cc4093e5e46e931df633ba9fc74238d6.zip CMake-27f5ce07cc4093e5e46e931df633ba9fc74238d6.tar.gz CMake-27f5ce07cc4093e5e46e931df633ba9fc74238d6.tar.bz2 | |
clang-tidy: fix `performance-unnecessary-value-param` lints
Diffstat (limited to 'Source')
| -rw-r--r-- | Source/cmGlobalVisualStudioGenerator.cxx | 2 | ||||
| -rw-r--r-- | Source/cmLocalVisualStudio7Generator.cxx | 2 | ||||
| -rw-r--r-- | Source/cmLocalVisualStudio7Generator.h | 2 | ||||
| -rw-r--r-- | Source/cmVisualStudio10TargetGenerator.cxx | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/Source/cmGlobalVisualStudioGenerator.cxx b/Source/cmGlobalVisualStudioGenerator.cxx index 2987360..dd4b2a7 100644 --- a/Source/cmGlobalVisualStudioGenerator.cxx +++ b/Source/cmGlobalVisualStudioGenerator.cxx @@ -958,7 +958,7 @@ void cmGlobalVisualStudioGenerator::AddSymbolExportCommand( commands.push_back(std::move(command)); } -static bool OpenSolution(std::string sln) +static bool OpenSolution(std::string const& sln) { HRESULT comInitialized = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED | COINIT_DISABLE_OLE1DDE); diff --git a/Source/cmLocalVisualStudio7Generator.cxx b/Source/cmLocalVisualStudio7Generator.cxx index acff990..28e8854 100644 --- a/Source/cmLocalVisualStudio7Generator.cxx +++ b/Source/cmLocalVisualStudio7Generator.cxx @@ -953,7 +953,7 @@ void cmLocalVisualStudio7Generator::WriteConfiguration( } std::string cmLocalVisualStudio7Generator::GetBuildTypeLinkerFlags( - std::string rootLinkerFlags, const std::string& configName) + std::string const& rootLinkerFlags, const std::string& configName) { std::string configTypeUpper = cmSystemTools::UpperCase(configName); std::string extraLinkOptionsBuildTypeDef = diff --git a/Source/cmLocalVisualStudio7Generator.h b/Source/cmLocalVisualStudio7Generator.h index a545be4..ce1156f 100644 --- a/Source/cmLocalVisualStudio7Generator.h +++ b/Source/cmLocalVisualStudio7Generator.h @@ -97,7 +97,7 @@ protected: private: using Options = cmVS7GeneratorOptions; using FCInfo = cmLocalVisualStudio7GeneratorFCInfo; - std::string GetBuildTypeLinkerFlags(std::string rootLinkerFlags, + std::string GetBuildTypeLinkerFlags(std::string const& rootLinkerFlags, const std::string& configName); void FixGlobalTargets(); void WriteVCProjHeader(std::ostream& fout, const std::string& libName, diff --git a/Source/cmVisualStudio10TargetGenerator.cxx b/Source/cmVisualStudio10TargetGenerator.cxx index 810e587..b14069d 100644 --- a/Source/cmVisualStudio10TargetGenerator.cxx +++ b/Source/cmVisualStudio10TargetGenerator.cxx @@ -200,7 +200,7 @@ struct cmVisualStudio10TargetGenerator::OptionsHelper } }; -static std::string cmVS10EscapeComment(std::string comment) +static std::string cmVS10EscapeComment(std::string const& comment) { // MSBuild takes the CDATA of a <Message></Message> element and just // does "echo $CDATA" with no escapes. We must encode the string. |