diff options
| author | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 19:58:51 (GMT) |
|---|---|---|
| committer | Daniel Pfeifer <daniel@pfeifer-mail.de> | 2016-05-26 19:58:51 (GMT) |
| commit | 618fb23fc9838d344e2033c64bfc1a3a55bb7f61 (patch) | |
| tree | abaabfaae8a9f5448d7ee062c757c61254792995 /Tests/CMakeLib | |
| parent | acd8a73044e879286f0cfa24b54497a8307f204b (diff) | |
| download | CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.zip CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.gz CMake-618fb23fc9838d344e2033c64bfc1a3a55bb7f61.tar.bz2 | |
Pass arguments that are not modified as const&.
Use clang-tidy's performance-unnecessary-value-param checker to find
value parameter declarations of expensive to copy types that are not
modified inside the function. Ignore findings in kwsys.
After applying the fix-its, manually change `const T&` to `T const&`.
Diffstat (limited to 'Tests/CMakeLib')
| -rw-r--r-- | Tests/CMakeLib/testRST.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Tests/CMakeLib/testRST.cxx b/Tests/CMakeLib/testRST.cxx index a575d0d..e5a96c2 100644 --- a/Tests/CMakeLib/testRST.cxx +++ b/Tests/CMakeLib/testRST.cxx @@ -13,7 +13,7 @@ #include "cmSystemTools.h" -void reportLine(std::ostream& os, bool ret, std::string line, bool eol) +void reportLine(std::ostream& os, bool ret, std::string const& line, bool eol) { if (ret) { os << "\"" << line << "\" (" << (eol ? "with EOL" : "without EOL") << ")"; |