find_(library|file|path): Drop PATH-derived search prefixes

Since commit ffc06c1239 (Teach find_(library|file|path) to get prefixes
from PATH, 2015-02-18, v3.3.0-rc1~430^2) we search in `<prefix>/include`
and `<prefix>/lib` directories for prefixes with `bin` directories in
the `PATH` environment variable.  The motivation was to search the
installation prefixes of MSYS and MinGW development environments
automatically.

This behavior can search undesired prefixes that happen to be in the
`PATH` for unrelated reasons.  It was reverted for non-Windows hosts
within a year by commit b30b32a493 (Drop find_(library|file|path)
prefixes from PATH on non-Windows, 2016-05-09, v3.6.0-rc1~82^2) but was
kept on Windows hosts to support its motivating use case.  However,
similar problems have since been observed on Windows.  For example,
commit 955d6245c1 (MSVC: Revert "Teach find_library to consider the
'libfoo.a' naming convention", 2022-11-28, v3.25.1~6^2) was primarily
due to undesired discovery of libraries in `PATH`-derived prefixes.

Since commit 5e5132e1b1 (MinGW: Search for packages in standard MSYSTEM
environment prefixes, 2023-09-11) we search MSYS and MinGW environments'
prefixes explicitly, so `PATH`-derived prefixes are no longer needed for
the original motivating use case.

Fixes: #24216

9 files changed, 0 insertions, 66 deletions

diff --git a/Tests/RunCMake/find_path/FromPATHEnv-stdout-cygwin.txt b/Tests/RunCMake/find_path/FromPATHEnv-stdout-cygwin.txt
deleted file mode 100644
index 8f3e7ca..0000000
--- a/Tests/RunCMake/find_path/FromPATHEnv-stdout-cygwin.txt
+++ /dev/null
@@ -1,9 +0,0 @@
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
diff --git a/Tests/RunCMake/find_path/FromPATHEnv-stdout-msys.txt b/Tests/RunCMake/find_path/FromPATHEnv-stdout-msys.txt
deleted file mode 100644
index 8f3e7ca..0000000
--- a/Tests/RunCMake/find_path/FromPATHEnv-stdout-msys.txt
+++ /dev/null
@@ -1,9 +0,0 @@
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
diff --git a/Tests/RunCMake/find_path/FromPATHEnv-stdout-windows.txt b/Tests/RunCMake/find_path/FromPATHEnv-stdout-windows.txt
deleted file mode 100644
index 8f3e7ca..0000000
--- a/Tests/RunCMake/find_path/FromPATHEnv-stdout-windows.txt
+++ /dev/null
@@ -1,9 +0,0 @@
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH-NOTFOUND'
diff --git a/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-cygwin.txt b/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-cygwin.txt
deleted file mode 100644
index a502d78..0000000
--- a/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-cygwin.txt
+++ /dev/null
@@ -1,9 +0,0 @@
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH=''
--- PATH_IN_ENV_PATH=''
--- PATH_IN_ENV_PATH=''
diff --git a/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-msys.txt b/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-msys.txt
deleted file mode 100644
index a502d78..0000000
--- a/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-msys.txt
+++ /dev/null
@@ -1,9 +0,0 @@
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH=''
--- PATH_IN_ENV_PATH=''
--- PATH_IN_ENV_PATH=''
diff --git a/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-windows.txt b/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-windows.txt
deleted file mode 100644
index a502d78..0000000
--- a/Tests/RunCMake/find_path/FromPATHEnvDebugVar-stdout-windows.txt
+++ /dev/null
@@ -1,9 +0,0 @@
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='.*/Tests/RunCMake/find_path/include'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH='PATH_IN_ENV_PATH_A-NOTFOUND'
--- PATH_IN_ENV_PATH=''
--- PATH_IN_ENV_PATH=''
--- PATH_IN_ENV_PATH=''
diff --git a/Tests/RunCMake/find_path/PrefixInPATH-stdout-cygwin.txt b/Tests/RunCMake/find_path/PrefixInPATH-stdout-cygwin.txt
deleted file mode 100644
index bb2ceb7..0000000
--- a/Tests/RunCMake/find_path/PrefixInPATH-stdout-cygwin.txt
+++ /dev/null
@@ -1,4 +0,0 @@
--- PrefixInPATH_INCLUDE_DIR='PrefixInPATH_INCLUDE_DIR-NOTFOUND'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
diff --git a/Tests/RunCMake/find_path/PrefixInPATH-stdout-msys.txt b/Tests/RunCMake/find_path/PrefixInPATH-stdout-msys.txt
deleted file mode 100644
index bb2ceb7..0000000
--- a/Tests/RunCMake/find_path/PrefixInPATH-stdout-msys.txt
+++ /dev/null
@@ -1,4 +0,0 @@
--- PrefixInPATH_INCLUDE_DIR='PrefixInPATH_INCLUDE_DIR-NOTFOUND'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
diff --git a/Tests/RunCMake/find_path/PrefixInPATH-stdout-windows.txt b/Tests/RunCMake/find_path/PrefixInPATH-stdout-windows.txt
deleted file mode 100644
index bb2ceb7..0000000
--- a/Tests/RunCMake/find_path/PrefixInPATH-stdout-windows.txt
+++ /dev/null
@@ -1,4 +0,0 @@
--- PrefixInPATH_INCLUDE_DIR='PrefixInPATH_INCLUDE_DIR-NOTFOUND'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'
--- PrefixInPATH_INCLUDE_DIR='.*/Tests/RunCMake/find_path/include'