diff options
| author | Brad King <brad.king@kitware.com> | 2016-02-17 18:34:15 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2016-02-17 19:01:11 (GMT) |
| commit | 87f44b7525ebc9761b32b98f0c9e1276431e6ec1 (patch) | |
| tree | bc9f85d94b060bcb9dc4765e94646959a9376e5b /Tests/RunCMake/target_link_libraries/StaticPrivateDepNotTarget.cmake | |
| parent | a5a5a6857241c21d306661d723b749839f4c6e1a (diff) | |
| download | CMake-87f44b7525ebc9761b32b98f0c9e1276431e6ec1.zip CMake-87f44b7525ebc9761b32b98f0c9e1276431e6ec1.tar.gz CMake-87f44b7525ebc9761b32b98f0c9e1276431e6ec1.tar.bz2 | |
Fix export of STATIC library PRIVATE non-target dependencies
In commit v3.5.0-rc1~43^2 (Fix export of STATIC library PRIVATE
dependencies with CMP0022 NEW, 2016-01-15) we taught
target_link_libraries to generate `$<LINK_ONLY:$<TARGET_NAME:dep>>` in
INTERFACE_LINK_LIBRARIES instead of `$<LINK_ONLY:dep>` so that `dep` can
be recognized as a target name and updated during export. However, this
approach does not work when `dep` is just a plain library name and not a
target because `$<TARGET_NAME:...>` requires the name of a reachable
target.
Since we do not know during target_link_libraries whether the name will
correspond to a reachable target or not, we cannot inject the
`$<TARGET_NAME:...>` expression. Revert this change and solve the
original problem instead by teaching the export logic to recognize and
update target names directly in `$<LINK_ONLY:...>` expressions.
Reported-by: Ben Boeckel <ben.boeckel@kitware.com>
Diffstat (limited to 'Tests/RunCMake/target_link_libraries/StaticPrivateDepNotTarget.cmake')
| -rw-r--r-- | Tests/RunCMake/target_link_libraries/StaticPrivateDepNotTarget.cmake | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/Tests/RunCMake/target_link_libraries/StaticPrivateDepNotTarget.cmake b/Tests/RunCMake/target_link_libraries/StaticPrivateDepNotTarget.cmake new file mode 100644 index 0000000..7122ae9 --- /dev/null +++ b/Tests/RunCMake/target_link_libraries/StaticPrivateDepNotTarget.cmake @@ -0,0 +1,6 @@ +cmake_policy(SET CMP0022 NEW) +enable_language(C) +add_library(foo STATIC empty.c) +target_link_libraries(foo PRIVATE not_a_target) +install(TARGETS foo EXPORT Exp DESTINATION lib) +install(EXPORT Exp DESTINATION lib/cmake/Exp) |