summaryrefslogtreecommitdiffstats
path: root/Tests/RunCMake
diff options
context:
space:
mode:
authorBen Boeckel <ben.boeckel@kitware.com>2016-07-11 18:52:05 (GMT)
committerBen Boeckel <ben.boeckel@kitware.com>2017-03-16 19:11:03 (GMT)
commit9eb05b48cd8e19988e5a579996598802e2bacdea (patch)
treed75c3af1ccb61939ea1cb16c591c17cbe750ad08 /Tests/RunCMake
parente781223c8887fa2602b40744c67cdc77f972a93b (diff)
downloadCMake-9eb05b48cd8e19988e5a579996598802e2bacdea.zip
CMake-9eb05b48cd8e19988e5a579996598802e2bacdea.tar.gz
CMake-9eb05b48cd8e19988e5a579996598802e2bacdea.tar.bz2
GenerateExportHeader: always fill in _EXPORT macros
The `_EXPORT` and `_NO_EXPORT` macros should always be made properly because the `<LANG>_VISIBILITY_PRESET` properties are controlled independently of this module. One case where this breaks compatibility is where a project was setting `USE_COMPILER_HIDDEN_VISIBILITY=OFF` and then marking a symbol used outside of the library with `_NO_EXPORT` which is a contridiction.
Diffstat (limited to 'Tests/RunCMake')
-rw-r--r--Tests/RunCMake/GenerateExportHeader/GEH.cmake2
1 files changed, 1 insertions, 1 deletions
diff --git a/Tests/RunCMake/GenerateExportHeader/GEH.cmake b/Tests/RunCMake/GenerateExportHeader/GEH.cmake
index cddba29..e0677a7 100644
--- a/Tests/RunCMake/GenerateExportHeader/GEH.cmake
+++ b/Tests/RunCMake/GenerateExportHeader/GEH.cmake
@@ -110,7 +110,7 @@ if (WIN32 OR CYGWIN)
else()
set(_platform WinEmpty)
endif()
-elseif(COMPILER_HAS_HIDDEN_VISIBILITY AND USE_COMPILER_HIDDEN_VISIBILITY)
+elseif(COMPILER_HAS_HIDDEN_VISIBILITY)
set(_platform UNIX)
elseif(COMPILER_HAS_DEPRECATED)
set(_platform UNIX_DeprecatedOnly)