diff options
| author | David Benjamin <davidben@google.com> | 2018-06-29 19:54:42 (GMT) |
|---|---|---|
| committer | David Benjamin <davidben@google.com> | 2018-07-02 22:50:12 (GMT) |
| commit | cb694f8cd65dfb4e73fedcfa04f92c8be7a2bcf6 (patch) | |
| tree | 1864e4af430fe5f2b33beb0adad881430ba28cdb /Tests/VSNASM/include | |
| parent | 9539985fb215439d3d379f60a381e6102ac49e4b (diff) | |
| download | CMake-cb694f8cd65dfb4e73fedcfa04f92c8be7a2bcf6.zip CMake-cb694f8cd65dfb4e73fedcfa04f92c8be7a2bcf6.tar.gz CMake-cb694f8cd65dfb4e73fedcfa04f92c8be7a2bcf6.tar.bz2 | |
VS: Properly quote arguments in nasm.xml
Most arguments were quoted, but some weren't, causing problems if the
arguments contained whitespace.
In particular, the _STL_EXTRA_DISABLED_WARNINGS value takes spaces and
CMake's NASM support applies all add_definitions lines to NASM. The -D
flag is missing quotes, so projects using NASM and setting
_STL_EXTRA_DISABLED_WARNINGS break in the Visual Studio generator.
Likewise, the -o flag is missing quotes, which means filenames with
spaces do not work.
(The -U flag is unlikely to need quotes, but include them for
consistency.)
Extend the existing VSNASM test to cover these cases.
Diffstat (limited to 'Tests/VSNASM/include')
| -rw-r--r-- | Tests/VSNASM/include/foo-proc.asm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Tests/VSNASM/include/foo-proc.asm b/Tests/VSNASM/include/foo-proc.asm index 450a791..eb5bb2b 100644 --- a/Tests/VSNASM/include/foo-proc.asm +++ b/Tests/VSNASM/include/foo-proc.asm @@ -3,5 +3,5 @@ foo: %else _foo: %endif - mov eax, 0 + mov EAX_COMMA_SPACE_ZERO ret |