summaryrefslogtreecommitdiffstats
path: root/Tests/VSResource
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2017-06-22 13:30:43 (GMT)
committerBrad King <brad.king@kitware.com>2017-06-22 13:45:42 (GMT)
commit974f43338b09e6ae4342015e2cc088d751943cb0 (patch)
treeb18681925273f27ab1b00b8932d29db45abcb0ce /Tests/VSResource
parentea6bb8293f50ecc93f42b6ea6525baa0252712a5 (diff)
downloadCMake-974f43338b09e6ae4342015e2cc088d751943cb0.zip
CMake-974f43338b09e6ae4342015e2cc088d751943cb0.tar.gz
CMake-974f43338b09e6ae4342015e2cc088d751943cb0.tar.bz2
VS: Fix support for rc /nologo flag in per-source COMPILE_FLAGS
Since commit v3.9.0-rc1~160^2 (VS: Use tool-specific flag table for COMPILE_FLAGS parsing, 2017-05-03) we now correctly use the `rc` flag table to process the COMPILE_FLAGS flags of `.rc` source files instead of incorrectly using the `cl` flag table as before. However, our `rc` flag table is not complete. The `/nologo` flag was working before only by accident because the `cl` flag table entry for it happened to match. Add the proper entry to the `rc` flag table. Fixes: #16991
Diffstat (limited to 'Tests/VSResource')
-rw-r--r--Tests/VSResource/CMakeLists.txt4
1 files changed, 4 insertions, 0 deletions
diff --git a/Tests/VSResource/CMakeLists.txt b/Tests/VSResource/CMakeLists.txt
index 3b9cfc3..3f56303 100644
--- a/Tests/VSResource/CMakeLists.txt
+++ b/Tests/VSResource/CMakeLists.txt
@@ -51,5 +51,9 @@ add_library(ResourceLib STATIC lib.cpp lib.rc)
add_executable(VSResource main.cpp test.rc)
target_link_libraries(VSResource ResourceLib)
+if(MSVC AND NOT MSVC_VERSION VERSION_LESS 1600)
+ set_property(SOURCE test.rc PROPERTY COMPILE_FLAGS /nologo)
+endif()
+
set_property(TARGET VSResource
PROPERTY VS_GLOBAL_CMakeTestVsGlobalVariable "test val")