diff options
| author | Brad King <brad.king@kitware.com> | 2017-09-27 11:10:46 (GMT) |
|---|---|---|
| committer | Kitware Robot <kwrobot@kitware.com> | 2017-09-27 11:11:07 (GMT) |
| commit | 09350f19e073e33ea698ecb3bc45bb0a22d62a25 (patch) | |
| tree | 1fdc9766f559759bc54fd490ca69e6fd5c0f5e22 /Tests | |
| parent | f4517a4767560d7822885443434eb185612a6817 (diff) | |
| parent | a7005c985d2ed22f1192864a358eb89e2c1b63f7 (diff) | |
| download | CMake-09350f19e073e33ea698ecb3bc45bb0a22d62a25.zip CMake-09350f19e073e33ea698ecb3bc45bb0a22d62a25.tar.gz CMake-09350f19e073e33ea698ecb3bc45bb0a22d62a25.tar.bz2 | |
Merge topic 'revert-perf-source-lookup'
a7005c98 Tests: Add case for legacy source file property behavior
1604716d Revert "Performance: Improve efficiency of source file lookup in cmMakefile"
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1308
Diffstat (limited to 'Tests')
| -rw-r--r-- | Tests/RunCMake/get_property/source_properties-stderr.txt | 8 | ||||
| -rw-r--r-- | Tests/RunCMake/get_property/source_properties.cmake | 10 |
2 files changed, 17 insertions, 1 deletions
diff --git a/Tests/RunCMake/get_property/source_properties-stderr.txt b/Tests/RunCMake/get_property/source_properties-stderr.txt index 0a46f96..00a9b82 100644 --- a/Tests/RunCMake/get_property/source_properties-stderr.txt +++ b/Tests/RunCMake/get_property/source_properties-stderr.txt @@ -3,4 +3,10 @@ get_property: --><-- get_source_file_property: -->value<-- get_property: -->value<-- get_source_file_property: -->NOTFOUND<-- -get_property: --><--$ +get_property: --><-- +get_source_file_property: -->value<-- +get_property: -->value<-- +get_source_file_property: -->NOTFOUND<-- +get_property: --><-- +get_source_file_property: -->value<-- +get_property: -->value<--$ diff --git a/Tests/RunCMake/get_property/source_properties.cmake b/Tests/RunCMake/get_property/source_properties.cmake index 263ffe1..12d2d07 100644 --- a/Tests/RunCMake/get_property/source_properties.cmake +++ b/Tests/RunCMake/get_property/source_properties.cmake @@ -13,3 +13,13 @@ set_source_files_properties(file.c PROPERTIES empty "" custom value) check_source_file_property(file.c empty) check_source_file_property(file.c custom) check_source_file_property(file.c noexist) + +# Test strange legacy behavior in which the order in which source files are +# first accessed affects how properties are applied without an extension. +# See also issue #15208. +get_property(lang SOURCE ${CMAKE_CURRENT_BINARY_DIR}/file2.c PROPERTY LANGUAGE) +get_property(lang SOURCE ${CMAKE_CURRENT_BINARY_DIR}/file2.h PROPERTY LANGUAGE) +set_property(SOURCE file2 PROPERTY custom value) # set property without extension +check_source_file_property(file2 custom) # should have property +check_source_file_property(file2.h custom) # should not have property +check_source_file_property(file2.c custom) # should have property |