summaryrefslogtreecommitdiffstats
path: root/Tests
diff options
context:
space:
mode:
authorJohnny Jazeix <jazeix@gmail.com>2019-12-23 09:35:41 (GMT)
committerBrad King <brad.king@kitware.com>2020-01-15 15:03:35 (GMT)
commitc0da651c09e11f9868529b7f8c4dc8f97c4546c8 (patch)
tree2c83d48dba0e6bdde0b710b5f89dca4199c4eb7b /Tests
parentb56d429324330a9eb8d3c1860333969140851dd7 (diff)
downloadCMake-c0da651c09e11f9868529b7f8c4dc8f97c4546c8.zip
CMake-c0da651c09e11f9868529b7f8c4dc8f97c4546c8.tar.gz
CMake-c0da651c09e11f9868529b7f8c4dc8f97c4546c8.tar.bz2
file(DOWNLOAD): Don't fail if given just a filename to write to
Fixes: #17969
Diffstat (limited to 'Tests')
-rw-r--r--Tests/CMakeTests/FileDownloadTest.cmake.in18
-rw-r--r--Tests/CMakeTests/FileTestScript.cmake2
2 files changed, 19 insertions, 1 deletions
diff --git a/Tests/CMakeTests/FileDownloadTest.cmake.in b/Tests/CMakeTests/FileDownloadTest.cmake.in
index 6c1ee75..5bd3803 100644
--- a/Tests/CMakeTests/FileDownloadTest.cmake.in
+++ b/Tests/CMakeTests/FileDownloadTest.cmake.in
@@ -145,3 +145,21 @@ file(DOWNLOAD
)
message(STATUS "${status}")
__reportIfWrongStatus("${status}" 6) # 6 corresponds to an unresolvable host name
+
+message(STATUS "FileDownload:12")
+set(absFile "@CMAKE_CURRENT_BINARY_DIR@/file12.png")
+if(EXISTS "${absFile}")
+ file(RENAME ${absFile} "${absFile}_beingRemoved")
+ file(REMOVE "${absFile}_beingRemoved")
+endif()
+file(DOWNLOAD
+ ${url}
+ file12.png
+ TIMEOUT ${timeout}
+ EXPECTED_MD5 dbd330d52f4dbd60115d4191904ded92
+ STATUS status
+ )
+__reportIfWrongStatus("${status}" 0)
+if(NOT EXISTS file12.png)
+ message(SEND_ERROR "file12.png not downloaded: ${status}")
+endif()
diff --git a/Tests/CMakeTests/FileTestScript.cmake b/Tests/CMakeTests/FileTestScript.cmake
index 9a43569..145f28a 100644
--- a/Tests/CMakeTests/FileTestScript.cmake
+++ b/Tests/CMakeTests/FileTestScript.cmake
@@ -183,7 +183,7 @@ elseif(testname STREQUAL to_native_path) # pass
elseif(testname STREQUAL download_wrong_number_of_args) # fail
file(DOWNLOAD zzzz://bogus/ffff)
-elseif(testname STREQUAL download_file_with_no_path) # fail
+elseif(testname STREQUAL download_file_with_no_path) # pass
file(DOWNLOAD zzzz://bogus/ffff ffff)
elseif(testname STREQUAL download_missing_time) # fail