diff options
| author | Brad King <brad.king@kitware.com> | 2022-06-06 15:32:32 (GMT) |
|---|---|---|
| committer | Brad King <brad.king@kitware.com> | 2022-06-06 15:44:53 (GMT) |
| commit | a4c48afbbca19ab348d008ae2c8e8aa8ac09983f (patch) | |
| tree | 41db2f9b96a96f68365652299e9125b326ffea0e /Utilities/Release | |
| parent | ab1edff49268df77e1cdcf8074e24e64ef140370 (diff) | |
| download | CMake-a4c48afbbca19ab348d008ae2c8e8aa8ac09983f.zip CMake-a4c48afbbca19ab348d008ae2c8e8aa8ac09983f.tar.gz CMake-a4c48afbbca19ab348d008ae2c8e8aa8ac09983f.tar.bz2 | |
Utilities/Release: Drop unnecessary system API definitions for Linux
We previously defined `_POSIX_C_SOURCE` and friends while building
binary packages in order to minimize the version of glibc needed at
runtime. The definitions were added by commit facc240a45
(Utilities/Release: Add docker specs to build and test Linux binaries,
2019-08-23, v3.16.0-rc1~184^2~2), but came from older packaging scripts
that were removed by commit 689fdbfc61 (Utilities/Release: Drop linux64
script in favor of docker build, 2019-08-27, v3.16.0-rc1~184^2). Those
older scripts were meant for use in a hand-maintained environment. Now
that we use base images of old CentOS versions to establish the build
environment, our builds are already limited to older glibc versions
(glibc 2.12 from centos6 on x86_64, and 2.17 from centos7 on aarch64).
Our old system API definitions no longer affect the glibc version
required by the binaries. Drop them to avoid potential conflicts with
system API definitions added by changes like commit f034b0f663 (CMake
compilation: do not use compiler extensions, 2020-03-14, v3.18.0-rc1~494^2)
and commit c7c3e39e4f (Utilities: Activate POSIX APIs even without
compiler extensions, 2022-06-02).
Diffstat (limited to 'Utilities/Release')
| -rw-r--r-- | Utilities/Release/linux/aarch64/cache.txt | 3 | ||||
| -rw-r--r-- | Utilities/Release/linux/x86_64/cache.txt | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/Utilities/Release/linux/aarch64/cache.txt b/Utilities/Release/linux/aarch64/cache.txt index ebfed73..87851d5 100644 --- a/Utilities/Release/linux/aarch64/cache.txt +++ b/Utilities/Release/linux/aarch64/cache.txt @@ -3,9 +3,6 @@ CMAKE_BUILD_TYPE:STRING=Release CMAKE_C_STANDARD:STRING=11 CMAKE_CXX_STANDARD:STRING=14 -# Require only older APIs where possible. -CMAKE_C_FLAGS:STRING=-D_POSIX_C_SOURCE=199506L -D_POSIX_SOURCE=1 -D_SVID_SOURCE=1 -D_BSD_SOURCE=1 - # Link C++ library statically. CMAKE_EXE_LINKER_FLAGS:STRING=-static-libstdc++ -static-libgcc diff --git a/Utilities/Release/linux/x86_64/cache.txt b/Utilities/Release/linux/x86_64/cache.txt index a422af3..d32c3dd 100644 --- a/Utilities/Release/linux/x86_64/cache.txt +++ b/Utilities/Release/linux/x86_64/cache.txt @@ -3,9 +3,6 @@ CMAKE_BUILD_TYPE:STRING=Release CMAKE_C_STANDARD:STRING=11 CMAKE_CXX_STANDARD:STRING=14 -# Require only older APIs where possible. -CMAKE_C_FLAGS:STRING=-D_POSIX_C_SOURCE=199506L -D_POSIX_SOURCE=1 -D_SVID_SOURCE=1 -D_BSD_SOURCE=1 - # Link C++ library statically. CMAKE_EXE_LINKER_FLAGS:STRING=-static-libstdc++ -static-libgcc |