diff options
-rw-r--r-- | Source/cmLocalGenerator.cxx | 28 | ||||
-rw-r--r-- | Source/cmLocalGenerator.h | 7 |
2 files changed, 6 insertions, 29 deletions
diff --git a/Source/cmLocalGenerator.cxx b/Source/cmLocalGenerator.cxx index 859aa44..afdcc84 100644 --- a/Source/cmLocalGenerator.cxx +++ b/Source/cmLocalGenerator.cxx @@ -553,14 +553,13 @@ void cmLocalGenerator::GenerateInstallRules() void cmLocalGenerator::AddGeneratorTarget(cmGeneratorTarget* gt) { this->GeneratorTargets.push_back(gt); - this->GeneratorTargetSearchIndex.insert( - std::pair<std::string, cmGeneratorTarget*>(gt->GetName(), gt)); + this->GeneratorTargetSearchIndex.emplace(gt->GetName(), gt); this->GlobalGenerator->IndexGeneratorTarget(gt); } void cmLocalGenerator::AddImportedGeneratorTarget(cmGeneratorTarget* gt) { - this->ImportedGeneratorTargets.push_back(gt); + this->ImportedGeneratorTargets.emplace(gt->GetName(), gt); this->GlobalGenerator->IndexGeneratorTarget(gt); } @@ -569,22 +568,6 @@ void cmLocalGenerator::AddOwnedImportedGeneratorTarget(cmGeneratorTarget* gt) this->OwnedImportedGeneratorTargets.push_back(gt); } -struct NamedGeneratorTargetFinder -{ - NamedGeneratorTargetFinder(std::string const& name) - : Name(name) - { - } - - bool operator()(cmGeneratorTarget* tgt) - { - return tgt->GetName() == this->Name; - } - -private: - std::string Name; -}; - cmGeneratorTarget* cmLocalGenerator::FindLocalNonAliasGeneratorTarget( const std::string& name) const { @@ -1395,11 +1378,10 @@ void cmLocalGenerator::AddLanguageFlagsForLinking( cmGeneratorTarget* cmLocalGenerator::FindGeneratorTargetToUse( const std::string& name) const { - std::vector<cmGeneratorTarget*>::const_iterator imported = std::find_if( - this->ImportedGeneratorTargets.begin(), - this->ImportedGeneratorTargets.end(), NamedGeneratorTargetFinder(name)); + GeneratorTargetMap::const_iterator imported = + this->ImportedGeneratorTargets.find(name); if (imported != this->ImportedGeneratorTargets.end()) { - return *imported; + return imported->second; } if (cmGeneratorTarget* t = this->FindLocalNonAliasGeneratorTarget(name)) { diff --git a/Source/cmLocalGenerator.h b/Source/cmLocalGenerator.h index a66fa6e..58bbe77 100644 --- a/Source/cmLocalGenerator.h +++ b/Source/cmLocalGenerator.h @@ -139,11 +139,6 @@ public: return this->GeneratorTargets; } - const std::vector<cmGeneratorTarget*>& GetImportedGeneratorTargets() const - { - return this->ImportedGeneratorTargets; - } - void AddGeneratorTarget(cmGeneratorTarget* gt); void AddImportedGeneratorTarget(cmGeneratorTarget* gt); void AddOwnedImportedGeneratorTarget(cmGeneratorTarget* gt); @@ -394,7 +389,7 @@ protected: std::vector<cmGeneratorTarget*> GeneratorTargets; std::set<cmGeneratorTarget const*> WarnCMP0063; - std::vector<cmGeneratorTarget*> ImportedGeneratorTargets; + GeneratorTargetMap ImportedGeneratorTargets; std::vector<cmGeneratorTarget*> OwnedImportedGeneratorTargets; std::map<std::string, std::string> AliasTargets; |