summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* clang-tidy: address bugprone-branch-clone lintsBen Boeckel2020-04-1320-87/+59
| | | | | | | | | Arguably, many of these are bugs in `clang-tidy`. An if/else tree with other conditionals between cloned blocks may be relying on the intermediate logic to fall out of the case and inverting this logic may be non-trivial. See: https://bugs.llvm.org/show_bug.cgi?id=44165
* clang-tidy: ignore making members staticBen Boeckel2020-04-131-0/+1
| | | | | CMake has lots of instances of this which is outside the scope of this topic right now.
* TestDriver: avoid clang-tidy lints in generated codeBen Boeckel2020-04-131-2/+5
|
* clang-tidy: ignore the use-trailing-return-type lintBen Boeckel2020-04-131-0/+1
| | | | CMake isn't ready for this yet.
* Merge topic 'include-dir-special'Brad King2020-04-133-1/+30
|\ | | | | | | | | | | | | | | 9be48c4d0b Tests: Add coverage for special characters in include directories dc0dc974a9 Xcode: Fix quoting of paths with square brackets Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4591
| * Tests: Add coverage for special characters in include directoriesBrad King2020-04-102-0/+29
| | | | | | | | | | | | | | | | | | We have tests for special characters in preprocessor definitions and custom command line arguments. Add such a test for include directories. Currently the Makefiles generators do not escape paths in `depend.make` in all cases, so leave a FIXME comment and skip the test for those. Issue: #20555
| * Xcode: Fix quoting of paths with square bracketsBrad King2020-04-101-1/+1
| | | | | | | | | | | | | | The Xcode project file format needs paths containing square brackets ('[' or ']') to be quoted. Issue: #20555
* | Merge branch 'release-3.17'Brad King2020-04-130-0/+0
|\ \
| * \ Merge topic 'FindMPI-pgi-spectrum-mpi-wrappers' into release-3.17Brad King2020-04-131-3/+3
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | cd449c6175 FindMPI: Add the pgi compiler wrapper names used by IBM Spectrum MPI Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4598
* | \ \ Merge topic 'FindMPI-pgi-spectrum-mpi-wrappers'Brad King2020-04-131-3/+3
|\ \ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | cd449c6175 FindMPI: Add the pgi compiler wrapper names used by IBM Spectrum MPI Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4598
| * | | FindMPI: Add the pgi compiler wrapper names used by IBM Spectrum MPIChuck Atkins2020-04-101-3/+3
| | | |
* | | | Merge branch 'release-3.17'Brad King2020-04-130-0/+0
|\ \ \ \ | | |/ / | |/| |
| * | | Merge branch 'release-3.16' into release-3.17Brad King2020-04-130-0/+0
| |\ \ \ | | |/ /
* | | | Merge topic 'update-kwsys'Brad King2020-04-136-107/+162
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0b495b6ca9 Merge branch 'upstream-KWSys' into update-kwsys 4ab6fcd676 KWSys 2020-04-10 (b62956f5) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4594
| * \ \ \ Merge branch 'upstream-KWSys' into update-kwsysBrad King2020-04-106-107/+162
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # By KWSys Upstream * upstream-KWSys: KWSys 2020-04-10 (b62956f5)
| | * | | | KWSys 2020-04-10 (b62956f5)KWSys Upstream2020-04-106-107/+162
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code extracted from: https://gitlab.kitware.com/utils/kwsys.git at commit b62956f5d70fef750e8414342f1566a29e8e7899 (master). Upstream Shortlog ----------------- Ben Boeckel (6): ccab3808 clang-tidy: address readability-isolate-declaration lints 87b57076 clang-tidy: address readability-braces-around-statements lints 13b45a41 clang-tidy: address readability-else-after-return lints ebb48d58 clang-tidy: address google-readability-casting lint 09942f51 testSystemTools: add tests for SplitString 986519af SystemTools: handle splitting a string starting with the separator
* | | | | | Merge topic 'clang_cuda_prep'Brad King2020-04-139-192/+141
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d86fcc6359 CUDAToolkit: Deduce toolkit binary directory from compiler path only for NVCC 87e98bf8be CUDA: Forward CMAKE_CUDA_COMPILER_TARGET in try_compile() 60e60b9201 GNU: Disable depfiles in try-compile mode only for GCC 5f02add366 CUDA: Refactor PTX compilation flag into compiler modules 25439c7d62 Clang: Refactor CXX standard flags into __compiler_clang_cxx_standards() Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4567
| * | | | | | CUDAToolkit: Deduce toolkit binary directory from compiler path only for NVCCRaul Tambre2020-04-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This assumption doesn't hold for Clang. When crosscompiling this causes X86 libraries to be used and thus linker errors.
| * | | | | | CUDA: Forward CMAKE_CUDA_COMPILER_TARGET in try_compile()Raul Tambre2020-04-071-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Required for crosscompile support with Clang.
| * | | | | | GNU: Disable depfiles in try-compile mode only for GCCRaul Tambre2020-04-071-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disabling them causes issues for Clang's CUDA frontend. Since this is a GCC bug, simply check for GCC.
| * | | | | | CUDA: Refactor PTX compilation flag into compiler modulesRaul Tambre2020-04-072-1/+2
| | | | | | |
| * | | | | | Clang: Refactor CXX standard flags into __compiler_clang_cxx_standards()Raul Tambre2020-04-074-188/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These standard flags are the same for CXX, OBJCXX and CUDA. Refactor them into a single macro to reduce duplication and so we can easily reuse them. Updated bootstrap script to search in the general Clang module instead of the language-specific.
* | | | | | | CMake Nightly Date StampKitware Robot2020-04-131-1/+1
| | | | | | |
* | | | | | | Merge topic 'FindPython-help-updates'Marc Chevrier2020-04-123-24/+43
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 525c730afe Help: FindPython: fix typos and add some clarifications Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4599
| * | | | | | | Help: FindPython: fix typos and add some clarificationsMarc Chevrier2020-04-113-24/+43
| | | | | | | |
* | | | | | | | CMake Nightly Date StampKitware Robot2020-04-121-1/+1
| | | | | | | |
* | | | | | | | Merge branch 'release-3.17'Craig Scott2020-04-110-0/+0
|\ \ \ \ \ \ \ \ | | |_|_|_|/ / / | |/| | | | | |
| * | | | | | | Merge topic 'docs-CMAKE_CURRENT_FUNCTION' into release-3.17Craig Scott2020-04-115-25/+46
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 10ee9611f0 Help: Improve wording of CMAKE_CURRENT_FUNCTION_LIST_DIR docs 22fbc404a7 Help: Add cross-references for CMAKE_CURRENT_FUNCTION* docs d2b139687a Help: Minor grammar cleanups of CMAKE_CURRENT_FUNCTION* docs Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Brad King <brad.king@kitware.com> Acked-by: Alex Turbov <i.zaufi@gmail.com> Merge-request: !4595
* | \ \ \ \ \ \ \ Merge topic 'docs-CMAKE_CURRENT_FUNCTION'Craig Scott2020-04-115-25/+46
|\ \ \ \ \ \ \ \ \ | | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 10ee9611f0 Help: Improve wording of CMAKE_CURRENT_FUNCTION_LIST_DIR docs 22fbc404a7 Help: Add cross-references for CMAKE_CURRENT_FUNCTION* docs d2b139687a Help: Minor grammar cleanups of CMAKE_CURRENT_FUNCTION* docs Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Brad King <brad.king@kitware.com> Acked-by: Alex Turbov <i.zaufi@gmail.com> Merge-request: !4595
| * | | | | | | | Help: Improve wording of CMAKE_CURRENT_FUNCTION_LIST_DIR docsCraig Scott2020-04-101-20/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original wording was somewhat confusing in talking about rendering of templates. While technically correct, a less experienced user may not know that terminology. The wording has been updated to more clearly describe the example usage. The old way of implementing the example is not "bad", it was the only way to do things before the CMAKE_CURRENT_FUNCTION_LIST_DIR variable was added. The example has been updated to remove the Bad/Good captions to reflect this. Indentation of the examples was also fixed to make them conform to the guidelines.
| * | | | | | | | Help: Add cross-references for CMAKE_CURRENT_FUNCTION* docsCraig Scott2020-04-103-0/+12
| | | | | | | | |
| * | | | | | | | Help: Minor grammar cleanups of CMAKE_CURRENT_FUNCTION* docsCraig Scott2020-04-105-5/+6
| | | | | | | | |
* | | | | | | | | Merge branch 'release-3.17'Craig Scott2020-04-110-0/+0
|\ \ \ \ \ \ \ \ \ | | |/ / / / / / / | |/| | | | | | |
| * | | | | | | | Merge topic 'docs-SKIP_PRECOMPILE_HEADERS-formatting' into release-3.17Craig Scott2020-04-111-2/+2
| |\ \ \ \ \ \ \ \ | | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a293d05c41 Help: Fix unescaped asterisks in docs for SKIP_PRECOMPILE_HEADERS Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4592
* | | | | | | | | Merge topic 'docs-SKIP_PRECOMPILE_HEADERS-formatting'Craig Scott2020-04-111-2/+2
|\ \ \ \ \ \ \ \ \ | | |/ / / / / / / | |/| / / / / / / | |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | a293d05c41 Help: Fix unescaped asterisks in docs for SKIP_PRECOMPILE_HEADERS Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4592
| * | | | | | | Help: Fix unescaped asterisks in docs for SKIP_PRECOMPILE_HEADERSCraig Scott2020-04-101-2/+2
| |/ / / / / /
* | | | | | | CMake Nightly Date StampKitware Robot2020-04-111-1/+1
| | | | | | |
* | | | | | | Merge topic 'openal-typo'Brad King2020-04-101-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | dab57d3f5f FindOpenAL: Fix documentation typos Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4596
| * | | | | | | FindOpenAL: Fix documentation typosNguyễn Gia Phong2020-04-101-2/+2
| | | | | | | |
* | | | | | | | Merge topic 'find_program-exe-no-read'Brad King2020-04-104-1/+10
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 86e6349ef7 find_program: Find programs that are executable but not readable Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4571
| * | | | | | | | find_program: Find programs that are executable but not readableVladimir Menshakov2020-04-094-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `find_program` internally uses `cmSystemTools::FileExists` which calls `access(R_OK)` instead of `access(X_OK)`. Use `cmSystemTools::IsFileExecutable` instead to fix this issue. An example of such a program is `sudo`. Fixes: #10468
* | | | | | | | | Merge topic 'ccmake-better-string-ops'Brad King2020-04-101-1/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 603a532b58 cmCursesLongMessageForm: avoid unnecessary string allocation Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Sylvain Joubert <joubert.sy@gmail.com> Merge-request: !4590
| * | | | | | | | | cmCursesLongMessageForm: avoid unnecessary string allocationBen Boeckel2020-04-091-1/+2
| | |_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The addition makes a temporary string and then drops it after adding it to `this->Messages`. Instead, just incrementally append.
* | | | | | | | | Merge topic 'FindBLAS_FindLAPACK_ArmPL'Brad King2020-04-102-0/+68
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 14ffa6e90e Find{BLAS,LAPACK}: Add support for ArmPL targets Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4502
| * | | | | | | | | Find{BLAS,LAPACK}: Add support for ArmPL targetsOlly Perks2020-04-092-0/+68
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for the Arm Performance Libraries (ArmPL) which provide an implementation of BLAS, LAPACK and FFTW for use on Arm Linux systems: https://developer.arm.com/tools-and-software/server-and-hpc/compile/arm-compiler-for-linux/arm-performance-libraries
* | | | | | | | | Merge topic 'googletest-skipped'Brad King2020-04-105-0/+49
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 89a843d6ea GoogleTest: Add testcase for skipped tests 98868dad1c GoogleTest: Add support for skipped tests Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4586
| * | | | | | | | GoogleTest: Add testcase for skipped testsAlexander Stein2020-04-104-0/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This simply runs a mocked test case which uses the prefix for signaling a skipped test. CTest's output is checked for a skipped test result.
| * | | | | | | | GoogleTest: Add support for skipped testsAlexander Stein2020-04-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Skipped tests are currently reported as successful. Using SKIP_REGULAR_EXPRESSION on googletest's output prefix, skipped tests can be detected and accounted accordingly. Using SKIP_RETURN_CODE is not possible, googletests exit code is not affected by skipped tests. Fixes: #19669
* | | | | | | | | Merge branch 'release-3.16'Brad King2020-04-100-0/+0
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / |/| | | | | | | / | | |_|_|_|_|_|/ | |/| | | | | |
| * | | | | | | CMake 3.16.6v3.16.6Brad King2020-04-101-1/+1
| | | | | | | |