summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | | | | Merge topic 'update-kwsys'Brad King2018-09-172-5/+5
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 49e7a82c90 Merge branch 'upstream-KWSys' into update-kwsys b13c8526b1 KWSys 2018-09-14 (1809bedd) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2385
| * \ \ \ \ \ \ \ \ \ \ \ \ Merge branch 'upstream-KWSys' into update-kwsysBrad King2018-09-142-5/+5
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * upstream-KWSys: KWSys 2018-09-14 (1809bedd)
| | * | | | | | | | | | | | KWSys 2018-09-14 (1809bedd)KWSys Upstream2018-09-142-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code extracted from: https://gitlab.kitware.com/utils/kwsys.git at commit 1809bedde0491d078ad42200bf2834c345e65398 (master). Upstream Shortlog ----------------- Ben Boeckel (2): b5b294c1 SystemTools::Split: fix copy-pasta comments ab0d44c9 SystemTools::Split: use str.find_first_of(char) Roger Leigh (1): bdd39241 Process: On Windows do not open stdin file with write permission
* | | | | | | | | | | | | | CMake Nightly Date StampKitware Robot2018-09-171-1/+1
| |_|_|_|_|_|_|_|_|_|/ / / |/| | | | | | | | | | | |
* | | | | | | | | | | | | CMake Nightly Date StampKitware Robot2018-09-161-1/+1
| |_|_|_|_|/ / / / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | CMake Nightly Date StampKitware Robot2018-09-151-1/+1
|/ / / / / / / / / / /
* | | | | | | | | | | Merge topic 'out-of-dir-linking'Brad King2018-09-1460-88/+529
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a1ad0a699b target_link_libraries: Allow use with targets in other directories 9bbae5ae28 cmTarget: Future-proof AddLinkLibrary target lookup scope f9cb6f618a cmExportFileGenerator: Use cmGeneratorTarget::ResolveTargetReference 18441a6269 cmGeneratorTarget: Factor target name resolution out of link item resolution 2f708f5d65 Make internal TARGET_PROPERTY generator expressions more robust 94a75801c8 Android.mk: De-duplicate link libraries logic during export 8a63b23d16 cmGlobalGenerator: Remove unused FindLocalGenerator method Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Patrick Stotko <stotko@cs.uni-bonn.de> Merge-request: !2370
| * | | | | | | | | | | target_link_libraries: Allow use with targets in other directoriesBrad King2018-09-1256-44/+460
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the command did not allow naming targets on the LHS that were not created in the calling directory. Lift this restriction to enable more flexible use by projects. Targets named on the RHS will need to be looked up during generation in the scope of the call site rather than the scope of the LHS target. Introduce an internal syntax in `[INTERFACE_]LINK_LIBRARIES` properties to specify target names that need to be looked up in a directory other than that containing the target on which the property is set. Add minimal documentation of the syntax to help users that encounter it. Unfortunately CMake previously did allow such calls in the case that only `INTERFACE` libraries are specified, but those libraries would be looked up in the target's directory rather than the caller's. Add policy `CMP0079` to enable the new behavior with new lookup scope in a compatible way. Fixes: #17943
| * | | | | | | | | | | cmTarget: Future-proof AddLinkLibrary target lookup scopeBrad King2018-09-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `AddLinkLibrary` method takes a `cmMakefile` pointer to represent the scope of the caller that wants to link to the named library. Currently in all call sites this is the same as the target's `Makefile` member, but in principle the library named by the caller is visible in its scope so we should use the `cmMakefile` it provided to look up the library target.
| * | | | | | | | | | | cmExportFileGenerator: Use cmGeneratorTarget::ResolveTargetReferenceBrad King2018-09-121-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid calling `FindGeneratorTargetToUse` directly.
| * | | | | | | | | | | cmGeneratorTarget: Factor target name resolution out of link item resolutionBrad King2018-09-122-10/+31
| | | | | | | | | | | |
| * | | | | | | | | | | Make internal TARGET_PROPERTY generator expressions more robustBrad King2018-09-124-3/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While collecting usage requirements from the `INTERFACE_*` properties of directly linked targets, we internally generate `TARGET_PROPERTY:` and `TARGET_OBJECTS:` generator expressions to refer to those properties on those targets. At the point we generate these expressions we already have a pointer to an exact `cmGeneratorTarget` instance. Switch from using the target name in these generator expressions to using an internal unique name generated for each `cmGeneratorTarget` instance to be referenced. This avoids depending on the user-facing target name to find the same target we already have.
| * | | | | | | | | | | Android.mk: De-duplicate link libraries logic during exportBrad King2018-09-111-21/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the normal target link interface computation logic to get the list of libraries in the link interface instead of trying to interpret the `INTERFACE_LINK_LIBRARIES` property directly.
| * | | | | | | | | | | cmGlobalGenerator: Remove unused FindLocalGenerator methodBrad King2018-09-112-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method has not been used since commit v3.4.0-rc1~234^2~1 (cmGlobalGenerator: Port Find API to cmMakefile, 2015-08-02).
* | | | | | | | | | | | Merge topic 'module_policy_protection'Brad King2018-09-145-2/+27
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8ede35523e IN_LIST: Ensure policy allows if(IN_LIST) if used by a module e549e31f79 CMakeIOSInstallCombined: Prevent policy leakage Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2375
| * | | | | | | | | | | | IN_LIST: Ensure policy allows if(IN_LIST) if used by a moduleCraig Scott2018-09-124-0/+20
| | | | | | | | | | | | |
| * | | | | | | | | | | | CMakeIOSInstallCombined: Prevent policy leakageCraig Scott2018-09-121-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Functions do not introduce a new policy scope, so surround these policy changes with a push-pop to prevent them from affecting the caller.
* | | | | | | | | | | | | Merge topic 'boost-notfound'Brad King2018-09-141-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ee300dc25d FindBoost: Suppress imported targets warning if Boost was not found Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2376
| * | | | | | | | | | | | | FindBoost: Suppress imported targets warning if Boost was not foundRoger Leigh2018-09-121-1/+1
| | |_|_|_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #18330
* | | | | | | | | | | | | Merge topic 'ctest-stop-time-test'Brad King2018-09-144-18/+44
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ed71ec7579 CTest: Improve stop-time implementation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2378
| * | | | | | | | | | | | | CTest: Improve stop-time implementationBrad King2018-09-124-18/+44
| | |/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The CTestTestStopTime test has been failing sporadically because the stop time causes the first internal test to have a timeout short enough that we might hit it and start the second test just before the stop time is reached. Instead we should track when a timeout is shortened in order to stay within the stop time. If a test times out for this reason then we should consider the stop time reached and not start any more tests.
* | | | | | | | | | | | | Merge topic 'test-ninja-sub-build-fs-delay'Brad King2018-09-141-4/+5
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bdd0e2d709 Tests: Extend RunCMake.Ninja filesystem delays Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2310
| * | | | | | | | | | | | Tests: Extend RunCMake.Ninja filesystem delaysBrad King2018-09-121-4/+5
| | |_|_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On filesystems with 1s resolution the `run_sub_cmake` cases fail occasionally when the 1 second sleep does not cause files to have a different time. Use 3 seconds instead.
* | | | | | | | | | | | CMake Nightly Date StampKitware Robot2018-09-141-1/+1
| |_|_|_|_|/ / / / / / |/| | | | | | | | | |
* | | | | | | | | | | CMake Nightly Date StampKitware Robot2018-09-131-1/+1
|/ / / / / / / / / /
* | | | | | | | | | Merge topic 'rule-launch-custom-extra-space'Brad King2018-09-122-8/+3
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3e125c0c01 Ninja,Makefile: Drop extra space after RULE_LAUNCH_CUSTOM value Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2372
| * | | | | | | | | | Ninja,Makefile: Drop extra space after RULE_LAUNCH_CUSTOM valueBrad King2018-09-112-8/+3
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Ninja and Makefile generators were adding a space to the value both before and after expanding rule variables. Only the latter is needed. While at it, revise some outdated comments since the rule variable expansion is no longer responsible for inserting the launcher. Suggested-by: Mate Pek <mate.pek@gmail.com> Fixes: #18340
* | | | | | | | | | Merge topic 'gicv-stdstring'Brad King2018-09-129-66/+64
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 13d10ee616 cmState::GetInitializedCacheValue: Return as const std::string* Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2365
| * | | | | | | | | | cmState::GetInitializedCacheValue: Return as const std::string*Vitaly Stakhovsky2018-09-109-66/+64
| | | | | | | | | | |
* | | | | | | | | | | Merge topic 'IAR_6_50_6_fix'Brad King2018-09-121-0/+3
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8fdf08c097 IAR: Fix compiler id, version, and arch detection on 6.50.6 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2371
| * | | | | | | | | | | IAR: Fix compiler id, version, and arch detection on 6.50.6Daniel Schürmann2018-09-111-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The IAR 6.50.6 compiler places extra/truncated copies of the compiler id `INFO:` strings into binaries with a prefix like `?<Constant "`. Teach CMakeDetermineCompilerId to ignore them. Fixes: #18333
* | | | | | | | | | | | Merge branch 'release-3.12'Brad King2018-09-120-0/+0
|\ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|_|_|/ | |/| | | | | | | | | |
| * | | | | | | | | | | Merge branch 'FindDoxygen-CMP0057' into release-3.12Brad King2018-09-111-0/+5
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Merge-request: !2373
* | \ \ \ \ \ \ \ \ \ \ \ Merge topic 'FindDoxygen-CMP0057'Brad King2018-09-121-0/+5
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e8213404ce FindDoxygen: Ensure policy settings allow use of IN_LIST Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2373
| * | | | | | | | | | | | FindDoxygen: Ensure policy settings allow use of IN_LISTBrad King2018-09-111-0/+5
| | |_|_|_|_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit v3.9.0-rc1~55^2 (Improve Doxygen support, 2017-04-10) use of the `IN_LIST` condition was added, but this is only supported when policy CMP0057 is set to NEW. Add a policy scope around the module and enable the policy within it. Otherwise it works only in projects that happen to enable the policy. Fixes: #18361
* | | | | | | | | | | | Merge topic 'unused-variables-cleanup'Craig Scott2018-09-122-5/+0
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2c154fec6b Warnings: Remove unused variables Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2364
| * | | | | | | | | | | Warnings: Remove unused variablesCraig Scott2018-09-112-5/+0
| | | | | | | | | | | |
* | | | | | | | | | | | CMake Nightly Date StampKitware Robot2018-09-121-1/+1
| |_|_|_|_|/ / / / / / |/| | | | | | | | | |
* | | | | | | | | | | Merge topic 'gtest_add_tests-empty-file'Craig Scott2018-09-113-4/+5
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 31c82143bf GoogleTest: gtest_add_tests() fails if any source file is empty d6b06d8d87 GoogleTest: Modify test to verify that empty files can be scanned Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2342
| * | | | | | | | | | | GoogleTest: gtest_add_tests() fails if any source file is emptyAlessandro2018-09-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #18321
| * | | | | | | | | | | GoogleTest: Modify test to verify that empty files can be scannedCraig Scott2018-09-102-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The modified test confirms the bug described in issue #18321.
* | | | | | | | | | | | Merge topic 'iar-fail-early'Brad King2018-09-113-0/+14
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a26ebb894b IAR: Abort if compiler version or target architecture is not detected Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2353
| * | | | | | | | | | | | IAR: Abort if compiler version or target architecture is not detectedDaniel Schürmann2018-09-103-0/+14
| | |_|_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If these are not detected then we cannot support the IAR compiler. Fail early with an explicit message instead of silently proceeding and getting strange errors. Issue: #18333
* | | | | | | | | | | | Merge topic 'cmake_cpack_command-doc'Brad King2018-09-112-0/+9
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5ff7149298 Help: Document existence of CMAKE_CPACK_COMMAND Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2367
| * | | | | | | | | | | | Help: Document existence of CMAKE_CPACK_COMMANDKyle Edwards2018-09-102-0/+9
| | |_|_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This useful variable was previously undocumented. This commit adds brief documentation for it.
* | | | | | | | | | | | Merge topic 'replace-os-x-name-with-macos'Brad King2018-09-1154-126/+126
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ab2e35d614 Replace occurrences of "Mac OS X" with "macOS" in comments fc1602456a Help: Replace occurrences of "Mac OS X" with "macOS" Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Gregor Jasny <gjasny@googlemail.com> Reviewed-by: Clinton Stimpson <clinton@elemtech.com> Merge-request: !2351
| * | | | | | | | | | | | Replace occurrences of "Mac OS X" with "macOS" in commentsBartosz Kosiorek2018-09-108-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apple's main Operating system changed their name from OS X to macOS: https://www.engadget.com/2016/06/13/os-x-is-now-macos/ Revise source comments accordingly.
| * | | | | | | | | | | | Help: Replace occurrences of "Mac OS X" with "macOS"Bartosz Kosiorek2018-09-0546-115/+115
| | |/ / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Apple's main Operating system changed their name from OS X to macOS: https://www.engadget.com/2016/06/13/os-x-is-now-macos/ Revise documentation accordingly.
* | | | | | | | | | | | Merge topic 'docs/setdirproprs'Brad King2018-09-112-7/+12
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6d8cabe8d4 Help: Clarify INCLUDE_DIRECTORIES directory property behavior 7b9d8ce168 Help: Clarify wording of set_directory_properties docs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2337
| * | | | | | | | | | | Help: Clarify INCLUDE_DIRECTORIES directory property behaviorBrian Heim2018-09-101-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ordering w.r.t. target creation is important for this property. Fixes: #17754
generated by cgit v0.12 at 2024-09-24 04:30:11 (GMT)