summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | Merge topic 'ninja-always-make-object-dirs'Brad King2024-01-094-20/+43
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | de3dc16b64 cmNinjaTargetGenerator: use `.` for the needed phony order-only dependency 1aa28f3b92 cmNinjaTargetGenerator: ensure that the object output directory exists 4a9613ff9b cmNinjaTargetGenerator: add a method to compute the object directory Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9105
| * | | | | | | | | cmNinjaTargetGenerator: use `.` for the needed phony order-only dependencyBen Boeckel2024-01-063-6/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is only required for Ninja < 1.7 though.
| * | | | | | | | | cmNinjaTargetGenerator: ensure that the object output directory existsBen Boeckel2024-01-061-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a target has no object compilations within it, nothing ensures that the directory exists yet it is still mentioned as an order-only dependency within the build files. While `ninja` is OK with this, `samu`, an alternate `ninja` implementation, is not. Make sure the directory always exists for consistency. Fixes: #25526
| * | | | | | | | | cmNinjaTargetGenerator: add a method to compute the object directoryBen Boeckel2024-01-052-15/+14
| | | | | | | | | |
* | | | | | | | | | Merge topic 'doc-INSTALL_PREFIX'Brad King2024-01-091-4/+7
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 925f9f18dd Help: INSTALL_PREFIX in install(CODE|SCRIPT) was added in CMake 3.27 Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Alex <leha-bot@yandex.ru> Acked-by: Frank Dana <ferdnyc@gmail.com> Merge-request: !9135
| * | | | | | | | | | Help: INSTALL_PREFIX in install(CODE|SCRIPT) was added in CMake 3.27Peter Kokot2024-01-081-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In commit 18e02ace5b (install(CODE|SCRIPT): Support $<INSTALL_PREFIX> genex, 2023-02-24, v3.27.0-rc1~431^2) we documented the feature without stating what version added it.
* | | | | | | | | | | Merge topic 'cpack-nuget-readme'Brad King2024-01-092-0/+23
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ccde6f8048 CPack/NuGet: Add support for repository tag 2c616e85cf CPack/NuGet: Add support for readme tag Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9139
| * | | | | | | | | | | CPack/NuGet: Add support for repository tagAlex Turbov2024-01-082-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #23703
| * | | | | | | | | | | CPack/NuGet: Add support for readme tagAlex Turbov2024-01-082-0/+4
| | |_|_|_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #25542
* | | | | | | | | | | Merge topic 'cmake-gui-unused-slot'Brad King2024-01-091-4/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3f3c387a96 cmake-gui: Remove unused viewType slot Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9137
| * | | | | | | | | | | cmake-gui: Remove unused viewType slotChristoph GrĂ¼ninger2024-01-081-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The slot for `setViewType(t)` and `viewType()` are never connected. Found by Clazy (`const-signal-or-slot`).
* | | | | | | | | | | | Merge topic 'lcc-updates'Brad King2024-01-097-32/+104
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fe1903326c Tests: Avoid procedure stack overflow in broken libc on Elbrus b7f9d24b40 Tests: Improve RunCMake.export expected output matching robustness 3377141c8f Tests: With lfortran < 1.24 skip cases broken by incorrect filename handling 020e80d825 LCC: Add missing C/CXX compiler version checks for -std options 76a0a67026 GetPrerequisites: Tolerate multiple leading '/' in system library paths Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9099
| * | | | | | | | | | | Tests: Avoid procedure stack overflow in broken libc on Elbrusmakise-homura2024-01-081-8/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On E2K architecture, there is at least one known version of libc that is built with a bug that leads to a kernel error like `procedure stack could not be copied` visible in `dmesg` in several tests (and such test immediately receives `SIGSEGV` and fails). It was first detected in !8665, and after a long investigation, the culprit was finally found (MCST bugzilla internal bug 124224). Avoid running tests known to fail if such a version of libc is detected.
| * | | | | | | | | | | Tests: Improve RunCMake.export expected output matching robustnessmakise-homura2024-01-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "multiple other export sets" message may wrap lines differently depending on the path to the test.
| * | | | | | | | | | | Tests: With lfortran < 1.24 skip cases broken by incorrect filename handlingmakise-homura2024-01-083-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `lfortran` < 1.24 uses `fccn`, a Fortran-to-C converter that incorrectly handles long filenames that are more than 128 characters long; so to check if Fortran can compile something, CMake must be run in binary directory that has a name of less that 35 characters long. It is ok for typical runs line `cmake -S . -B build` or `cmake ..`, but does not work with usual CDash dashboard testing paths. All this is not a problem for modern LCC >= 1.24.
| * | | | | | | | | | | LCC: Add missing C/CXX compiler version checks for -std optionsmakise-homura2024-01-082-20/+39
| | | | | | | | | | | |
| * | | | | | | | | | | GetPrerequisites: Tolerate multiple leading '/' in system library pathsmakise-homura2024-01-081-1/+1
| | |/ / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On OS Elbrus 8.x, we see a dependency on `//usr/lib/libpcre2-8.so.0`` in the Qt4Deploy test. Recognize it as a system path.
* | | | | | | | | | | CMake Nightly Date StampKitware Robot2024-01-091-1/+1
|/ / / / / / / / / /
* | | | | | | | | | Merge topic 'link-stubs-transitively'Brad King2024-01-0812-11/+112
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2c6ec6de15 Link to transitive dependencies on stub libraries only on some linkers dd4a6dff92 Link explicitly to private transitive dependencies on stub libraries 5f1bbdb3b3 Tests: Enable RunCMake.RuntimePath test on more platforms Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9050
| * | | | | | | | | | Link to transitive dependencies on stub libraries only on some linkersBrad King2024-01-043-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only linkers that enforce `--no-allow-shlib-undefined` recursively need to link private transitive dependencies on stub libraries explicitly.
| * | | | | | | | | | Link explicitly to private transitive dependencies on stub librariesBrad King2024-01-0410-3/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We represent stub libraries, e.g., for CUDA, using imported `SHARED` library targets with only `IMPORTED_IMPLIB`, and no `IMPORTED_LOCATION`, to indicate that the stub file is meant only for linkers and not dynamic loaders. See commit 7351d590ee (cmTarget: Add a way to represent imported shared library stubs, 2023-07-17, v3.28.0-rc1~344^2) and commit fc6508921c (cmComputeLinkInformation: Restore soname lookup for non-imported targets, 2023-12-05, v3.28.0~4^2). If a shared library is linked to a stub, it has a `NEEDED` field populated with the `SONAME` found in the stub. When a dependent target links to such a shared library, some linkers want to find a library file on disk and load it to see what symbols it provides. This is necessary for linkers that enforce `--no-allow-shlib-undefined`. On hosts with only the stub library installed, e.g., with only the CUDA toolkit development package, the real runtime library corresponding to the stub's `SONAME` may not even exist, so no `-rpath-link` flag can help linkers find it. Pass the stub library to linkers explicitly so they can find it without searching.
| * | | | | | | | | | Tests: Enable RunCMake.RuntimePath test on more platformsBrad King2024-01-042-9/+11
| | |_|_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Move the "ELF" check to specific cases inside the test.
* | | | | | | | | | Merge topic 'fix-isspace-usage-for-signed-char'Brad King2024-01-081-1/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5e8c176e2a cmExecuteProcessCommand: Cast c to unsigned char before cast to int Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9132
| * | | | | | | | | | cmExecuteProcessCommand: Cast c to unsigned char before cast to intleha-bot2024-01-051-1/+5
| | |_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As the 'char' type may be either signed, or unsigned, there are some clashes between C Standard library functions and actual characters while casting it to int directly. In case the 'char' type was signed, the casted to int result value may be extended to full negative digit which may be out of range of isspace() function (e.g. , for MSVC implementation, which checks it for '> -1', and throwing an assertion failure on fail). Fixes: #25561
* | | | | | | | | | Merge topic 'fix-tutorial'Brad King2024-01-083-6/+6
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6d48bd21ac Tutorial: Clarify the expected change to target_include_directories 4d56db038d Tutorial: Make `INSTALL_DESTINATION` consistent with installed destination da22b269b2 Tutorial: Add missing `$` in generator expression Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9120
| * | | | | | | | | | Tutorial: Clarify the expected change to target_include_directoriesKevin Albertson2024-01-051-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The expectation is to modify the existing `target_include_directories`, not add add a new `target_include_directories` command.
| * | | | | | | | | | Tutorial: Make `INSTALL_DESTINATION` consistent with installed destinationKevin Albertson2024-01-051-1/+1
| | | | | | | | | | |
| * | | | | | | | | | Tutorial: Add missing `$` in generator expressionKevin Albertson2024-01-051-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Merge topic 'add_test-CROSSCOMPILING_EMULATOR-exclusive'Brad King2024-01-082-1/+3
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 63e20653f8 add_test: Fix version of CMake introducing CMP0158 (to 3.29) Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9134
| * | | | | | | | | | | add_test: Fix version of CMake introducing CMP0158 (to 3.29)Robert Maynard2024-01-052-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was missed in commit ca5a300d7f (add_test: Honor CROSSCOMPILING_EMULATOR only when cross-compiling, 2023-11-02) when it slipped from the 3.28 release.
* | | | | | | | | | | | Merge topic 'cmake-gui_better_text_with_preset'Brad King2024-01-083-1/+6
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9d13674337 cmake-gui: Hint that the preset compilers will be used Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Acked-by: Alex <leha-bot@yandex.ru> Merge-request: !9125
| * | | | | | | | | | | | cmake-gui: Hint that the preset compilers will be usedRobert Maynard2024-01-053-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of stating that the default is the native compilers, say we will use the compilers from the preset. This makes it more clear that the preset is working as expected.
* | | | | | | | | | | | | Merge topic 'cmake-gui_support_preset_toolchain'Brad King2024-01-081-37/+59
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 370370364b cmake-gui: Add support for preset toolchain entry Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Acked-by: Alex <leha-bot@yandex.ru> Merge-request: !9126
| * | | | | | | | | | | | | cmake-gui: Add support for preset toolchain entryRobert Maynard2024-01-051-37/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the toolchain field was ignored when passing a preset to cmake-gui. Fixes: #24034
* | | | | | | | | | | | | | Merge branch 'release-3.28'Brad King2024-01-080-0/+0
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|_|_|/ / / | |/| | | | | | | | | | | |
| * | | | | | | | | | | | | Merge topic 'fix-openbsd' into release-3.28Brad King2024-01-083-7/+7
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1fafe35e81 Source: Restore compilation on OpenBSD Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9085
* | \ \ \ \ \ \ \ \ \ \ \ \ \ Merge topic 'fix-openbsd'Brad King2024-01-083-7/+7
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1fafe35e81 Source: Restore compilation on OpenBSD Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9085
| * | | | | | | | | | | | | | Source: Restore compilation on OpenBSDRafael Sadowski2024-01-053-7/+7
| |/ / / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot use `OpenBSD` as a name, it is defined in `sys/param.h`.
* | | | | | | | | | | | | | CMake Nightly Date StampKitware Robot2024-01-081-1/+1
| |_|_|_|_|_|_|/ / / / / / |/| | | | | | | | | | | |
* | | | | | | | | | | | | CMake Nightly Date StampKitware Robot2024-01-071-1/+1
| |_|_|_|_|_|_|/ / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | CMake Nightly Date StampKitware Robot2024-01-061-1/+1
| |_|_|_|_|/ / / / / / |/| | | | | | | | | |
* | | | | | | | | | | Merge topic 'FindPkgConfig-caching'Brad King2024-01-051-0/+6
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e50aaf8547 FindPkgConfig: Update cache variables after isystem extraction 8fe6196714 FindPkgConfig: Update cache variables after framework extraction Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !9109
| * | | | | | | | | | | FindPkgConfig: Update cache variables after isystem extractionKai Pastor2024-01-041-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #25377
| * | | | | | | | | | | FindPkgConfig: Update cache variables after framework extractionKai Pastor2023-12-281-0/+3
| | | | | | | | | | | |
* | | | | | | | | | | | Merge topic 'swift-always-restat'Brad King2024-01-054-2/+14
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1161ad76ac Swift/Ninja: Always restat swift build commands Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !9076
| * | | | | | | | | | | | Swift/Ninja: Always restat swift build commandsJeremy Day2024-01-044-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The swift toolchain leaves output files untouched if there are no meaningful input changes; without restat, this causes ninja to needlessly rebuild targets that are not actually out-of-date Fixes: #25496
* | | | | | | | | | | | | Merge topic 'swift-compile-commands'Brad King2024-01-055-20/+128
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 44f29a4291 Swift/Ninja: Fix multifile module compile commands Acked-by: Kitware Robot <kwrobot@kitware.com> Tested-by: buildbot <buildbot@kitware.com> Merge-request: !9095
| * | | | | | | | | | | | Swift/Ninja: Fix multifile module compile commandsEvan Wilde2024-01-035-20/+128
| | |_|_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Swift compile commands need to have all source files in the module specified in the compile command or LSP systems will report errors on missing types that are defined in other source files in the same module. Issue: #25491
* | | | | | | | | | | | Merge topic 'ccmake_support_preset_toolchain'Brad King2024-01-051-0/+5
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d20c21a678 ccmake: Now supports the preset toolchain entry Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Acked-by: Alex <leha-bot@yandex.ru> Merge-request: !9127
| * | | | | | | | | | | | ccmake: Now supports the preset toolchain entryRobert Maynard2024-01-031-0/+5
| | |_|_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the toolchain field was ignored when passing a preset to ccmake.