summaryrefslogtreecommitdiffstats
path: root/Help/dev/review.rst
Commit message (Collapse)AuthorAgeFilesLines
* Help: Document the expire and external discussion resolve statesCraig Scott2019-05-301-7/+68
| | | | | | Our practice of closing MRs temporarily while discussion takes place in a separate issue isn't always well understood by MR authors. Expiring a MR seems to be better understood, but making it clear that it is also a temporary state is helpful.
* Help: prefer commit hashes in commit referencesBen Boeckel2019-01-251-5/+14
| | | | | | | | | | | The logic is that the describe output is readily available using `git tag --contains` locally. In addition, for a hypothetical commit which landed in both v3.9.4 and v3.10.1, there is no "better" tag to refer to. since v3.10.0's relation to such a commit is unclear either way. Also mention that a `Fixes` trailer is preferred if the mention is just to indicate a commit which introduced an error rather than writing a complete sentence about it.
* Help/dev: Document where topic stage branch is heldBrad King2018-12-191-0/+8
|
* Help: Clarify usage of Topic-renameCraig Scott2018-05-291-2/+5
|
* Help/dev: Add commit reference format to review process guideBrad King2017-08-291-0/+20
|
* Help/dev: Organize commit message instructions into subsectionsBrad King2017-08-241-0/+9
|
* Help/dev: Add commit message guidelinesCraig Scott2017-08-081-0/+48
|
* Help/dev: Document buildbot lint-iwyu-tidy builderBrad King2017-05-301-1/+6
| | | | | This builder builds CMake using lint tools but does not run the test suite. Document it for reviewers to request with `Do: test -i lint`.
* Help/dev: note that unstaging before an update is unnecessaryBen Boeckel2017-05-171-0/+4
|
* Help/dev: Document preferred page for MR commentsBrad King2017-04-061-0/+4
|
* Help/dev: Document `Do: reformat` actionBrad King2017-03-221-0/+16
|
* Help/dev: Make `Do: check` cross-reference more specificBrad King2017-03-221-1/+4
| | | | Add a dedicated subsection header for its documentation.
* Help/dev: Document `Topic-rename:` description trailerBrad King2017-03-211-0/+7
|
* Help/dev: mention how the robot performs its checksBen Boeckel2017-03-211-3/+8
| | | | Fixes: #16264.
* Help/dev: Document the CMake Testing ProcessBrad King2017-03-071-8/+10
|
* Help/dev: Document the CMake Review ProcessBrad King2017-03-031-0/+304