| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6d48bd21ac Tutorial: Clarify the expected change to target_include_directories
4d56db038d Tutorial: Make `INSTALL_DESTINATION` consistent with installed destination
da22b269b2 Tutorial: Add missing `$` in generator expression
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !9120
|
| |
| |
| |
| |
| | |
The expectation is to modify the existing `target_include_directories`,
not add add a new `target_include_directories` command.
|
| | |
|
| | |
|
|/
|
|
|
|
|
| |
- TODO 6 has to be Link SqrtLibrary
- TODO 7 has to be Link MathFunctions
Signed-off-by: Bhavith C <bhavithc.acharya@gmail.com>
|
|
|
|
|
|
|
| |
* Fix typo in Step 2
* Fix incorrect code referenced in Step 3, TODO 7. Update comments in
MathFunctions/CMakeLists.txt to unique strings.
* Resolve inconsistencies between steps in MathFunctions/CMakeLists.txt
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The solution for step 7 todo 5 did not include all of the code changes.
Modify it to include the needed `#endif` code change.
|
|
|
|
|
| |
During the training, we talk about INTERFACE libraries just before Step3
so it makes more sense to do the exercise related to them in Step3
|
| |
|
|
|
|
|
|
|
| |
Propagate the refactor in Step 10 MathFunctions through all of the
steps. Use MathFunctions/MathFunctions.cxx instead of Tutorial.cxx
to determine which sqrt library is called. Adds .h files which
correspond to their .cxx files by name.
|
| |
|
|
|
|
|
| |
The solution in Step 11 sets POSITION_INDEPENDENT_CODE to
`${BUILD_SHARED_LIBS}`, rather than simply to "True" in all cases.
|
|
|
|
|
| |
The link in Step 6 (to "Testing Support") clearly refers to Exercise 2.
Fix the location to which the link jumps.
|
|
|
|
|
| |
If you look at the solution for Step 6, you will see `0.0001` rather
than `0.00001` used for the last test case. Fix the typo.
|
| |
|
|
|
|
|
| |
When mention execitable names use Sphinx semantic role `:program`
instead of ``executable`` or **executable**.
|
|\
| |
| |
| |
| |
| |
| |
| | |
f9ef15f3dc Tutorial: Update step 7 style
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7787
|
| | |
|
|/
|
|
|
|
| |
Since commit 6e58a01f4e (Tutorial: Update step 6 style, 2022-10-06) the
`literalinclude` included an extra comment from step 6 instructions.
Fix the include bounds to remove the extra text.
|
|\
| |
| |
| |
| |
| |
| |
| | |
6e58a01f4e Tutorial: Update step 6 style
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7756
|
| | |
|
| |
| |
| |
| |
| |
| | |
In commit 80f5d28813 (Tutorial: Update step 2 style, 2022-07-25,
v3.25.0-rc1~226^2) we replaced some uses of `USE_MYMATH` with `MY_MATH`.
Restore the former name for consistency with the rest of the tutorial.
|
| | |
|
|/
|
|
| |
`CMAKE_CXX_REQUIRED_STANDARD` => `CMAKE_CXX_STANDARD_REQUIRED`
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
37fceb6fd3 Tutorial: Update step 4 style
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7646
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Augment vague mentions of "Transitive Usage Requirements" with links to
a detailed explanation.
Fixes: #23799
|
|/
|
|
| |
Fixes: #23918
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
ccba87b05b Tutorial: Move step 10 to step 4
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !7506
|
| |
| |
| |
| | |
Shifts steps 4-9 to 5-10.
|
| | |
|
|/ |
|
|\
| |
| |
| |
| |
| |
| | |
6c77ccec51 Tutorial: Move step 8 to step 5. Shift steps 5-7 to 6-8.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7480
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since commit 07223c5c27 (Tutorial: Update Step 5 to work on Windows,
2020-02-18, v3.18.0-rc1~655^2) the logic does not work on non-Windows
platforms when cmake is re-run on an existing build tree. It is also
more complicated than we'd like for a tutorial example. Avoid the need
to consider the `m` library case by performing the check as C++.
Since `check_cxx_symbol_exists` cannot handle overloaded functions
like `exp` and `log`, check with `check_cxx_source_compiles` instead.
This also presents a more general-purpose example in the tutorial.
Fixes: #23524
|
|
|
|
|
|
|
|
|
| |
Provide readers following the tutorial on `cmake.org` a direct link to
download the tutorial's source examples. Previously readers had to
fetch the CMake source tree separately and look for the tutorial source
examples inside it.
Fixes: #22475
|
|
|
|
|
| |
Step 2 references mysqrt.h instead of MathFunctions.h.
MathFunctions/mysqrt.h doesn't exist until Step 9.
|
|
|
|
|
| |
Correct a tiny typo in the Step 7 tutorial. Change so `License.txt`
correctly starts with a capital `L`.
|