| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| | |
a6abb6c8 FindHDF5: Fix H5_VERSION on Patch in C
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1465
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fix a typo from commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of
compiler wrappers, 2016-04-04) that accidentally used the HDF5 C++
version (which could be empty) while detecting the C patch version.
The detection failed for patch releases, such as `1.10.0-patch1`
becoming `.1` instead of `1.10.0.1`.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some are user facing.
Found using
codespell -q 3 --skip="./Utilities" -I .cmake-whitelist.txt`
whereby the whitelist contained:
ans
dum
helpfull
emmited
emmitted
buil
iff
isnt
nto
ot
pathes
substract
te
todays
upto
whitespaces
|
|
|
|
|
| |
- some variables did not have the appropriate HL infix
- some logic was not yet implemented for HL
|
|
|
|
|
| |
prefixed some local variables with _hdf5 and unset them at the end
(still more of these to do)
|
|
|
|
|
| |
first check the LOCATION_<CONFIG> propertiy to find the library, then
LOCATION
|
|
|
|
|
|
|
|
|
|
| |
Select a configuration as the first of the following available:
* MAP_IMPORTED_CONFIG_<CONFIG>
* ${CMAKE_BUILD_TYPE}, RELWITHDEBINFO, RELEASE, DEBUG
* First entry in IMPORTED_CONFIGURATIONS
Fixes: #17039
|
|
|
|
|
|
| |
When searching for shared libraries on Windows, add
H5_BUILT_AS_DYNAMIC_LIB to HDF5_DEFINITIONS so that the header file
knows how to dllimport the symbols.
|
|
|
|
| |
Also add the `_D` suffix for debug libraries.
|
|
|
|
|
|
|
|
|
|
|
| |
This is covering a different use case where your primary compilers are
HDF5 wrappers, as is the case when using the Cray Programming
Environment. The existing code tries to query the compiler using options
only available to h5cc and friends, which doesn't work when your wrapper
is not h5cc, as is the case with the CrayPE. This change instead pulls
strings out of a test binary when testing for "is your regular compiler
an HDF5 wrapper" while the "query wrapper for options" is reserved for
the "I found the hdf5 wrappers but they're not your main compiler" mode.
|
| |
|
|\
| |
| |
| | |
FindHDF5-optional-no-config
|
| |
| |
| |
| |
| |
| |
| |
| | |
Some projects may not be prepared to use the imported targets defined by
the HDF5 package configuration file. Give users a way to skip this part
of the search.
Issue: #16718
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
8214061d FindHDF5: fix quoting
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !587
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In the case that we're using `find_path` to find the include directory,
only the `_DIR` variable was set, while in all other cases only the
`_DIRS` variable was set. Set the `_DIRS` variable in all cases (while
keeping `_DIR` as result of `find_path`). Also document the `_DIRS`
variable.
Fixes: #16694
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
ea2a8dd2 FindHDF5: Restore `-D` in HDF5_DEFINITIONS
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !554
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Changes in commit v3.8.0-rc1~7^2~5 (FindHDF5: Fix command-line parsing
argument extraction order, 2017-02-02) accidentally dropped `-D` from
preprocessor definition flags extracted from the HDF5 compiler wrappers.
Fixes: #16693
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The `LOCATION` of imported shared libraries on Windows is that of the
`.dll`. Use the import library instead to get the `.lib` to be linked.
Fixes: #16534
|
| |
| |
| |
| |
| | |
The imported targets provide a persistent reference of their location,
so we do not need to cache the values.
|
| |
| |
| |
| | |
Some versions of HDF5 use this prefix on their imported targets.
|
| | |
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactoring in commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of
compiler wrappers, 2016-04-04) converted code of the form
if(${LANGUAGE} MATCHES ...)
to
if(LANGUAGE MATCHES ...)
However, `LANGUAGE` is a foreach() loop variable and not a normal
variable so auto-dereference does not occur. Restore the explicit `${}`
syntax and use the new name of the loop variable that has changed since
then too.
Fixes: #16651
|
|
|
|
|
|
|
|
|
| |
Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
to correctly find HL for all bindings, 2016-05-12) renamed the language
loop variable used to construct the name of `HDF5_<LANG>_INCLUDE_DIR`
but forgot to update it in the `mark_as_advanced` call. Fix it now.
Issue: #16651
|
|
|
|
|
|
|
|
|
| |
This compatibility variable should be set no matter which method was
used to find HDF5. Even if `HDF5_INCLUDE_DIRS` was set by copying the
`HDF5_INCLUDE_DIR` value from `hdf5-config.cmake` it will not hurt to
copy the same value back.
Issue: #16566
|
|
|
|
|
|
|
|
|
|
|
| |
Since commit v3.6.1~6^2~2 (FindHDF5: Fix h5cc arg parsing to work with
homebrew on Mac, 2016-07-11) we treated `HDF5_USE_STATIC_LIBRARIES` OFF
as a requirement for shared libraries. It is just supposed to be a
preference. Even if `HDF5_USE_STATIC_LIBRARIES` is not set we should
still fall back to finding static libraries if shared libraries are not
available.
Issue: #16566
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
to correctly find HL for all bindings, 2016-05-12) turned off a large
amount of its logic when HDF5_ROOT is set. This caused use of the hdf5
compiler wrapper to extract all needed libraries (e.g. z, dl as
dependencies of hdf5 static libraries) to be skipped when using
HDF5_ROOT.
Fix the search logic to honor HDF5_ROOT in all code paths. Restrict the
search for hdf5-specific components to this root, but allow external
libraries to be found anywhere.
Fixes: #16566
|
|
|
|
| |
Clarify the purpose of each argument.
|
|
|
|
| |
While at it, use a more private name.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-implement our internal `_HDF5_parse_compile_line` helper to process
command line arguments all at once and in order. Otherwise the
libraries named by absolute path and those named by `-l` arguments are
not kept in order.
The new implementation will not handle separate arguments like
`-I /path/to/include/dir` but I have not seen the HDF5 compiler
wrappers produce this form. If necessary the parsing loop can
be extended with a state variable to keep track of such pairs.
|
|
|
|
|
| |
On Windows, the `LOCATION` property gets the path to the `.dll` rather
than the `.lib` which is unsuitable for linking.
|
|\
| |
| |
| |
| | |
ff3ccc1f FindHDF5: Restore pre-3.6 behavior of finding only C by default
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
to correctly find HL for all bindings, 2016-05-12) changed the default
behavior from finding only the C bindings to finding everything for the
enabled languages. Restore the original behavior for compatibility and
because many projects need only the C bindings.
Closes: #16397
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool. Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience. Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.
Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices. It also references version control
history for more precise information. Therefore we no longer need to spell
out the list of Contributors in each source file notice.
Replace CMake per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online information
available from "https://cmake.org/licensing". The online URL also handles
cases of modules being copied out of our source into other projects, so we
can drop our notices about replacing links with full license text.
Run the `Utilities/Scripts/filter-notices.bash` script to perform the majority
of the replacements mechanically. Manually fix up shebang lines and trailing
newlines in a few files. Manually update the notices in a few files that the
script does not handle.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
b61eab24 FindHDF5: Fix regression in providing HDF5_IS_PARALLEL
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since commit v3.6.0-rc1~85^2 (HDF5: Refactor the use of compiler
wrappers, 2016-04-01) we have additional code paths that find HDF5 and
suppress the original search logic. Report HDF5_IS_PARALLEL from these
other code paths too.
Closes: #16257
|
|\ \ \
| | |/
| |/|
| | |
| | | |
befe8648 FindHDF5: Fix regression in finding hdf5hl_fortran
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Refactoring in commit v3.6.0-rc1~72^2 (HDF5: Rework component searching
to correctly find HL for all bindings, 2016-05-12) accidentally dropped
the name `hdf5hl_fortran` from the list of library names and replaced it
with `hdf5_hl_fortran`. IIUC the latter name is when HDF5 is built with
CMake and the former name is for other build systems. Since this is the
non-CMake code path, user the former name.
Closes: #16233
|
|/
|
|
|
| |
References to specific comments are left as-is since comments were not
migrated.
|
| |
|
| |
|
| |
|