| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| | |
8721658959 CPack/NSIS: Fix installer not waiting for uninstaller to finish
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7774
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In commit b795c96727 (CPack/NSIS: Fix uninstall command when run from
installer, 2022-03-21, v3.23.0-rc5~9^2~1) we incorrectly removed the
`_?` parameter when calling the uninstaller during installation.
This parameter is however essential for ExecWait to actually wait for
the uninstaller to finish. Without it, the uninstaller is started in
the background and installer and uninstaller run at the same time.
See https://nsis.sourceforge.io/Docs/Chapter3.html#installerusageuninstaller
Add back the `_?` parameter to fix this regression. Use another
approach to solve the problem motivating the original change.
Fixes: #24041
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
5d2ceaada8 CPack/NSIS: Add support for unquoted (legacy) uninstaller strings
b795c96727 CPack/NSIS: Fix uninstall command when run from installer
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7096
|
| | | |
|
|\ \ \
| |/ /
|/| /
| |/
| |
| |
| |
| | |
5d2ceaada8 CPack/NSIS: Add support for unquoted (legacy) uninstaller strings
b795c96727 CPack/NSIS: Fix uninstall command when run from installer
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !7096
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The quoting introduced by commit eb3b3bacdc (CPack/NSIS: Fix uninstall
on Windows using "Apps & Features", 2021-09-13, v3.22.0-rc1~136^2)
created two errors in the uninstaller call: double quoting of the
uninstaller executable, and quotes added to the `_?=` argument which
does not support them. Simplify the command.
|
|/
|
|
| |
Fixes: #23151
|
|
|
|
|
|
|
|
| |
According to NSIS documentation [1], uninstaller executable path in
UninstallString must always be quoted. Quote the uninstall executable
in `NSIS.template.in` so that it works when the path has spaces.
[1] https://nsis.sourceforge.io/Add_uninstall_information_to_Add/Remove_Programs
|
|
|
|
| |
Fixes: #22215
|
|
|
|
| |
Fixes: #22382
|
|
|
|
|
|
|
|
|
| |
If a previous installation was detected by the NSIS script the
uninstaller was not correctly run unless it was still named
`Uninstall.exe`. This meant that using `CPACK_NSIS_UNINSTALL_NAME`
was simply broken.
Fixes: #22103
|
|
|
|
|
|
|
| |
See https://nsis.sourceforge.io/Reference/BrandingText
for more information.
Fixes: #21479
|
|
|
|
| |
Fixes: #21318
|
|
|
|
|
|
|
| |
See https://nsis.sourceforge.io/Reference/ManifestDPIAware
for more information.
Fixes: #17724
|
|
|
|
|
| |
This is currently used to provide
UserInfo::GetName and UserInfo::GetAccountType functions.
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSIS packages files (including those required by the installer itslef)
in the order in which they're mentioned in the .nsi file.
If solid compression is used, the installer might need to extract
large parts of the archive to be able to even start the setup program
("Please wait while setup is loading...").
Avoid this by moving component installation towards the end of the
template file.
|
|
|
|
| |
Fixes: #11275
|
|
|
|
| |
Fixes: #10728
|
|
Some commits ago all CPack internal `*.cmake` files have been moved
to `Internal/CPack/`. This commit also move some templates
internally used by generators to the same location to make
`Modules/` directory less noisy w/ files the end users don't
need to use/see.
|