summaryrefslogtreecommitdiffstats
path: root/Source/CPack/IFW
Commit message (Collapse)AuthorAgeFilesLines
* CMake code rely on cmList class for CMake lists management (part. 2)Marc Chevrier2023-04-292-4/+5
|
* cmList class: various enhancementsMarc Chevrier2023-04-291-6/+6
|
* CMake code rely on cmList class for CMake lists management (part. 1)Marc Chevrier2023-04-243-11/+12
|
* cmValue: Use operator* explicitly to convert to std::string; avoid extra callVitaly Stakhovsky2023-01-163-22/+24
|
* clang-tidy: address `modernize-use-default-member-init` lintsBen Boeckel2022-05-241-2/+1
|
* style: use `cmStrCat` in some more locationsBen Boeckel2022-05-191-1/+1
|
* CPackIFW: Fix regression in icon file namesJean-Philippe Lebel2022-04-141-3/+3
| | | | | | | | Changes in commit 761b6e2466 (CPackIFW: Avoid colliding names for icons / logos, 2021-10-08, v3.23.0-rc1~546^2) accidentally left an extra `.` in computed file names. Remove it. Fixes: #23423
* CPack/IFW: Add missing referenced source file validationCraig Scott2022-03-251-2/+22
|
* Merge topic 'ifw-sign-installer'Brad King2021-12-023-0/+23
|\ | | | | | | | | | | | | | | e8e07a90c1 CPackIFW: add support for signing the generated app bundles on macOS Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !6754
| * CPackIFW: add support for signing the generated app bundles on macOSErlend E. Aasland2021-11-223-0/+23
| | | | | | | | | | | | | | | | Adds the CPACK_IFW_PACKAGE_SIGNING_IDENTITY CPackIFW variable. This variable mirrors the --sign option of the binarycreator tool. Fixes: #22927
* | Source: Cleanup and simplify some codeRose2021-11-042-6/+6
|/
* CPackIFW: add support for archive format and compression level optionsErlend E. Aasland2021-10-282-0/+32
| | | | | | | | | | | | | | | Adds the following CPackIFW variables: - CPACK_IFW_ARCHIVE_FORMAT - CPACK_IFW_ARCHIVE_COMPRESSION These variables control mirror the --archive-format and --compression options of the QtIFW binarycreator and repogen tools. Fixes: #22803 Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no> Co-authored-by: Awen Autret
* Source: Simplify some boolean expressionsRose2021-10-231-5/+4
|
* CPackIFW: Add support for RunProgram* config variablesErlend E. Aasland2021-10-172-0/+44
| | | | | | This patch adds support for specifying <RunProgram>, <RunProgramArguments>, and <RunProgramDescription> in the IFW configuration file.
* Merge topic 'ifw-installer-icon-filenames'Craig Scott2021-10-151-4/+12
|\ | | | | | | | | | | | | 761b6e2466 CPackIFW: Avoid colliding names for icons / logos Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !6613
| * CPackIFW: Avoid colliding names for icons / logosErlend E. Aasland2021-10-141-4/+12
| | | | | | Fixes: #16515
* | CPackIFW: Add support for DisableCommandLineInterface config attributeKonstantin Podsvirov2021-10-142-0/+19
|/
* Merge topic 'ifw-refactor-packagefiles'Brad King2021-10-132-166/+203
|\ | | | | | | | | | | | | | | c50329d3ed CPackIFW: Refactor cmCPackIFWGenerator::PackageFiles Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !6617
| * CPackIFW: Refactor cmCPackIFWGenerator::PackageFilesErlend E. Aasland2021-10-112-166/+203
| | | | | | | | | | | | | | | | | | | | | | Split PackageFiles() into four methods, for increased readability: - cmCPackIFWGenerator::BuildRepogenCommand - cmCPackIFWGenerator::BuildBinaryCreatorCommand - cmCPackIFWGenerator::RunRepogen - cmCPackIFWGenerator::RunBinaryCreator Fixes: #22744
* | Merge topic 'ifw-product-images'Brad King2021-10-132-0/+22
|\ \ | | | | | | | | | | | | | | | | | | | | | 6d39c845ee CPackIFW: Add support for ProductImages config option Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: buildbot <buildbot@kitware.com> Merge-request: !6611
| * | CPackIFW: Add support for ProductImages config optionErlend E. Aasland2021-10-082-0/+22
| |/
* | CPackIFW: Add version guard for configuration attributesErlend E. Aasland2021-10-081-77/+86
|/ | | | Fixes: #22736
* Rename cmProp in cmValueMarc Chevrier2021-09-216-86/+89
|
* cmSystemTools::VersionCompare: use std::string for argumentsMarc Chevrier2021-09-171-5/+3
|
* Use new SetOption signaturesMarc Chevrier2021-09-151-1/+1
|
* cmCPackGenerator::GetOption returns cmPropMarc Chevrier2021-09-136-149/+147
|
* CPackIFW: Fix parsing of name and version in component DEPENDSCraig Scott2021-03-261-32/+77
| | | | | | | | | | | | | | | | The DEPENDS or DEPENDENCIES arguments in a call to cpack_ifw_configure_component() or cpack_ifw_configure_component_group() specify a name and optionally a version constraint as a single string. QtIFW also allows a colon (requires QtIFW 3.1 or later) or a hyphen to separate the name and version. The version may optionally contain a leading operator, with = being assumed when no operator is present. The previous code was not handling : as a separator at all and was erroneously dropping the version part when no operator was given. Fix both of those non-conforming behaviors and also warn if trying to use a hyphen in a name with a QtIFW version that isn't recent enough to support it. Fixes: #21697
* CPackIFW: Remove redundant variable assignmentCraig Scott2021-03-241-1/+1
| | | This was showing up in cppcheck results.
* CPackIFWInstaller: Avoid potential null pointer dereferenceCraig Scott2021-02-191-2/+9
| | | | | | | | In d16830324f (CPackIFW: Improve warning and docs for show page list option, 2021-02-14), code was added to report the current QtIFW version. That code didn't check that there was a Generator object before using it, resulting in a scanbuild warning about a potential null pointer dereference. Add a check and output a more general warning message if we don't have the current QtIFW version available to report.
* CPackIFW: Improve warning and docs for show page list optionCraig Scott2021-02-141-3/+5
|
* CPackIFW: Fix cppcheck warningsCraig Scott2021-02-141-3/+4
| | | | | | The cppcheck warnings about uninitialised variables are likely harmless, since they are initialised in ParseResource() anyway. Fix the warnings anyway to reduce linting noise. The warning about a single argument non-explicit constructor is worth fixing in general.
* clang-tidy: fix `readability-make-member-function-const` warningsBen Boeckel2021-01-274-12/+12
|
* Code style: add missed explicit 'this->'Oleksandr Koval2021-01-054-13/+13
| | | | | CMake uses explicit 'this->' style. Using custom clang-tidy check we can detect and fix places where 'this->' was missed.
* CPackIFW: Add CPACK_IFW_PACKAGE_WIZARD_SHOW_PAGE_LIST variableKonstantin Podsvirov2020-11-272-0/+29
| | | | | | Add CPACK_IFW_PACKAGE_WIZARD_SHOW_PAGE_LIST variable to control visibility of the widget listing installer pages on the left side of the wizard. This feature available only since QtIFW 4.0.
* Modernize: Use #pragma once in all header filesKitware Robot2020-09-035-20/+5
| | | | | | | | | | | | | | | | #pragma once is a widely supported compiler pragma, even though it is not part of the C++ standard. Many of the issues keeping #pragma once from being standardized (distributed filesystems, build farms, hard links, etc.) do not apply to CMake - it is easy to build CMake on a single machine. CMake also does not install any header files which can be consumed by other projects (though cmCPluginAPI.h has been deliberately omitted from this conversion in case anyone is still using it.) Finally, #pragma once has been required to build CMake since at least August 2017 (7f29bbe6 enabled server mode unconditionally, which had been using #pragma once since September 2016 (b13d3e0d)). The fact that we now require C++11 filters out old compilers, and it is unlikely that there is a compiler which supports C++11 but does not support #pragma once.
* IWYU: mark <cstddef> as neededBen Boeckel2020-04-291-1/+1
| | | | Newer IWYU is not seeing them as needed for `size_t`.
* clang-tidy: address bugprone-branch-clone lintsBen Boeckel2020-04-131-4/+0
| | | | | | | | | Arguably, many of these are bugs in `clang-tidy`. An if/else tree with other conditionals between cloned blocks may be relying on the intermediate logic to fall out of the case and inverting this logic may be non-trivial. See: https://bugs.llvm.org/show_bug.cgi?id=44165
* replace "substr(0, xx) ==" with cmHasPrefix()Rolf Eike Beer2020-03-231-8/+2
|
* remove needless check for std::string::substr()Rolf Eike Beer2020-03-231-2/+1
| | | | Passing npos is legal and means "rest of the string".
* Revise include order using clang-format-6.0Kitware Robot2019-10-019-30/+30
| | | | | Run the `clang-format.bash` script to update our C and C++ code to a new include order `.clang-format`. Use `clang-format` version 6.0.
* clang-tidy: modernize-deprecated-headersRegina Pfeifer2019-09-163-3/+3
|
* clang-tidy: modernize-use-autoRegina Pfeifer2019-09-102-20/+14
| | | | | | Set the MinTypeNameLength option to an impossibly high value in order to limit the diagnostics to iterators. Leave new expressions and cast expressions for later.
* clang-tidy: Replace typedef with usingRegina Pfeifer2019-09-043-9/+9
| | | | | | | | Automate the conversion with perl -i -0pe 's/typedef ([^;]*) ([^ ]+);/using $2 = $1;/g' then manually fix a few places.
* IWYU: Add missing cstddef includes for size_t and nullptr_tBrad King2019-09-031-0/+1
| | | | The IWYU tool we use for CI now diagnoses these.
* CPack/IFW: Command vectorizationKonstantin Podsvirov2019-08-271-47/+72
| | | | Fixes: #19634
* Source sweep: Replace cmExpandList with the shorter cmExpandedListSebastian Holtermann2019-08-233-8/+4
| | | | | | | | | | | | This replaces the code pattern ``` std::vector<std::string> args; cmExpandList(valueStr, args, ...) ``` with ``` std::vector<std::string> args = cmExpandedList(valueStr, ...) ```
* Source sweep: Use cmStrCat for string concatenationSebastian Holtermann2019-08-222-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is generated by a python script that uses regular expressions to search for string concatenation patterns of the kind ``` std::string str = <ARG0>; str += <ARG1>; str += <ARG2>; ... ``` and replaces them with a single `cmStrCat` call ``` std::string str = cmStrCat(<ARG0>, <ARG1>, <ARG2>, ...); ``` If any `<ARGX>` is itself a concatenated string of the kind ``` a + b + c + ...; ``` then `<ARGX>` is split into multiple arguments for the `cmStrCat` call. If there's a sequence of literals in the `<ARGX>`, then all literals in the sequence are concatenated and merged into a single literal argument for the `cmStrCat` call. Single character strings are converted to single char arguments for the `cmStrCat` call. `std::to_string(...)` wrappings are removed from `cmStrCat` arguments, because it supports numeric types as well as string types. `arg.substr(x)` arguments to `cmStrCat` are replaced with `cm::string_view(arg).substr(x)`
* Source sweep: Use cmIsOn instead of cmSystemTools::IsOnSebastian Holtermann2019-08-171-4/+4
| | | | | | | | | This replaces invocations of - `cmSystemTools::IsInternallyOn` with `cmIsInternallyOn` - `cmSystemTools::IsNOTFOUND` with `cmIsNOTFOUND` - `cmSystemTools::IsOn` with `cmIsOn` - `cmSystemTools::IsOff` with `cmIsOff`
* Source code: Use cmExpandList instead of cmSystemTools::ExpandListArgumentSebastian Holtermann2019-08-144-16/+18
|
* cmStringAlgorithms: cmIsSpace, cmTrimWhitespace, cmEscapeQuotes, cmTokenizeSebastian Holtermann2019-08-051-1/+2
| | | | | | | | | | This adds the following functions to `cmStringAlgorithms`: - `cmIsSpace` - `cmTrimWhitespace` (moved from `cmSystemTools::TrimWhitespace`) - `cmEscapeQuotes` (moved from `cmSystemTools::EscapeQuotes`) - `cmTokenize` (moved from `cmSystemTools::tokenize` and adapted to accept `cm::string_view`)