summaryrefslogtreecommitdiffstats
path: root/Source/CPack/cmCPackDebGenerator.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Source: Cleanup and simplify some codeRose2021-11-041-2/+2
|
* Merge topic 'fix-ifdef-windows'Brad King2021-10-181-1/+1
|\ | | | | | | | | | | | | 40e73c5ac4 Source: Fix typo in _WIN32 preprocessor checks Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !6631
| * Source: Fix typo in _WIN32 preprocessor checksBrad King2021-10-151-1/+1
| | | | | | | | | | | | | | | | | | | | Since CMake's default compiler flags with MSVC include `-DWIN32` for historical reasons, a few preprocessor conditions were accidentally checking for `WIN32` instead of `_WIN32`. The corresponding blocks were left out when compiling official binaries for `cmake.org` because we hard-code compiler flags without `-DWIN32`. Fixes: #22764
* | Rename cmProp in cmValueMarc Chevrier2021-09-211-31/+31
| |
* | Use new SetOption signaturesMarc Chevrier2021-09-151-13/+9
| |
* | cmCPackGenerator::GetOption returns cmPropMarc Chevrier2021-09-131-74/+73
| |
* | cmArchiveWrite: Check for construction errors on OpenBrad King2021-08-201-3/+21
| | | | | | | | | | | | Also update call sites to report the error. Issue: #19666
* | CPack/DEB: Add zstd compression for deb packagesRussell Greene2021-07-291-0/+3
| |
* | Refactor: Drop redundand `std::endl` calls in the middle of outputAlex Turbov2021-07-131-36/+52
| |
* | Refactor: Use `cmStrToLong` instead of `std::strtol`Alex Turbov2021-07-131-18/+17
| |
* | Refactor: Avoid duplicate calls to `GetOption("GEN_DBGSYMDIR")`Alex Turbov2021-07-131-9/+11
| |
* | Refactor: Deduplicate code of `createDebPackages()`Alex Turbov2021-07-131-22/+19
| | | | | | | | Also, fix incorrect `retval` accumulation.
* | CPack/DEB: dbgsym package not generated for non-component packagingAlex Turbov2021-07-131-45/+36
| | | | | | | | Fix: #19735
* | Refactor: Extract packaged files finder into a functionAlex Turbov2021-07-131-45/+34
| |
* | Refactor: cmCPackDebGenerator::PackageComponents handle `else` firstAlex Turbov2021-07-131-27/+27
| | | | | | | | Also, return early to reduce nesting level of the function body.
* | Refactor: Change return value to bool for private membersAlex Turbov2021-07-131-18/+7
| | | | | | | | | | The `cmCPackDebGenerator::createDeb()` and `cmCPackDebGenerator::createDbgsymDDeb()` in fact have boolean return value.
* | Refactor: Drop unnecessary `if` before `return`Alex Turbov2021-07-131-8/+2
| |
* | Refactor: Drop useless assignments of `retval` before returnAlex Turbov2021-07-131-4/+2
| |
* | CPackDeb: sort package files before generating deb fileAlexey Rogachevskiy2021-06-301-0/+7
| | | | | | | | | | | | | | This should make the order in which the files are added to md5sums and archives is stable, thus making package files more reproducible. Fixes: #22361
* | cmCPackDebGenerator: Remove unused local variableBrad King2021-04-281-1/+0
| |
* | cmArchiveWrite: Consolidate multiple ways to set thread countNils Gladitz2021-04-221-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Merge use of SetFilterOption() into more abstract thread count in cmArchiveWrite constructor. libarchive defaulting of threads for threads == 0 seems to be configuration dependent. Preemptively default thread count via std::thread::hardware_concurrency(). Also allow negative values for the thread count in which case the detected hardware concurrency is also used but the given absolute thread count is used as an upper limit.
* | CPack: add CPACK_THREADS variable to control compression threadsRodolfo Lima2021-01-261-3/+25
| | | | | | | | | | | | | | This allows setting how many threads the compressor will use. Currently only implemented for XZ when using system's lzma library. Fixes: #21715
* | cpack(DEB): Issue warning if custom script for control file is missingAsit Dhal2021-01-151-0/+9
| | | | | | | | Fixes: #17794
* | Code style: add missed explicit 'this->'Oleksandr Koval2021-01-051-88/+95
| | | | | | | | | | CMake uses explicit 'this->' style. Using custom clang-tidy check we can detect and fix places where 'this->' was missed.
* | CPack/DEB: Do not crash when asked for debug symbols when there are noneAndrew Fuller2020-11-161-1/+2
|/ | | | Fixes: #21356
* Source: use cmNonempty()Vitaly Stakhovsky2020-07-281-14/+14
|
* CPack: Fix newline output in .deb generatorKyle Edwards2020-04-301-11/+15
| | | | | | | When running CPack on Windows, LF newlines are converted to CRLF unless binary mode is used. Use binary mode whenever possible. Fixes: #20659
* Merge topic 'cpack-symlinks'Brad King2020-04-221-0/+3
|\ | | | | | | | | | | | | bcc5cd44ed CPack: Do not recurse through directory symlinks Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4637
| * CPack: Do not recurse through directory symlinksBrad King2020-04-211-0/+3
| | | | | | | | | | | | | | | | Extend the fix from commit 7b8dcdd173 (CPack: Do not recurse through directory symlinks (#12284), 2011-08-27, v2.8.6~55^2) to more places in CPack. Issue: #12284
* | cmArchiveWrite: split out opening the fileBen Boeckel2020-03-311-0/+3
|/ | | | | This allows options to be set before the "header" phase of libarchive's API.
* Revise include order using clang-format-6.0Kitware Robot2019-10-011-10/+10
| | | | | Run the `clang-format.bash` script to update our C and C++ code to a new include order `.clang-format`. Use `clang-format` version 6.0.
* cmstd: Modernize CMake system headersMarc Chevrier2019-09-201-1/+3
| | | | | | | | | | | | | | Provide a standardized way to handle the C++ "standard" headers customized to be used with current CMake C++ standard constraints. Offer under directory `cm` headers which can be used as direct replacements of the standard ones. For example: #include <cm/string_view> can be used safely for CMake development in place of the `<string_view>` standard header. Fixes: #19491
* clang-tidy: modernize-deprecated-headersRegina Pfeifer2019-09-161-1/+1
|
* Source sweep: Replace cmExpandList with the shorter cmExpandedListSebastian Holtermann2019-08-231-2/+1
| | | | | | | | | | | | This replaces the code pattern ``` std::vector<std::string> args; cmExpandList(valueStr, args, ...) ``` with ``` std::vector<std::string> args = cmExpandedList(valueStr, ...) ```
* Source sweep: Use cmStrCat for string concatenationSebastian Holtermann2019-08-221-17/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is generated by a python script that uses regular expressions to search for string concatenation patterns of the kind ``` std::string str = <ARG0>; str += <ARG1>; str += <ARG2>; ... ``` and replaces them with a single `cmStrCat` call ``` std::string str = cmStrCat(<ARG0>, <ARG1>, <ARG2>, ...); ``` If any `<ARGX>` is itself a concatenated string of the kind ``` a + b + c + ...; ``` then `<ARGX>` is split into multiple arguments for the `cmStrCat` call. If there's a sequence of literals in the `<ARGX>`, then all literals in the sequence are concatenated and merged into a single literal argument for the `cmStrCat` call. Single character strings are converted to single char arguments for the `cmStrCat` call. `std::to_string(...)` wrappings are removed from `cmStrCat` arguments, because it supports numeric types as well as string types. `arg.substr(x)` arguments to `cmStrCat` are replaced with `cm::string_view(arg).substr(x)`
* Source sweep: Use cmIsOn instead of cmSystemTools::IsOnSebastian Holtermann2019-08-171-1/+1
| | | | | | | | | This replaces invocations of - `cmSystemTools::IsInternallyOn` with `cmIsInternallyOn` - `cmSystemTools::IsNOTFOUND` with `cmIsNOTFOUND` - `cmSystemTools::IsOn` with `cmIsOn` - `cmSystemTools::IsOff` with `cmIsOff`
* Source code: Use cmExpandList instead of cmSystemTools::ExpandListArgumentSebastian Holtermann2019-08-141-1/+2
|
* Replace use of CollapseCombinedPath with CollapseFullPathBrad King2019-03-191-1/+1
| | | | | | | | | | | `CollapseCombinedPath` was introduced by commit 551d3343cd (cmDependsC: Collapse relative include paths, 2013-06-19, v2.8.12~237^2) where the existing `CollapseFullPath` should have been used instead. Then its use proliferated slightly. Since `CollapseCombinedPath` is less widely used and less robust (see issue #19049), use `CollapseFullPath` everywhere instead. Issue: #19050
* clang-tidy: Use `= default`Regina Pfeifer2019-01-251-6/+2
| | | | | | Suppress some cases in `Source/cmGeneratorExpressionNode.cxx` and `Source/cmUVHandlePtr.h` where a few older compilers require a user-defined default constructor (with `{}`).
* clang-tidy: Pass by valueRegina Pfeifer2019-01-221-27/+23
|
* CPack/Deb: Remove paxr as a supported tar format for a .debGuillem Jover2018-11-281-1/+1
| | | | | | | | | The only format supported from the ones available within cpack is gnutar, which supports large numbers encoded in base-256, and long filenames and linknames. PAX is not and has never been a supported format by dpkg. Fixes: #18620
* CPack/Deb: Add ability to split out debug symbols into .ddeb packageAndrew Fuller2018-09-211-384/+560
|
* cmGeneratedFileStream: clang-tidy applied to remove redundant ``c_str`` callsSebastian Holtermann2018-08-071-9/+9
| | | | | | | | | | | | | | | After changing the ``cmGeneratedFileStream`` methods to accept ``std::string const&`` instead of ``const char*`` we don't need to call ``std::string::c_str`` anymore when passing a ``std::string`` to a ``cmGeneratedFileStream`` method. This patch removes all redundant ``std::string::c_str`` calls when passing a string to a ``cmGeneratedFileStream`` method. It was generated by building CMake with clang-tidy enabled using the following options: -DCMAKE_CXX_CLANG_TIDY=/usr/bin/clang-tidy-4.0;-checks=-*,readability-redundant-string-cstr;-fix;-fix-errors
* Merge topic 'cpack-fix-deb-packaging'Brad King2018-07-031-0/+6
|\ | | | | | | | | | | | | 2774259100 CPack/Deb: Restore setting of root as the owner of files Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !2178
| * CPack/Deb: Restore setting of root as the owner of filesAndrew Fuller2018-07-021-0/+6
| | | | | | | | | | | | Refactoring in commit v3.10.0-rc1~220^2 (cmCPackDebGenerator: Use libarchive to create .deb file) accidentally broke this for the top-level archive.
* | CPack: Move internal implementation modules into Internal/CPack directoryKyle Edwards2018-06-211-2/+2
|/ | | | | | | | | | | | | | | These modules are not meant to be included by user code, they are only an internal implementation detail for CPack. Having them live in the main Modules directory with documentation was misleading, so they have been moved into Modules/Internal/CPack, and their documentation has been stripped following its move into the new "CPack Generators" section. No-op modules which contained only documentation have been removed entirely. The only module that hasn't been moved is CPackIFW, because it contains user-facing macros which would be lost if it were moved. So, the CPackIFW module has been updated with a note explaining what needs to (eventually) happen.
* Revise C++ coding style using clang-format-6.0Kitware Robot2018-06-011-24/+33
| | | | | | | | | | | | Run the `clang-format.bash` script to update all our C and C++ code to a new style defined by `.clang-format`. Use `clang-format` version 6.0. * If you reached this commit for a line in `git blame`, re-run the blame operation starting at the parent of this commit to see older history for the content. * See the parent commit for instructions to rebase a change across this style transition commit.
* Reduce allocation of temporary values on heap.Pavel Solodovnikov2018-01-261-2/+2
| | | | | - Use `std::move` while inserting temporary results into vectors. - Change `push_back` to `emplace_back` where appropriate.
* Merge topic 'ranged-for'Brad King2017-09-191-46/+30
|\ | | | | | | | | | | | | f43baf69 Meta: modernize old-fashioned loops to range-based `for` (CPack). Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !1274
| * Meta: modernize old-fashioned loops to range-based `for` (CPack).Pavel Solodovnikov2017-09-191-46/+30
| | | | | | | | | | | | Changes done via `clang-tidy` with some manual fine-tuning for the variable naming and `auto` type deduction where appropriate.